Summary

Fix unit tests to not pollute the test directories of other tests.

Review Request #9654 — Created Feb. 16, 2018 and discarded April 26, 2018, 11:35 a.m.

Information

Owner

solarmist

Repository

RBTools

Branch

master

Bugs

Depends On

~~9693~~

Blocks

9655

Reviewers

Groups

rbtools

People

Description

Fix test pollution and unit tests.
What was happening was that a single test failure would cause all following tests to fail with directory not found when trying to modify the home directory.

This also uncovered an issue with test_diff_exclude_in_subdir and test_diff_exclude_root_pattern_in_subdir
Also I'm removing the mktemp since it is deprecated and the class already provides that functionality.

Testing Done

time ./tests/runtests.py
/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/pyversion.py:36: DeprecationWarning: The 'new' module has been removed in Python 3.0; use the 'types' module instead.

  import new

/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/plugins/prof.py:14: DeprecationWarning: The 'hotshot' module is not supported in 3.x, use the 'profile' module instead.

  import hotshot

/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/pyversion.py:49: DeprecationWarning: Overriding __eq__ blocks inheritance of __hash__ in 3.x

  class Key(object):

#1 Testing the cache with a high max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:479: DeprecationWarning: buffer() not supported in 3.x

  sqlite3.Binary(entry.response_body)))

ok

#2 Testing the cache with a zero max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:493: DeprecationWarning: buffer() not supported in 3.x

  sqlite3.Binary(entry.response_body), entry.url,

ok

...

Ran 210 tests in 204.074s
OK

./tests/runtests.py  85.38s user 56.70s system 69% cpu 3:24.53 total

Issues

Description	From	Last Updated
Again, you do not need to include the entire test output.	brennie	Feb. 22, 2018, 3:47 p.m.
Blank line between these. Mind also fixing the ending bit of the docstring? The """ was supposed to be on …	chipx86	Feb. 18, 2018, 12:44 a.m.
I'd like the docstrings to go into more detail on the reasons they'd be used. As it is, I'm not …	chipx86	Feb. 18, 2018, 12:34 a.m.
I'm not sure how this actually works. If we don't call RBTestBase.setUp(), self._old_cwd will never be defined, which is used …	david	March 15, 2018, 7:25 p.m.
Sentences in comments should end in a period.	david	March 15, 2018, 7:19 p.m.
Why was this moved? Can you clarify the motivation?	david	March 16, 2018, 6:57 a.m.
This seems unrelated to the rest of the change.	david	March 16, 2018, 6:56 a.m.
This should fit on one line (just barely)	david	March 24, 2018, 2:24 p.m.
This should fit on one line.	david	March 24, 2018, 2:28 p.m.
There's some weird spelling/grammar in here. Might be nice to rewrite but can you at least change "suit" to "suite"?	david	March 24, 2018, 2:31 p.m.

flake8 passed.

JSHint passed.

Description:

		Fix unit tests.

~		This is the main testing fix.
	~	This is the main testing fix.
	+	https://reviews.reviewboard.org/r/9648/
	+	https://reviews.reviewboard.org/r/9649/
	+	https://reviews.reviewboard.org/r/9650/
	+	https://reviews.reviewboard.org/r/9651/
	+	https://reviews.reviewboard.org/r/9652/
	+	https://reviews.reviewboard.org/r/9653/
	+	https://reviews.reviewboard.org/r/9654/
	+	https://reviews.reviewboard.org/r/9655/

Depends On:

+	~~9648 - Fix exception handling, and update imports~~
+	~~9649 - Make six use consistant.~~
+	~~9650 - Fix log messages~~
+	~~9651 - Make quote use consistent across repo~~
+	~~9652 - Fix various things for python 3 compatibility~~
+	~~9653 - Refactor encode_multipart_formdata and tests to be easier to read and maintain~~
+	~~9654 - Fix unit tests to not pollute the test directories of other tests.~~
+	~~9655 - Fix various PEP 8, style and PyFlakes issues~~

I feel like this change is perhaps trying to do too much. There's a cleanup of sorts with the home directory, but then a rewrite of some of the Bazaar tests, and other misc. changes. It's best to keep review requests focused, tackling a single thing, to help with review and to help to locate the causes of regressions later on.

solarmist Feb. 17, 2018, 8:41 a.m.

These are all very related. I was having tons of test failures because of test pollution. Each set of tests was moving directories around in their own ways. This makes all directory manipulation happen through the testbase class.

The only pieces not directly related to that is changing a variable name to not use a keyword and making FOO strings for bzr.

chipx86 Feb. 17, 2018, 10:27 a.m.

Makes sense. Still, breaking off the home directory cleanup from the Bazaar cleanup would make sense, so that each is focused on a task. I don't imagine the Bazaar cleanup is necessary for the home directory cleanup.

solarmist Feb. 18, 2018, 12:42 a.m.

Yup, that's what I did. I also refactored a bit more and I think it's cleaner now.

rbtools/utils/testbase.py (Diff revision 1)

The issue has been resolved. Show all issues

Blank line between these.

Mind also fixing the ending bit of the docstring? The """ was supposed to be on its own line.

solarmist Feb. 17, 2018, 8:41 a.m.
```
Sure.
```

rbtools/utils/testbase.py (Diff revision 1)

The issue has been resolved. Show all issues

I'd like the docstrings to go into more detail on the reasons they'd be used. As it is, I'm not even clear.

solarmist Feb. 17, 2018, 8:41 a.m.

Will do.  I needed the reeset_user_home function because of test pollution going on causing a failure in one test file to cause all remaining client unit tests to fail.  The other one I can drop, but seemed like it might be useful for subclassed tests in the future.  Like hg-svn after hg tests and git-svn tests following git tests. I can drop that functionality if you'd like.

Description:

~		Fix unit tests.
	~	Fix test pollution.

~		This is the main testing fix.
~		https://reviews.reviewboard.org/r/9648/
~		https://reviews.reviewboard.org/r/9649/
	~	What was happening was that a single test failure would cause all following tests to fail with directory not found when trying to modify the home directory.
	~
	~	Also I'm removing the mktemp since it is deprecated and the class already provides that functionality.
-		https://reviews.reviewboard.org/r/9650/
-		https://reviews.reviewboard.org/r/9651/
-		https://reviews.reviewboard.org/r/9652/
-		https://reviews.reviewboard.org/r/9653/
-		https://reviews.reviewboard.org/r/9654/
-		https://reviews.reviewboard.org/r/9655/

Commit:

-	8fd30386fb33cd24b901072ab83bda8ed84eba17
+	05eb27320c317389c413555d3ee40f4b10c56738

Diff:

Revision 2 (+60 -33)

Show changes

	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_bzr.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/utils/testbase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commit:

-	05eb27320c317389c413555d3ee40f4b10c56738
+	1cd0f512f501f190e10cbb35f8e181bf3cb4d413

Diff:

Revision 3 (+62 -34)

Show changes

	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_bzr.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/utils/testbase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	Fix unit tests
+	Fix unit tests to not pollute the test directories of other tests.

Testing Done:

~		Not sure what to put here since these intermediate commits don't pass tests or flake8.
	~	time ./tests/runtests.py
	+
	+	/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/pyversion.py:36: DeprecationWarning: The 'new' module has been removed in Python 3.0; use the 'types' module instead.
	+	import new
	+	/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/plugins/prof.py:14: DeprecationWarning: The 'hotshot' module is not supported in 3.x, use the 'profile' module instead.
	+	import hotshot
	+	/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/pyversion.py:49: DeprecationWarning: Overriding eq blocks inheritance of hash in 3.x
	+	class Key(object):
	+
	+	1 Testing the cache with a high max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:479: DeprecationWarning: buffer() not supported in 3.x
	+
	+	sqlite3.Binary(entry.response_body)))
	+	ok
	+
	+	2 Testing the cache with a zero max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:493: DeprecationWarning: buffer() not supported in 3.x
	+
	+	sqlite3.Binary(entry.response_body), entry.url,
	+	ok
	+
	+	3 Testing the cache with the must-revalidate control ... ok
	+
	+	4 Testing the cache with the no-store control ... ok
	+
	+	5 Testing the cache with the no-cache control ... ok
	+
	+	6 Testing the cache with the no-cache control and a specified ETag ... ok
	+
	+	7 Testing the cache with the no-cache control and an updated ETag ... ok
	+
	+	8 Testing the cache with the no-cache control ... ok
	+
	+	9 Testing the cache with the no-cache control and an updated Last-Modified header ... ok
	+
	+	10 Testing the cache with the Expires header in the past ... ok
	+
	+	11 Testing the cache with the Expires header in the future ... ok
	+
	+	12 Testing the cache with an Expires header that is overridden ... ok
	+
	+	13 Testing the cache with the Pragma: no-cache header ... ok
	+
	+	14 Testing writing to the cache with non-ASCII data ... ok
	+
	+	15 Testing the cache with the Vary header ... ok
	+
	+	16 Testing the cache with the Vary header and different requests ... ok
	+
	+	17 Testing Capabilities.has_capability with supported capability ... ok
	+
	+	18 Testing Capabilities.has_capability with partial capability path ... ok
	+
	+	19 Testing Capabilities.has_capability with unknown capability ... ok
	+
	+	20 Testing the default values. ... ok
	+
	+	21 Testing the multipart form data generation. ... ok
	+
	+	22 Testing the encoding of multipart form data with unicode and binary field data ... ok
	+
	+	23 Testing constructing a count resource. ... ok
	+
	+	24 Testing constructing an item resource. ... ok
	+
	+	25 Testing constructing a list resource. ... ok
	+
	+	26 Testing constructing without guessing the resource token. ... ok
	+
	+	27 Testing constructing a resource with a specific base class. ... ok
	+
	+	28 Testing guessing the resource's token. ... ok
	+
	+	29 Testing rewriting of extra_data__ parameters to create ... ok
	+
	+	30 Testing rewriting of exta_data__ parameters to update ... ok
	+
	+	31 Testing item resource fields. ... ok
	+
	+	32 Testing item resource link generation. ... ok
	+
	+	33 Testing access of a link field. ... ok
	+
	+	34 Testing link resource link generation. ... ok
	+
	+	35 Testing list resource lists. ... ok
	+
	+	36 Testing access of a dictionary field. ... ok
	+
	+	37 Testing iterating sub-fields of a dictionary field. ... ok
	+
	+	38 Testing generation of methods for the root resource uri templates. ... ok
	+
	+	39 Testing ReviewRequestResource.absolute_url with 'absolute_url' field ... ok
	+
	+	40 Testing ReviewRequestResource.absolute_url with generated fallback URL ... ok
	+
	+	41 Testing ReviewRequestResource.absolute_url with 'url' field ... ok
	+
	+	42 Testing BazaarClient diff with file exclusion. ... ok
	+
	+	43 Testing BazaarClient diff with file exclusion in a subdirectory. ... ok
	+
	+	44 Testing BazaarClient diff with file exclusion in the repo root. ... ok
	+
	+	45 Testing BazaarClient diff with changes between a 2nd level descendant ... ok
	+
	+	46 Testing BazaarClient diff with changes only in the parent branch ... ok
	+
	+	47 Testing BazaarClient simple diff case ... ok
	+
	+	48 Testing BazaarClient simple diff with multiple commits case ... ok
	+
	+	49 Testing BazaarClient diff with specific files ... ok
	+
	+	50 Testing BazaarClient get_repository_info with child branch ... ok
	+
	+	51 Testing BazaarClient get_repository_info, no branch ... ok
	+
	+	52 Testing BazaarClient get_repository_info with original branch ... ok
	+
	+	53 Testing BazaarClient guessing summary and description ... ok
	+
	+	54 Testing BazaarClient guessing summary and description for grand parent branch. ... ok
	+
	+	55 Testing BazaarClient guessing summary and description with a revision range. ... ok
	+
	+	56 Testing BazaarClient.parse_revision_spec with no specified revisions ... ok
	+
	+	57 Testing BazaarClient.parse_revision_spec with one specified revision ... ok
	+
	+	58 Testing BazaarClient.parse_revision_spec with one specified revision and a parent diff ... ok
	+
	+	59 Testing BazaarClient.parse_revision_spec with R1..R2 syntax ... ok
	+
	+	60 Testing BazaarClient.parse_revision_spec with two revisions ... ok
	+
	+	61 Testing BazaarClient parse_revision_spec with too many revisions ... ok
	+
	+	62 Testing GitClient.create_commit with all_files set to True. ... ok
	+
	+	63 Testing GitClient.create_commit with run_editor set to True. ... ok
	+
	+	64 Testing GitClient.create_commit with all_files set to False. ... ok
	+
	+	65 Testing GitClient.create_commit with run_editor set to False. ... ok
	+
	+	66 Testing GitClient.delete_branch with merged_only set to True. ... ok
	+
	+	67 Testing GitClient.delete_branch with merged_only set to False. ... ok
	+
	+	68 Testing GitClient diff with divergent branches ... ok
	+
	+	69 Testing GitClient simple diff with file exclusion. ... ok
	+
	+	70 Testing GitClient simple diff with file exclusion in a subdir ... ok
	+
	+	71 Testing GitClient diff with file exclusion in the repo root. ... ok
	+
	+	72 Testing GitClient.parse_revision_spec with target branch off a tracking branch not aligned with the remote ... ok
	+
	+	73 Testing GitClient.parse_revision_spec with a target branch not up-to-date with a remote branch ... ok
	+
	+	74 Testing GitClient.parse_revision_spec with a target branch posted off a tracking branch that merged another tracking branch ... ok
	+
	+	75 Testing GitClient.parse_revision_spec with a target branch that merged a tracking branch off another tracking branch ... ok
	+
	+	76 Testing GitClient.parse_revision_spec with a target branch that has branches from different remotes in its path ... ok
	+
	+	77 Testing GitClient.parse_revision_spec with target branch off a tracking branch aligned with the remote ... ok
	+
	+	78 Testing GitClient.parse_revision_spec with a target branch posted off a remote branch that is aligned to the same commit as another remote branch ... ok
	+
	+	79 Testing GitClient.parse_revision_spec with a target branch posted off a remote branch without any tracking branches ... ok
	+
	+	80 Testing GitClient.parse_revision_spec with target branch off a branch not properly tracking the remote ... ok
	+
	+	81 Testing GitClient.parse_revision_spec with target branch off a tracking branch with changes since the remote ... ok
	+
	+	82 Testing GitClient diff with a local tracking branch ... ok
	+
	+	83 Testing GitClient simple diff case ... ok
	+
	+	84 Testing GitClient simple diff with multiple commits case ... ok
	+
	+	85 Testing GitClient diff with tracking branch that has slash in its name ... ok
	+
	+	86 Testing GitClient diff with a tracking branch, but no origin remote ... ok
	+
	+	87 Testing GitClient diff with option override for tracking branch ... ok
	+
	+	88 Testing GitClient.get_raw_commit_message ... ok
	+
	+	89 Testing GitClient get_repository_info, simple case ... ok
	+
	+	90 Testing GitClient.merge with an invalid destination branch. ... ok
	+
	+	91 Testing GitClient.merge with an invalid target branch. ... ok
	+
	+	92 Testing GitClient.merge with squash set to True. ... ok
	+
	+	93 Testing GitClient.merge with squash set to False. ... ok
	+
	+	94 Testing GitClient.parse_revision_spec with no specified revisions ... ok
	+
	+	95 Testing GitClient.parse_revision_spec with no specified revisions and a parent diff ... ok
	+
	+	96 Testing GitClient.parse_revision_spec with one specified revision ... ok
	+
	+	97 Testing GitClient.parse_revision_spec with one specified revision and a parent diff ... ok
	+
	+	98 Testing GitClient.parse_revision_spec with diff-since-merge syntax ... ok
	+
	+	99 Testing GitClient.parse_revision_spec with diff-since syntax ... ok
	+
	+	100 Testing GitClient.parse_revision_spec with two specified revisions ... ok
	+
	+	101 Testing GitClient.push_upstream with 'git push' disabled. ... ok
	+
	+	102 Testing GitClient.push_upstream with an invalid remote branch. ... ok
	+
	+	103 Testing GitClient scan_for_server using repo property ... ok
	+
	+	104 Testing GitClient scan_for_server, .reviewboardrc case ... ok
	+
	+	105 Testing GitClient scan_for_server, simple case ... ok
	+
	+	106 Testing GitClient parse_revision_spec with too many revisions ... ok
	+
	+	107 Testing MercurialClient diff with diverged branch ... ok
	+
	+	108 Testing MercurialClient diff with file exclusion ... ok
	+
	+	109 Testing MercurialClient diff with empty file exclusion ... ok
	+
	+	110 Testing MercurialClient parent diffs with a diverged branch ... ok
	+
	+	111 Testing MercurialClient parent diffs with a simple case ... ok
	+
	+	112 Testing MercurialClient parent diffs with a diverged branch and --parent option ... ok
	+
	+	113 Testing MercurialClient diff, simple case ... ok
	+
	+	114 Testing MercurialClient diff with multiple commits ... ok
	+
	+	115 Testing MercurialClient get_repository_info, simple case ... ok
	+
	+	116 Testing MercurialClient guess summary & description 1 commit ... ok
	+
	+	117 Testing MercurialClient guess summary & description middle commit ... ok
	+
	+	118 Testing MercurialClient guess summary & description 3 commits ... ok
	+
	+	119 Testing MercurialClient guess summary & description 2 commits ... ok
	+
	+	120 Testing MercurialClient.parse_revision_spec with no arguments ... ok
	+
	+	121 Testing MercurialClient.parse_revision_spec with one revision ... ok
	+
	+	122 Testing MercurialClient.parse_revision_spec with r1::r2 syntax ... ok
	+
	+	123 Testing MercurialClient.parse_revision_spec with r1..r2 syntax ... ok
	+
	+	124 Testing MercurialClient.parse_revision_spec with parent base ... ok
	+
	+	125 Testing MercurialClient.parse_revision_spec with two revisions ... ok
	+
	+	126 Testing MercurialClient scan_for_server when in .reviewboardrc ... ok
	+
	+	127 Testing MercurialClient scan_for_server, simple case ... ok
	+
	+	128 Testing MercurialClient scan_for_server when present in hgrc ... ok
	+
	+	129 Testing MercurialClient (+svn) _calculate_hgsubversion_repository_info properly determines repository and base paths ... ok
	+
	+	130 Testing MercurialClient (+svn) diff specifying a revision ... ok
	+
	+	131 Testing MercurialClient (+svn) diff, simple case ... ok
	+
	+	132 Testing MercurialClient (+svn) diff with multiple commits ... ok
	+
	+	133 Testing MercurialClient (+svn) get_repository_info, simple case ... ok
	+
	+	134 Testing MercurialClient (+svn) scan_for_server in svn property ... ok
	+
	+	135 Testing MercurialClient (+svn) scan_for_server in .reviewboardrc ... ok
	+
	+	136 Testing MercurialClient (+svn) scan_for_server, simple case ... ok
	+
	+	137 Testing P4Wrapper.counters ... ok
	+
	+	138 Testing P4Wrapper.info ... ok
	+
	+	139 Testing PerforceClient.normalize_exclude_patterns ... ok
	+
	+	140 Testing PerforceClient.diff with a submitted changelist ... ok
	+
	+	141 Testing PerforceClient.diff with moved files and capability off ... ok
	+
	+	142 Testing PerforceClient.diff with moved files and capability on ... ok
	+
	+	143 Testing PerforceClient.diff with a pending changelist ... ok
	+
	+	144 Testing PerforceClient.parse_revision_spec with invalid specifications ... ok
	+
	+	145 Testing PerforceClient.parse_revision_spec with no specified revisions ... ok
	+
	+	146 Testing PerforceClient.parse_revision_spec with a pending changelist ... ok
	+
	+	147 Testing PerforceClient.parse_revision_spec with a shelved changelist ... ok
	+
	+	148 Testing PerforceClient.parse_revision_spec with a submitted changelist ... ok
	+
	+	149 Testing PerforceClient.parse_revision_spec with two changelists ... ok
	+
	+	150 Testing PerforceClient.get_repository_info ... ok
	+
	+	151 Testing PerforceClient.get_repository_info outside client root ... ok
	+
	+	152 Testing PerforceClient.scan_for_server_counter with reviewboard.url ... ok
	+
	+	153 Testing PerforceClient.scan_for_server_counter with encoded reviewboard.url.http:\|\| ... ok
	+
	+	154 Testing SVNClient diff with file exclude patterns ... ok
	+
	+	155 Testing SVNClient diff with exclude patterns in a subdir ... ok
	+
	+	156 Testing SVNClient diff with repo exclude patterns in a subdir ... ok
	+
	+	157 Testing SVNClient diff with a non-utf8 file ... ok
	+
	+	158 Testing SVNClient diff with a non-utf8 filename via repository_url option ... ok
	+
	+	159 Testing SVNClient.get_commit_message with a single committed revision ... ok
	+
	+	160 Testing SVNClient.get_commit_message with multiple committed revisions ... ok
	+
	+	161 Testing SVNClient.get_commit_message with a working copy change ... ok
	+
	+	162 Testing SVNClient.history_scheduled_with_commit nominal cases ... ok
	+
	+	163 Testing SVNClient.history_scheduled_with_commit with exclude file ... ok
	+
	+	164 Testing SVNClient.history_scheduled_with_commit is bypassed when diff is not for local modifications in a working copy ... ok
	+
	+	165 Testing SVNClient.parse_revision_spec with invalid specifications ... ok
	+
	+	166 Testing SVNClient.parse_revision_spec with no specified revisions ... ok
	+
	+	167 Testing SVNClient.parse_revision_spec with a non-utf8 log entry ... ok
	+
	+	168 Testing SVNClient.parse_revision_spec with R1:R2 syntax ... ok
	+
	+	169 Testing SVNClient.parse_revision_spec with one specified numeric revision ... ok
	+
	+	170 Testing SVNClient.parse_revision_spec with one specified changelist revision ... ok
	+
	+	171 Testing SVNClient.parse_revision_spec with one specified invalid changelist revision ... ok
	+
	+	172 Testing SVNClient.parse_revision_spec with one revision and a repository URL ... ok
	+
	+	173 Testing SVNClient.parse_revision_spec with two revisions ... ok
	+
	+	174 Testing SVNClient.parse_revision_spec with R1:R2 syntax and a repository URL ... ok
	+
	+	175 Test diff with removal of lines that look like headers ... ok
	+
	+	176 Testing SVNClient identical diff generated from root, subdirectory, and via target ... ok
	+
	+	177 Testing SVNClient with --show-copies-as-adds functionality disabled ... ok
	+
	+	178 Testing SVNClient with --show-copies-as-adds functionality enabled ... ok
	+
	+	179 Testing SVNRepositoryInfo.find_server_repository_info with mirror_path matching ... ok
	+
	+	180 Testing SVNRepositoryInfo.find_server_repository_info with path matching ... ok
	+
	+	181 Testing SVNRepositoryInfo.find_server_repository_info with UUID matching ... ok
	+
	+	182 Testing SVNRepositoryInfo._get_relative_path ... ok
	+
	+	183 Testing argument duplication with rbt post --field myField=test --description test ... ok
	+
	+	184 Testing multiple delimiters with rbt post --field myField=this=string=has=equals=signs ... ok
	+
	+	185 Testing built-in fields through extra_fields with rbt post --field description=testing --field summary='native testing' --field testing-done='No tests' ... ok
	+
	+	186 Testing setting target group via config file with rbt post ... ok
	+
	+	187 Testing setting target person via config file with rbt post ... ok
	+
	+	188 Testing multiple extra field arguments with rbt post --field foo=bar --field desc=new ... ok
	+
	+	189 Testing setting target group on update via config file with rbt post --review-request-id=12345 ... ok
	+
	+	190 Testing setting target person on update via config file with rbt post --review-request-id=12345 ... ok
	+
	+	191 Testing one extra field argument with rbt post --field foo=bar ... ok
	+
	+	192 Testing setting the target group with rbt post --target-groups=test_group ... ok
	+
	+	193 Testing setting the target group on an update with rbt post --target-groups=test_group --review-request-id=12345 ... ok
	+
	+	194 Testing setting the target person with rbt post --target-people=test_person ... ok
	+
	+	195 Testing setting the target person on an update with rbt post --target-people=test_person --review-request-id=12345 ... ok
	+
	+	196 Testing built-in fields through extra_fields with rbt post --field description and rbt post --field testing_done='No tests' ... ok
	+
	+	197 Testing variable substitution with alphabetic variables ... ok
	+
	+	198 Testing alias substitution with a slash at the end of the string ... ok
	+
	+	199 Testing variable substitution where no variables are supplied ... ok
	+
	+	200 Testing alias substitution with bad quotes. ... ok
	+
	+	201 Testing variable substitution in rbtools aliases ... ok
	+
	+	202 Testing variable substitution where the argument isn't supplied ... ok
	+
	+	203 Testing variable substitution with the $* variable ... ok
	+
	+	204 Testing $* variable substitution with whitespace-containing args ... ok
	+
	+	205 Testing variable substitution where multiple variables appear ... ok
	+
	+	206 Testing 'check_install' method. ... ok
	+
	+	207 Testing 'execute' method. ... ok
	+
	+	208 Testing 'is_valid_version' method. ... ok
	+
	+	209 Testing 'make_empty_files' method. ... ok
	+
	+	210 Testing 'make_tempfile' method. ... ok
	+
	+
	+
	+	Ran 210 tests in 204.074s
	+
	+	OK
	+	./tests/runtests.py 85.38s user 56.70s system 69% cpu 3:24.53 total

Depends On:

-	~~9648 - Fix exception handling, and update imports~~
-	~~9649 - Make six use consistant.~~
-	~~9650 - Fix log messages~~
-	~~9651 - Make quote use consistent across repo~~
-	~~9652 - Fix various things for python 3 compatibility~~
-	~~9653 - Refactor encode_multipart_formdata and tests to be easier to read and maintain~~
-	~~9654 - Fix unit tests to not pollute the test directories of other tests.~~
-	~~9655 - Fix various PEP 8, style and PyFlakes issues~~
+	~~9693 - Use --use-existing-dir with the branch command for bzr~~

Commit:

-	1cd0f512f501f190e10cbb35f8e181bf3cb4d413
+	c9484922f9ac151d9c6b4b5d711f8eb6f07b6d93

Diff:

Revision 4 (+70 -34)

Show changes

	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_bzr.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/utils/testbase.py
	tests/runtests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues
```
Again, you do not need to include the entire test output.
```
1. solarmist Feb. 22, 2018, 3:47 p.m.
  Fixed.

Change Summary:

Summarized the testing done

Testing Done:

		time ./tests/runtests.py

		/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/pyversion.py:36: DeprecationWarning: The 'new' module has been removed in Python 3.0; use the 'types' module instead.
		import new
		/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/plugins/prof.py:14: DeprecationWarning: The 'hotshot' module is not supported in 3.x, use the 'profile' module instead.
		import hotshot
~		/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/pyversion.py:49: DeprecationWarning: Overriding eq blocks inheritance of hash in 3.x
~		class Key(object):
~
~		1 Testing the cache with a high max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:479: DeprecationWarning: buffer() not supported in 3.x
~
~		sqlite3.Binary(entry.response_body)))
~		ok
~
~		2 Testing the cache with a zero max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:493: DeprecationWarning: buffer() not supported in 3.x
~
	~	/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/pyversion.py:49: DeprecationWarning: Overriding __eq__ blocks inheritance of __hash__ in 3.x
	~	class Key(object):
	~	#1 Testing the cache with a high max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:479: DeprecationWarning: buffer() not supported in 3.x
	~	sqlite3.Binary(entry.response_body)))
	~	ok
	~	#2 Testing the cache with a zero max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:493: DeprecationWarning: buffer() not supported in 3.x
	~	sqlite3.Binary(entry.response_body), entry.url,
	~	ok
	~	...
	~	Ran 210 tests in 204.074s
-		sqlite3.Binary(entry.response_body), entry.url,
-		ok
-
-		3 Testing the cache with the must-revalidate control ... ok
-
-		4 Testing the cache with the no-store control ... ok
-
-		5 Testing the cache with the no-cache control ... ok
-
-		6 Testing the cache with the no-cache control and a specified ETag ... ok
-
-		7 Testing the cache with the no-cache control and an updated ETag ... ok
-
-		8 Testing the cache with the no-cache control ... ok
-
-		9 Testing the cache with the no-cache control and an updated Last-Modified header ... ok
-
-		10 Testing the cache with the Expires header in the past ... ok
-
-		11 Testing the cache with the Expires header in the future ... ok
-
-		12 Testing the cache with an Expires header that is overridden ... ok
-
-		13 Testing the cache with the Pragma: no-cache header ... ok
-
-		14 Testing writing to the cache with non-ASCII data ... ok
-
-		15 Testing the cache with the Vary header ... ok
-
-		16 Testing the cache with the Vary header and different requests ... ok
-
-		17 Testing Capabilities.has_capability with supported capability ... ok
-
-		18 Testing Capabilities.has_capability with partial capability path ... ok
-
-		19 Testing Capabilities.has_capability with unknown capability ... ok
-
-		20 Testing the default values. ... ok
-
-		21 Testing the multipart form data generation. ... ok
-
-		22 Testing the encoding of multipart form data with unicode and binary field data ... ok
-
-		23 Testing constructing a count resource. ... ok
-
-		24 Testing constructing an item resource. ... ok
-
-		25 Testing constructing a list resource. ... ok
-
-		26 Testing constructing without guessing the resource token. ... ok
-
-		27 Testing constructing a resource with a specific base class. ... ok
-
-		28 Testing guessing the resource's token. ... ok
-
-		29 Testing rewriting of extra_data__ parameters to create ... ok
-
-		30 Testing rewriting of exta_data__ parameters to update ... ok
-
-		31 Testing item resource fields. ... ok
-
-		32 Testing item resource link generation. ... ok
-
-		33 Testing access of a link field. ... ok
-
-		34 Testing link resource link generation. ... ok
-
-		35 Testing list resource lists. ... ok
-
-		36 Testing access of a dictionary field. ... ok
-
-		37 Testing iterating sub-fields of a dictionary field. ... ok
-
-		38 Testing generation of methods for the root resource uri templates. ... ok
-
-		39 Testing ReviewRequestResource.absolute_url with 'absolute_url' field ... ok
-
-		40 Testing ReviewRequestResource.absolute_url with generated fallback URL ... ok
-
-		41 Testing ReviewRequestResource.absolute_url with 'url' field ... ok
-
-		42 Testing BazaarClient diff with file exclusion. ... ok
-
-		43 Testing BazaarClient diff with file exclusion in a subdirectory. ... ok
-
-		44 Testing BazaarClient diff with file exclusion in the repo root. ... ok
-
-		45 Testing BazaarClient diff with changes between a 2nd level descendant ... ok
-
-		46 Testing BazaarClient diff with changes only in the parent branch ... ok
-
-		47 Testing BazaarClient simple diff case ... ok
-
-		48 Testing BazaarClient simple diff with multiple commits case ... ok
-
-		49 Testing BazaarClient diff with specific files ... ok
-
-		50 Testing BazaarClient get_repository_info with child branch ... ok
-
-		51 Testing BazaarClient get_repository_info, no branch ... ok
-
-		52 Testing BazaarClient get_repository_info with original branch ... ok
-
-		53 Testing BazaarClient guessing summary and description ... ok
-
-		54 Testing BazaarClient guessing summary and description for grand parent branch. ... ok
-
-		55 Testing BazaarClient guessing summary and description with a revision range. ... ok
-
-		56 Testing BazaarClient.parse_revision_spec with no specified revisions ... ok
-
-		57 Testing BazaarClient.parse_revision_spec with one specified revision ... ok
-
-		58 Testing BazaarClient.parse_revision_spec with one specified revision and a parent diff ... ok
-
-		59 Testing BazaarClient.parse_revision_spec with R1..R2 syntax ... ok
-
-		60 Testing BazaarClient.parse_revision_spec with two revisions ... ok
-
-		61 Testing BazaarClient parse_revision_spec with too many revisions ... ok
-
-		62 Testing GitClient.create_commit with all_files set to True. ... ok
-
-		63 Testing GitClient.create_commit with run_editor set to True. ... ok
-
-		64 Testing GitClient.create_commit with all_files set to False. ... ok
-
-		65 Testing GitClient.create_commit with run_editor set to False. ... ok
-
-		66 Testing GitClient.delete_branch with merged_only set to True. ... ok
-
-		67 Testing GitClient.delete_branch with merged_only set to False. ... ok
-
-		68 Testing GitClient diff with divergent branches ... ok
-
-		69 Testing GitClient simple diff with file exclusion. ... ok
-
-		70 Testing GitClient simple diff with file exclusion in a subdir ... ok
-
-		71 Testing GitClient diff with file exclusion in the repo root. ... ok
-
-		72 Testing GitClient.parse_revision_spec with target branch off a tracking branch not aligned with the remote ... ok
-
-		73 Testing GitClient.parse_revision_spec with a target branch not up-to-date with a remote branch ... ok
-
-		74 Testing GitClient.parse_revision_spec with a target branch posted off a tracking branch that merged another tracking branch ... ok
-
-		75 Testing GitClient.parse_revision_spec with a target branch that merged a tracking branch off another tracking branch ... ok
-
-		76 Testing GitClient.parse_revision_spec with a target branch that has branches from different remotes in its path ... ok
-
-		77 Testing GitClient.parse_revision_spec with target branch off a tracking branch aligned with the remote ... ok
-
-		78 Testing GitClient.parse_revision_spec with a target branch posted off a remote branch that is aligned to the same commit as another remote branch ... ok
-
-		79 Testing GitClient.parse_revision_spec with a target branch posted off a remote branch without any tracking branches ... ok
-
-		80 Testing GitClient.parse_revision_spec with target branch off a branch not properly tracking the remote ... ok
-
-		81 Testing GitClient.parse_revision_spec with target branch off a tracking branch with changes since the remote ... ok
-
-		82 Testing GitClient diff with a local tracking branch ... ok
-
-		83 Testing GitClient simple diff case ... ok
-
-		84 Testing GitClient simple diff with multiple commits case ... ok
-
-		85 Testing GitClient diff with tracking branch that has slash in its name ... ok
-
-		86 Testing GitClient diff with a tracking branch, but no origin remote ... ok
-
-		87 Testing GitClient diff with option override for tracking branch ... ok
-
-		88 Testing GitClient.get_raw_commit_message ... ok
-
-		89 Testing GitClient get_repository_info, simple case ... ok
-
-		90 Testing GitClient.merge with an invalid destination branch. ... ok
-
-		91 Testing GitClient.merge with an invalid target branch. ... ok
-
-		92 Testing GitClient.merge with squash set to True. ... ok
-
-		93 Testing GitClient.merge with squash set to False. ... ok
-
-		94 Testing GitClient.parse_revision_spec with no specified revisions ... ok
-
-		95 Testing GitClient.parse_revision_spec with no specified revisions and a parent diff ... ok
-
-		96 Testing GitClient.parse_revision_spec with one specified revision ... ok
-
-		97 Testing GitClient.parse_revision_spec with one specified revision and a parent diff ... ok
-
-		98 Testing GitClient.parse_revision_spec with diff-since-merge syntax ... ok
-
-		99 Testing GitClient.parse_revision_spec with diff-since syntax ... ok
-
-		100 Testing GitClient.parse_revision_spec with two specified revisions ... ok
-
-		101 Testing GitClient.push_upstream with 'git push' disabled. ... ok
-
-		102 Testing GitClient.push_upstream with an invalid remote branch. ... ok
-
-		103 Testing GitClient scan_for_server using repo property ... ok
-
-		104 Testing GitClient scan_for_server, .reviewboardrc case ... ok
-
-		105 Testing GitClient scan_for_server, simple case ... ok
-
-		106 Testing GitClient parse_revision_spec with too many revisions ... ok
-
-		107 Testing MercurialClient diff with diverged branch ... ok
-
-		108 Testing MercurialClient diff with file exclusion ... ok
-
-		109 Testing MercurialClient diff with empty file exclusion ... ok
-
-		110 Testing MercurialClient parent diffs with a diverged branch ... ok
-
-		111 Testing MercurialClient parent diffs with a simple case ... ok
-
-		112 Testing MercurialClient parent diffs with a diverged branch and --parent option ... ok
-
-		113 Testing MercurialClient diff, simple case ... ok
-
-		114 Testing MercurialClient diff with multiple commits ... ok
-
-		115 Testing MercurialClient get_repository_info, simple case ... ok
-
-		116 Testing MercurialClient guess summary & description 1 commit ... ok
-
-		117 Testing MercurialClient guess summary & description middle commit ... ok
-
-		118 Testing MercurialClient guess summary & description 3 commits ... ok
-
-		119 Testing MercurialClient guess summary & description 2 commits ... ok
-
-		120 Testing MercurialClient.parse_revision_spec with no arguments ... ok
-
-		121 Testing MercurialClient.parse_revision_spec with one revision ... ok
-
-		122 Testing MercurialClient.parse_revision_spec with r1::r2 syntax ... ok
-
-		123 Testing MercurialClient.parse_revision_spec with r1..r2 syntax ... ok
-
-		124 Testing MercurialClient.parse_revision_spec with parent base ... ok
-
-		125 Testing MercurialClient.parse_revision_spec with two revisions ... ok
-
-		126 Testing MercurialClient scan_for_server when in .reviewboardrc ... ok
-
-		127 Testing MercurialClient scan_for_server, simple case ... ok
-
-		128 Testing MercurialClient scan_for_server when present in hgrc ... ok
-
-		129 Testing MercurialClient (+svn) _calculate_hgsubversion_repository_info properly determines repository and base paths ... ok
-
-		130 Testing MercurialClient (+svn) diff specifying a revision ... ok
-
-		131 Testing MercurialClient (+svn) diff, simple case ... ok
-
-		132 Testing MercurialClient (+svn) diff with multiple commits ... ok
-
-		133 Testing MercurialClient (+svn) get_repository_info, simple case ... ok
-
-		134 Testing MercurialClient (+svn) scan_for_server in svn property ... ok
-
-		135 Testing MercurialClient (+svn) scan_for_server in .reviewboardrc ... ok
-
-		136 Testing MercurialClient (+svn) scan_for_server, simple case ... ok
-
-		137 Testing P4Wrapper.counters ... ok
-
-		138 Testing P4Wrapper.info ... ok
-
-		139 Testing PerforceClient.normalize_exclude_patterns ... ok
-
-		140 Testing PerforceClient.diff with a submitted changelist ... ok
-
-		141 Testing PerforceClient.diff with moved files and capability off ... ok
-
-		142 Testing PerforceClient.diff with moved files and capability on ... ok
-
-		143 Testing PerforceClient.diff with a pending changelist ... ok
-
-		144 Testing PerforceClient.parse_revision_spec with invalid specifications ... ok
-
-		145 Testing PerforceClient.parse_revision_spec with no specified revisions ... ok
-
-		146 Testing PerforceClient.parse_revision_spec with a pending changelist ... ok
-
-		147 Testing PerforceClient.parse_revision_spec with a shelved changelist ... ok
-
-		148 Testing PerforceClient.parse_revision_spec with a submitted changelist ... ok
-
-		149 Testing PerforceClient.parse_revision_spec with two changelists ... ok
-
-		150 Testing PerforceClient.get_repository_info ... ok
-
-		151 Testing PerforceClient.get_repository_info outside client root ... ok
-
-		152 Testing PerforceClient.scan_for_server_counter with reviewboard.url ... ok
-
-		153 Testing PerforceClient.scan_for_server_counter with encoded reviewboard.url.http:\|\| ... ok
-
-		154 Testing SVNClient diff with file exclude patterns ... ok
-
-		155 Testing SVNClient diff with exclude patterns in a subdir ... ok
-
-		156 Testing SVNClient diff with repo exclude patterns in a subdir ... ok
-
-		157 Testing SVNClient diff with a non-utf8 file ... ok
-
-		158 Testing SVNClient diff with a non-utf8 filename via repository_url option ... ok
-
-		159 Testing SVNClient.get_commit_message with a single committed revision ... ok
-
-		160 Testing SVNClient.get_commit_message with multiple committed revisions ... ok
-
-		161 Testing SVNClient.get_commit_message with a working copy change ... ok
-
-		162 Testing SVNClient.history_scheduled_with_commit nominal cases ... ok
-
-		163 Testing SVNClient.history_scheduled_with_commit with exclude file ... ok
-
-		164 Testing SVNClient.history_scheduled_with_commit is bypassed when diff is not for local modifications in a working copy ... ok
-
-		165 Testing SVNClient.parse_revision_spec with invalid specifications ... ok
-
-		166 Testing SVNClient.parse_revision_spec with no specified revisions ... ok
-
-		167 Testing SVNClient.parse_revision_spec with a non-utf8 log entry ... ok
-
-		168 Testing SVNClient.parse_revision_spec with R1:R2 syntax ... ok
-
-		169 Testing SVNClient.parse_revision_spec with one specified numeric revision ... ok
-
-		170 Testing SVNClient.parse_revision_spec with one specified changelist revision ... ok
-
-		171 Testing SVNClient.parse_revision_spec with one specified invalid changelist revision ... ok
-
-		172 Testing SVNClient.parse_revision_spec with one revision and a repository URL ... ok
-
-		173 Testing SVNClient.parse_revision_spec with two revisions ... ok
-
-		174 Testing SVNClient.parse_revision_spec with R1:R2 syntax and a repository URL ... ok
-
-		175 Test diff with removal of lines that look like headers ... ok
-
-		176 Testing SVNClient identical diff generated from root, subdirectory, and via target ... ok
-
-		177 Testing SVNClient with --show-copies-as-adds functionality disabled ... ok
-
-		178 Testing SVNClient with --show-copies-as-adds functionality enabled ... ok
-
-		179 Testing SVNRepositoryInfo.find_server_repository_info with mirror_path matching ... ok
-
-		180 Testing SVNRepositoryInfo.find_server_repository_info with path matching ... ok
-
-		181 Testing SVNRepositoryInfo.find_server_repository_info with UUID matching ... ok
-
-		182 Testing SVNRepositoryInfo._get_relative_path ... ok
-
-		183 Testing argument duplication with rbt post --field myField=test --description test ... ok
-
-		184 Testing multiple delimiters with rbt post --field myField=this=string=has=equals=signs ... ok
-
-		185 Testing built-in fields through extra_fields with rbt post --field description=testing --field summary='native testing' --field testing-done='No tests' ... ok
-
-		186 Testing setting target group via config file with rbt post ... ok
-
-		187 Testing setting target person via config file with rbt post ... ok
-
-		188 Testing multiple extra field arguments with rbt post --field foo=bar --field desc=new ... ok
-
-		189 Testing setting target group on update via config file with rbt post --review-request-id=12345 ... ok
-
-		190 Testing setting target person on update via config file with rbt post --review-request-id=12345 ... ok
-
-		191 Testing one extra field argument with rbt post --field foo=bar ... ok
-
-		192 Testing setting the target group with rbt post --target-groups=test_group ... ok
-
-		193 Testing setting the target group on an update with rbt post --target-groups=test_group --review-request-id=12345 ... ok
-
-		194 Testing setting the target person with rbt post --target-people=test_person ... ok
-
-		195 Testing setting the target person on an update with rbt post --target-people=test_person --review-request-id=12345 ... ok
-
-		196 Testing built-in fields through extra_fields with rbt post --field description and rbt post --field testing_done='No tests' ... ok
-
-		197 Testing variable substitution with alphabetic variables ... ok
-
-		198 Testing alias substitution with a slash at the end of the string ... ok
-
-		199 Testing variable substitution where no variables are supplied ... ok
-
-		200 Testing alias substitution with bad quotes. ... ok
-
-		201 Testing variable substitution in rbtools aliases ... ok
-
-		202 Testing variable substitution where the argument isn't supplied ... ok
-
-		203 Testing variable substitution with the $* variable ... ok
-
-		204 Testing $* variable substitution with whitespace-containing args ... ok
-
-		205 Testing variable substitution where multiple variables appear ... ok
-
-		206 Testing 'check_install' method. ... ok
-
-		207 Testing 'execute' method. ... ok
-
-		208 Testing 'is_valid_version' method. ... ok
-
-		209 Testing 'make_empty_files' method. ... ok
-
-		210 Testing 'make_tempfile' method. ... ok
-
-
-
-		Ran 210 tests in 204.074s

		OK
		./tests/runtests.py 85.38s user 56.70s system 69% cpu 3:24.53 total

Commit:

-	c9484922f9ac151d9c6b4b5d711f8eb6f07b6d93
+	4943cafdf58e7df47de833e4dafd3bc433c003e8

Diff:

Revision 5 (+70 -34)

Show changes

	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_bzr.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/utils/testbase.py
	tests/runtests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/tests/__init__.py (Diff revision 5)

The issue has been resolved. Show all issues

I'm not sure how this actually works. If we don't call RBTestBase.setUp(), self._old_cwd will never be defined, which is used in the (non-overridden) tearDown() method.

solarmist March 16, 2018, 6:57 a.m.

This isn't used. It was used in a previous iteration of the code, instead I copied the pattern from rbtools/utils/filesystem.py using globals.

I'm removing it.

rbtools/clients/tests/__init__.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Sentences in comments should end in a period.
```

rbtools/clients/tests/test_git.py (Diff revision 5)

The issue has been resolved. Show all issues

Why was this moved? Can you clarify the motivation?

solarmist March 16, 2018, 6:57 a.m.

Reverted and adding a comment.

It was moved to make it more clear what it was related to, but I tihnk a comment is a better choice.

rbtools/clients/tests/test_mercurial.py (Diff revision 5)

The issue has been dropped. Show all issues

This seems unrelated to the rest of the change.

solarmist March 16, 2018, 6:57 a.m.

It's relvenat to fixing up the tests because running svnserve single threaded makes testing/debugging issues more straightforward.

Commit:

-	4943cafdf58e7df47de833e4dafd3bc433c003e8
+	3f921c31c69e9c78e441ed6e059737c6764276f0

Diff:

Revision 6 (+70 -33)

Show changes

	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_bzr.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/utils/testbase.py
	tests/runtests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Forgot to add this fix to the last update.

Commit:

-	3f921c31c69e9c78e441ed6e059737c6764276f0
+	c4ba7718cbe822d471249ee520a327d4018d9b3f

Diff:

Revision 7 (+70 -33)

Show changes

	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_bzr.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/utils/testbase.py
	tests/runtests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/tests/__init__.py (Diff revision 7)

The issue has been resolved. Show all issues

This should fit on one line (just barely)

solarmist March 24, 2018, 2:42 p.m.

These comments are not useful at all. Having a consistent style is one thing, but being pedantic is another.

Code reviews and style guides are not meant to force every commit to have identical and perfect style.

rbtools/clients/tests/__init__.py (Diff revision 7)
The issue has been resolved. Show all issues
```
This should fit on one line.
```

rbtools/utils/testbase.py (Diff revision 7)

The issue has been resolved. Show all issues

There's some weird spelling/grammar in here. Might be nice to rewrite but can you at least change "suit" to "suite"?

solarmist March 24, 2018, 2:42 p.m.
```
Agreed.  I've re-worded it.
```

Commit:

-	c4ba7718cbe822d471249ee520a327d4018d9b3f
+	ecc239a77c4576312d081e8f4a9e0bff6f3aaf84

Diff:

Revision 8 (+72 -34)

Show changes

	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_bzr.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/utils/testbase.py
	tests/runtests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed two unit tests that were failing once I untangled everything.

Description:

~		Fix test pollution.
	~	Fix test pollution and unit tests.

~		What was happening was that a single test failure would cause all following tests to fail with directory not found when trying to modify the home directory.
	~	What was happening was that a single test failure would cause all following tests to fail with directory not found when trying to modify the home directory.
	+	This also uncovered an issue with test_diff_exclude_in_subdir and test_diff_exclude_root_pattern_in_subdir

		Also I'm removing the mktemp since it is deprecated and the class already provides that functionality.

Commit:

-	ecc239a77c4576312d081e8f4a9e0bff6f3aaf84
+	fe2237fefb51d20f715682532afc6902a6cc68f7

Diff:

Revision 9 (+104 -35)

Show changes

	rbtools/clients/git.py
	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_bzr.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/utils/testbase.py
	tests/runtests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Discarded

Change Summary:

Discarded in favor of /r/9895/

Fix unit tests to not pollute the test directories of other tests.

Information

Reviewers

Description:

Depends On:

Description:

Commit:

Diff:

Checks run (2 succeeded)

Commit:

Diff:

Checks run (2 succeeded)

Summary:

Testing Done:

1 Testing the cache with a high max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:479: DeprecationWarning: buffer() not supported in 3.x

2 Testing the cache with a zero max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:493: DeprecationWarning: buffer() not supported in 3.x

3 Testing the cache with the must-revalidate control ... ok

4 Testing the cache with the no-store control ... ok

5 Testing the cache with the no-cache control ... ok

6 Testing the cache with the no-cache control and a specified ETag ... ok

7 Testing the cache with the no-cache control and an updated ETag ... ok

8 Testing the cache with the no-cache control ... ok

9 Testing the cache with the no-cache control and an updated Last-Modified header ... ok

10 Testing the cache with the Expires header in the past ... ok

11 Testing the cache with the Expires header in the future ... ok

12 Testing the cache with an Expires header that is overridden ... ok

13 Testing the cache with the Pragma: no-cache header ... ok

14 Testing writing to the cache with non-ASCII data ... ok

15 Testing the cache with the Vary header ... ok

16 Testing the cache with the Vary header and different requests ... ok

17 Testing Capabilities.has_capability with supported capability ... ok

18 Testing Capabilities.has_capability with partial capability path ... ok

19 Testing Capabilities.has_capability with unknown capability ... ok

20 Testing the default values. ... ok

21 Testing the multipart form data generation. ... ok

22 Testing the encoding of multipart form data with unicode and binary field data ... ok

23 Testing constructing a count resource. ... ok

24 Testing constructing an item resource. ... ok

25 Testing constructing a list resource. ... ok

26 Testing constructing without guessing the resource token. ... ok

27 Testing constructing a resource with a specific base class. ... ok

28 Testing guessing the resource's token. ... ok

29 Testing rewriting of extra_data__ parameters to create ... ok

30 Testing rewriting of exta_data__ parameters to update ... ok

31 Testing item resource fields. ... ok

32 Testing item resource link generation. ... ok

33 Testing access of a link field. ... ok

34 Testing link resource link generation. ... ok

35 Testing list resource lists. ... ok

36 Testing access of a dictionary field. ... ok

37 Testing iterating sub-fields of a dictionary field. ... ok

38 Testing generation of methods for the root resource uri templates. ... ok

39 Testing ReviewRequestResource.absolute_url with 'absolute_url' field ... ok

40 Testing ReviewRequestResource.absolute_url with generated fallback URL ... ok

41 Testing ReviewRequestResource.absolute_url with 'url' field ... ok

42 Testing BazaarClient diff with file exclusion. ... ok

43 Testing BazaarClient diff with file exclusion in a subdirectory. ... ok

44 Testing BazaarClient diff with file exclusion in the repo root. ... ok

45 Testing BazaarClient diff with changes between a 2nd level descendant ... ok

46 Testing BazaarClient diff with changes only in the parent branch ... ok

47 Testing BazaarClient simple diff case ... ok

48 Testing BazaarClient simple diff with multiple commits case ... ok

49 Testing BazaarClient diff with specific files ... ok

50 Testing BazaarClient get_repository_info with child branch ... ok

51 Testing BazaarClient get_repository_info, no branch ... ok

52 Testing BazaarClient get_repository_info with original branch ... ok

53 Testing BazaarClient guessing summary and description ... ok

54 Testing BazaarClient guessing summary and description for grand parent branch. ... ok

55 Testing BazaarClient guessing summary and description with a revision range. ... ok

56 Testing BazaarClient.parse_revision_spec with no specified revisions ... ok

57 Testing BazaarClient.parse_revision_spec with one specified revision ... ok

58 Testing BazaarClient.parse_revision_spec with one specified revision and a parent diff ... ok

59 Testing BazaarClient.parse_revision_spec with R1..R2 syntax ... ok

60 Testing BazaarClient.parse_revision_spec with two revisions ... ok

61 Testing BazaarClient parse_revision_spec with too many revisions ... ok

62 Testing GitClient.create_commit with all_files set to True. ... ok

63 Testing GitClient.create_commit with run_editor set to True. ... ok

64 Testing GitClient.create_commit with all_files set to False. ... ok

65 Testing GitClient.create_commit with run_editor set to False. ... ok

66 Testing GitClient.delete_branch with merged_only set to True. ... ok