Fix various things for python 3 compatibility
Review Request #9652 — Created Feb. 16, 2018 and discarded
Fix various things for python 3 compatibility
Python 2.7 tests all ran fine.
Python 3.6
Ran 211 tests in 48.853s
FAILED (SKIP=30, errors=27) - Will update to fix some of these.
Description | From | Last Updated |
---|---|---|
We need to keep Python 2.7 compatibility. Can you verify there's no bug on Python 2.7 (including early 2.7.x releases)? |
|
|
This seems unrelated to the rest of this change, and I'm not sure -pp is even valid? |
|
|
This is unrelated to this change. |
|
|
Our modern formatting would be more like: question = ( "Update Review Request ....?" % (review_request.id, get_draft_or_current_value(...)) ) |
|
|
Is this Python 2.7-compatible? |
|
|
Same question. |
|
|
Please revert these. We want to keep those errors. |
|
|
I haven't seen any problems connecting to HTTPS, on Python 3 or otherwise. Is this with self-signed certificates? |
|
|
Please revert the change in this line (we prefer trailing commas everywhere) |
|
Description: |
|
||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Depends On: |
-
-
rbtools/commands/__init__.py (Diff revision 1) We need to keep Python 2.7 compatibility. Can you verify there's no bug on Python 2.7 (including early 2.7.x releases)?
-
rbtools/commands/api_get.py (Diff revision 1) This seems unrelated to the rest of this change, and I'm not sure
-pp
is even valid? -
-
rbtools/commands/post.py (Diff revision 1) Our modern formatting would be more like:
question = ( "Update Review Request ....?" % (review_request.id, get_draft_or_current_value(...)) )
-
-
-
Description: |
|
|||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||||||||||||||||||||
Depends On: |
||||||||||||||||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+11 -10) |
Checks run (2 succeeded)
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+11 -11) |
Checks run (2 succeeded)
-
-
README.md (Diff revision 3) I haven't seen any problems connecting to HTTPS, on Python 3 or otherwise. Is this with self-signed certificates?
-
rbtools/commands/post.py (Diff revision 3) Please revert the change in this line (we prefer trailing commas everywhere)
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+10 -10) |