Will do.

This is good from Python 2.6 on.

Changed in version 2.6: On Unix it defaults to using /dev/tty before falling back to sys.stdin and sys.stderr.

https://docs.python.org/2/library/getpass.html

Did you actually test redirecting stdout to a file and verifying that you could still see the Username/Password prompts?

These two unrelated changes user just making things consistent with other commands.
Yes, it doesn't seem to have any problems with two character short codes.  I think that was an issue in 2.6 and lower though if I remember correctly.

I think it's a worthwhile change. Might just be better as its own change, so it can be reviewed on its own merits. We generally try to keep porting changes focused on the porting without any additional changes.

Making into it's own commit.

This fixes a bug that prevented displaying the help for login.

Will fix when I go through the 30 test failures.

You mean is input compatible with unicode strings? Yes.
% python2.7     
Python 2.7.12 (v2.7.12:d33e0cf91556, Jun 26 2016, 12:10:39)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import six
>>> print(six.moves.input(u'Ho how [asdf]'))
Ho how [asdf]Yup
Yup
>>> print(getpass.getpass(u'hi asdfa [asdf]'))
hi asdfa [asdf]
Yup
>>>

Unicode string types aren't the issue. Python 2.x's input doesn't work fully with Unicode characters. It expects the text to be ASCII-compatible. See this example:

>>> from six.moves import input
>>> input(u'\U0001f355')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-1: ordinal not in range(128)


The encode is needed instead.

>>> from six.moves import input
>>> input(u'\U0001f355'.encode('utf-8'))

Okay, but are you planning on locallizing rbtools?

We are. New code is utilizing gettext for strings shown to users. We're updating older code as we go.

Sorry, let me clarify. RBTools doesn't have localizations yet, but other modules we're building are. RBTools will be getting gettext support.

Also worth noting that, even without localization, this function gets passed strings coming from user data (like review request summaries) that need to be in the proper encoding for input(). RBTools is also used as a Python API for interfacing with Review Board and for building custom commands by companies around the world, many of which don't use English in their text.

David already made a change here. It's no longer in my diff.

Yes
% python2.7     
Python 2.7.12 (v2.7.12:d33e0cf91556, Jun 26 2016, 12:10:39)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import six
>>> print(six.moves.input(u'Ho how [asdf]'))
Ho how [asdf]Yup
Yup
>>> print(getpass.getpass(u'hi asdfa [asdf]'))
hi asdfa [asdf]
Yup
>>>

Same issue here.

This should be fine for localization, but arbitrary user input would need more careful handling.
Python 2.7.12 (v2.7.12:d33e0cf91556, Jun 26 2016, 12:10:39)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from six.moves import input
>>> tmp = open('unicode_test.txt').read().strip()
>>> input(tmp)
??????sadf
'sadf'

>>> from getpass import getpass
>>> getpass(tmp)
?????
'asdf'

Reverted

From the python 3.6 readme:
macOS users: If you are using the Python 3.6 from the python.org binary installer linked on this page, please carefully read the 
Important Information displayed during installation; this information is also available after installation by clicking on     
/Applications/Python 3.6/ReadMe.rtf. There is important information there about changes in the 3.6.0 installer-supplied Python, 
particularly with regard to SSL certificate validation.

https://bugs.python.org/issue29065

This is also a comment that doesn't add anything to the discussion.