Summary

Make quote use consistent across repo

Review Request #9651 — Created Feb. 16, 2018 and submitted April 19, 2018, 2:06 p.m.

Information

Owner

solarmist

Repository

RBTools

Branch

master

Bugs

Depends On

~~9649~~

Blocks

9652

Commit

281413c...

Reviewers

Groups

rbtools

People

Description

Make quote use consistent across repo.

Testing Done

Unit tests ran fine in python 2.7

Issues

Description	From	Last Updated
The previous version was correct here. These are quotes in documentation, and we want double quotes there. Can you revert …	chipx86	Feb. 17, 2018, 2:57 p.m.
Same.	chipx86	Feb. 17, 2018, 2:57 p.m.
This can be reverted.	chipx86	Feb. 17, 2018, 2:57 p.m.
This can be reverted.	chipx86	Feb. 17, 2018, 4:21 p.m.

flake8 passed.

JSHint passed.

Description:

~		Make quote use consistent across repo
	~	Make quote use consistent across repo.
	+
	+	https://reviews.reviewboard.org/r/9648/
	+	https://reviews.reviewboard.org/r/9649/
	+	https://reviews.reviewboard.org/r/9650/
	+	https://reviews.reviewboard.org/r/9651/
	+	https://reviews.reviewboard.org/r/9652/
	+	https://reviews.reviewboard.org/r/9653/
	+	https://reviews.reviewboard.org/r/9654/
	+	https://reviews.reviewboard.org/r/9655/

Depends On:

+	~~9648 - Fix exception handling, and update imports~~
+	~~9649 - Make six use consistant.~~
+	~~9650 - Fix log messages~~
+	~~9651 - Make quote use consistent across repo~~
+	~~9652 - Fix various things for python 3 compatibility~~
+	~~9653 - Refactor encode_multipart_formdata and tests to be easier to read and maintain~~
+	~~9654 - Fix unit tests to not pollute the test directories of other tests.~~
+	~~9655 - Fix various PEP 8, style and PyFlakes issues~~

rbtools/clients/__init__.py (Diff revision 1)

Show all issues

The previous version was correct here. These are quotes in documentation, and we want double quotes there. Can you revert all the quote changes occurring in docstrings and comments?

rbtools/clients/__init__.py (Diff revision 1)
Show all issues
```
Same.
```
rbtools/clients/__init__.py (Diff revision 1)
Show all issues
```
This can be reverted.
```
rbtools/clients/tests/test_bzr.py (Diff revision 1)
Show all issues
```
This can be reverted.
```

Description:

		Make quote use consistent across repo.
-
-		https://reviews.reviewboard.org/r/9648/
-		https://reviews.reviewboard.org/r/9649/
-		https://reviews.reviewboard.org/r/9650/
-		https://reviews.reviewboard.org/r/9651/
-		https://reviews.reviewboard.org/r/9652/
-		https://reviews.reviewboard.org/r/9653/
-		https://reviews.reviewboard.org/r/9654/
-		https://reviews.reviewboard.org/r/9655/

Testing Done:

~		Not sure what to put here since these intermediate commits don't pass tests or flake8.
	~	N/A

Depends On:

-	~~9651 - Make quote use consistent across repo~~

Commit:

-	2ba7ae1831091e5591e8d029f3bf8f88341fd719
+	54a1e8f6b006436b269109e1cd6847039fee99dc

Diff:

Revision 2 (+189 -188)

Show changes

	rbtools/clients/clearcase.py
	rbtools/clients/cvs.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/plastic.py
	rbtools/clients/svn.py
	rbtools/clients/tfs.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commit:

-	54a1e8f6b006436b269109e1cd6847039fee99dc
+	3e08dfe998f58c6f2cf5d8513861349d3097206b

Diff:

Revision 3 (+188 -188)

Show changes

	rbtools/clients/clearcase.py
	rbtools/clients/cvs.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/plastic.py
	rbtools/clients/svn.py
	rbtools/clients/tfs.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Testing Done:

~		N/A
	~	Unit tests ran fine in python 2.7

Depends On:

-	~~9648 - Fix exception handling, and update imports~~
-	~~9649 - Make six use consistant.~~
-	~~9652 - Fix various things for python 3 compatibility~~
-	~~9653 - Refactor encode_multipart_formdata and tests to be easier to read and maintain~~
-	~~9654 - Fix unit tests to not pollute the test directories of other tests.~~
-	~~9655 - Fix various PEP 8, style and PyFlakes issues~~

Commit:

-	3e08dfe998f58c6f2cf5d8513861349d3097206b
+	f31bb57486a321d165dd58fc72bccfd5fd308793

Diff:

Revision 4 (+135 -135)

Show changes

	rbtools/api/tests.py
	rbtools/clients/clearcase.py
	rbtools/clients/cvs.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/plastic.py
	rbtools/clients/svn.py
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Depends On:

-	~~9650 - Fix log messages~~
+	~~9649 - Make six use consistant.~~

Commit:

-	f31bb57486a321d165dd58fc72bccfd5fd308793
+	281413c64e073196b3ed349a5f988fa5f5857a7d

Diff:

Revision 5 (+153 -153)

Show changes

	contrib/internal/release.py
	rbtools/api/tests.py
	rbtools/clients/clearcase.py
	rbtools/clients/cvs.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/plastic.py
	7 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (4c78d5d)