Make six use consistant.
Review Request #9649 — Created Feb. 16, 2018 and submitted
Information | |
---|---|
solarmist | |
RBTools | |
master | |
|
|
9651, 9650 | |
8a990da... | |
Reviewers | |
rbtools | |
Make six use consistant.
Import the function directly if it is a six.moves function otherwise
leave it specified as a six function that needs to be replaced in
the future.
All tests passed in python 2.7
Description | From | Last Updated |
---|---|---|
We don't want to only import six. That makes updating code down the road much harder, increases the chances of … |
|
|
Please undo this change. The previous way was better. |
|
|
Please undo these changes. |
|
|
F821 undefined name 'six' |
![]() |
|
This is changing StringIO from using the C implementation to using the Python implementation (on Python 2). Please change this … |
|
Description: |
|
|||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Depends On: |
-
-
We don't want to only import
six
. That makes updating code down the road much harder, increases the chances of errors (we can't check for unimported references anymore), and just generally makes things more verbose. I don't really understand the reason for this change, but it's not the direction we want to take the codebase.This change is also trying to do too much. Some parts are changing how
six
imports work, others are moving things likeunicode()
and.iteritems()
tosix
equivalents. That should be its own change.
Summary: |
|
||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||||||||||||||
Testing Done: |
|
||||||||||||||||||||||||||||||||||||||||||
Depends On: |
|||||||||||||||||||||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+8 -6) |
Checks run (2 succeeded)
-
-
rbtools/clients/tests/test_svn.py (Diff revision 2) Please undo this change. The previous way was better.
-
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+6 -4) |
Checks run (1 failed, 1 succeeded)
flake8
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+4 -1) |
Checks run (2 succeeded)
-
-
rbtools/clients/tests/test_svn.py (Diff revision 4) This is changing StringIO from using the C implementation to using the Python implementation (on Python 2). Please change this back.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+4 -2) |
Checks run (2 succeeded)
Change Summary:
Forgot to run the unit tests.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+4 -2) |