Fix exception handling, and update imports
Review Request #9648 — Created Feb. 16, 2018 and submitted
Remove fix exception handling, and update imports
Ran Unit tests in Python 2.7 and all passed.
Description | From | Last Updated |
---|---|---|
This change breaks Python 2.7. We don't want to remove the (object). |
|
|
Import groups must be in the following order, with a blank line separating each: from __future__ Python Standard Library imports … |
|
|
This line should be removed |
|
|
Not everything in setup() can deal with having unicode strings. I'm not sure it's actually a problem in this particular … |
|
|
Undo this change? |
|
Description: |
|
||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Depends On: |
-
-
-
rbtools/api/resource.py (Diff revision 1) Import groups must be in the following order, with a blank line separating each:
from __future__
- Python Standard Library imports
- Third-party module imports
- Project imports
Within each, we want
import ...
statements followed byfrom ...
statements, without a blank line in-between. All must also be in alphabetical order.We also don't need
absolute_import
. Please revert those.
Summary: |
|
|||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||
Testing Done: |
|
|||||||||||||||||||||||||||||||||
Depends On: |
|
|||||||||||||||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+51 -22) |
Checks run (2 succeeded)
Testing Done: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Depends On: |
|||||||||||||
Commit: |
|
||||||||||||
Diff: |
Revision 3 (+33 -23) |
Checks run (2 succeeded)
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+33 -24) |
Checks run (2 succeeded)
-
-
setup.py (Diff revision 4) Not everything in
setup()
can deal with having unicode strings. I'm not sure it's actually a problem in this particular case, but I'd feel more comfortable just leaving this file alone. -
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+35 -26) |