Summary:

JSON wrapper which inputs to a dictionary and outputs a JSON object

Review Request #11521 — Created March 20, 2021 and submitted Oct. 25, 2021, 9:39 p.m.

Information
Owner:	ryankang
Repository:	RBTools
Branch:	master
Bugs:
Depends On:	~~11401~~
Blocks:	11572, 11541, 11588, 11560, 11589, 11590, 11591, 11573
Reviewers
Groups:	rbtools, students
People:

Description

JSON wrapper class which inputs to a dictionary and outputs a JSON object. Class

is defined in rbtools/commands/__init__.py Command class. New command --json

added to global options, which can be added to any command. When --json is active

run_from_argv will print the json object using Python's json library.
For a full list of proposed JSON objects for each command see:

https://www.notion.so/reviewboard/a8cd6ee32806415fb7bba484d630863e?v=25fb1c9182064421ab17e55606da765b

Testing Done

Passed all tests in Command. Added new tests in test_main.py for initializing
wrapper, adding key value pairs to dictionary, getting correct JSON string from
dictionary, and printing to output stream with correct JSON string.

Commits

Summary
	merged in Output Wrapper Object from r#11401
	added new method to print JSON to stream object and tests to ensure it works properly
	added new global command --json
	added conditional at the end of command cycle to print JSON is enabled
	added method to append to classes and tests to ensure items are appended correctly
	added new method to add errors to existing errors key or create a new one
	Fixed issues with extra white spaces in files from Review Bot
	Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
	Fixed minor formatting issues in test_main.py
	Updated JSONOutput docstrings to format with guidelines
	Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
	Checking if there are any errors in json to decide status
	Fixed trailing white space in test_main.test_hson_wrapper_append
	Fixed blank lines with spaces in __init__ Command.run_from_argv
	Added any CommandError caught to errors key
	Fixed bug where test_main.py was imported JSONWrapper instead of JSONOutput
	Disabling standard output and error when --json option is enabled
	Casting errors as string before adding to JSON object

Screenshots

Issues

Description	From	Last Updated
W293 blank line contains whitespace	reviewbot	March 27, 2021, 1:43 p.m.
W293 blank line contains whitespace	reviewbot	March 27, 2021, 1:51 p.m.
E303 too many blank lines (2)	reviewbot	March 27, 2021, 2:30 p.m.
W293 blank line contains whitespace	reviewbot	March 27, 2021, 1:51 p.m.
W293 blank line contains whitespace	reviewbot	March 27, 2021, 1:52 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 27, 2021, 2:07 p.m.
This class and all the methods inside need docstrings. Perhaps instead of "Wrapper" (it's not really wrapping anything), just call …	david	March 27, 2021, 3:20 p.m.
W293 blank line contains whitespace	reviewbot	March 27, 2021, 2:07 p.m.
W293 blank line contains whitespace	reviewbot	March 27, 2021, 2:07 p.m.
Let's make the help be something like "Output results as JSON data instead of text"	david	March 27, 2021, 3:57 p.m.
W293 blank line contains whitespace	reviewbot	March 27, 2021, 2:07 p.m.
This comment isn't necessary--the code is pretty self explanatory.	david	March 27, 2021, 3:30 p.m.
Looks like this still needs to be done. But initialize_scm_tool isn't the right place to do it.	david	March 24, 2021, 3:38 p.m.
Let's do import kgb and inherit from kgb.SpyAgency	david	March 27, 2021, 3:32 p.m.
These two lines can be combined: from rbtools.commands import JSONWrapper, main as rbt_main	david	March 27, 2021, 3:32 p.m.
It might be worth defining a setUp method that sets self.json = JSONWrapper(sys.stdout). That way you don't have to do …	david	March 27, 2021, 3:54 p.m.
E303 too many blank lines (2)	reviewbot	March 27, 2021, 2:07 p.m.
W293 blank line contains whitespace	reviewbot	March 27, 2021, 2:08 p.m.
W293 blank line contains whitespace	reviewbot	March 27, 2021, 2:08 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 27, 2021, 2:08 p.m.
W293 blank line contains whitespace	reviewbot	March 27, 2021, 2:08 p.m.
W291 trailing whitespace	reviewbot	March 27, 2021, 2:08 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 27, 2021, 6:08 p.m.
E501 line too long (83 > 79 characters)	reviewbot	March 27, 2021, 6:09 p.m.
W291 trailing whitespace	reviewbot	April 4, 2021, 11:47 a.m.
W291 trailing whitespace	reviewbot	April 4, 2021, 12:41 p.m.
W293 blank line contains whitespace	reviewbot	April 4, 2021, 12:41 p.m.
W291 trailing whitespace	reviewbot	April 4, 2021, 12:41 p.m.
W293 blank line contains whitespace	reviewbot	April 4, 2021, 12:41 p.m.
I think it might be better to do self.json.add_error(str(e)) because most of the errors raised (ex. CommandError, ApiError) are not …	amohapatra	April 11, 2021, 11:08 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/__init__.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 1)
Show all issues
```
E303 too many blank lines (2)
```
rbtools/commands/tests/test_main.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 1)
Show all issues
```
E501 line too long (80 > 79 characters)
```

Commits:

	Summary
-	added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
-	added new method to print JSON to stream object and tests to ensure it works properly
-	added new global command --json
-	added conditional at the end of command cycle to print JSON is enabled
+	added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
+	added new method to print JSON to stream object and tests to ensure it works properly
+	added new global command --json
+	added conditional at the end of command cycle to print JSON is enabled
+	added method to append to classes and tests to ensure items are appended correctly
+	added new method to add errors to existing errors key or create a new one

Diff:

Revision 2 (+270 -12)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/__init__.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/__init__.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
E303 too many blank lines (2)
```
rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```

Fix it!

rbtools/commands/__init__.py (Diff revision 2)

Show all issues

This class and all the methods inside need docstrings.
Perhaps instead of "Wrapper" (it's not really wrapping anything), just call it something like "JSONOutput"?

rbtools/commands/__init__.py (Diff revision 2)

Show all issues

Let's make the help be something like "Output results as JSON data instead of text"

rbtools/commands/__init__.py (Diff revision 2)

Show all issues

This comment isn't necessary--the code is pretty self explanatory.

rbtools/commands/__init__.py (Diff revision 2)

Show all issues

Looks like this still needs to be done. But initialize_scm_tool isn't the right place to do it.

ryankang March 27, 2021, 3:56 p.m.

Would you recommend putting it at the start of run_from_argv instead?

rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
Let's do import kgb and inherit from kgb.SpyAgency
```

rbtools/commands/tests/test_main.py (Diff revision 2)

Show all issues

These two lines can be combined:

from rbtools.commands import JSONWrapper, main as rbt_main

rbtools/commands/tests/test_main.py (Diff revision 2)

Show all issues

It might be worth defining a setUp method that sets self.json = JSONWrapper(sys.stdout). That way you don't have to do it individually in each test.

Commits:

	Summary
-	added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
-	added new method to print JSON to stream object and tests to ensure it works properly
-	added new global command --json
-	added conditional at the end of command cycle to print JSON is enabled
-	added method to append to classes and tests to ensure items are appended correctly
-	added new method to add errors to existing errors key or create a new one
+	added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
+	added new method to print JSON to stream object and tests to ensure it works properly
+	added new global command --json
+	added conditional at the end of command cycle to print JSON is enabled
+	added method to append to classes and tests to ensure items are appended correctly
+	added new method to add errors to existing errors key or create a new one
+	Fixed issues with extra white spaces in files from Review Bot

Diff:

Revision 3 (+279 -21)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary
-		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
-		added new method to print JSON to stream object and tests to ensure it works properly
-		added new global command --json
-		added conditional at the end of command cycle to print JSON is enabled
-		added method to append to classes and tests to ensure items are appended correctly
-		added new method to add errors to existing errors key or create a new one
-		Fixed issues with extra white spaces in files from Review Bot
+		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
+		added new method to print JSON to stream object and tests to ensure it works properly
+		added new global command --json
+		added conditional at the end of command cycle to print JSON is enabled
+		added method to append to classes and tests to ensure items are appended correctly
+		added new method to add errors to existing errors key or create a new one
+		Fixed issues with extra white spaces in files from Review Bot
+		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput

Diff:

Revision 4 (+363 -65)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/tests/test_main.py (Diff revision 4)
Show all issues
```
E127 continuation line over-indented for visual indent
```
rbtools/commands/tests/test_main.py (Diff revision 4)
Show all issues
```
E501 line too long (83 > 79 characters)
```

Commits:

	Summary
-		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
-		added new method to print JSON to stream object and tests to ensure it works properly
-		added new global command --json
-		added conditional at the end of command cycle to print JSON is enabled
-		added method to append to classes and tests to ensure items are appended correctly
-		added new method to add errors to existing errors key or create a new one
-		Fixed issues with extra white spaces in files from Review Bot
-		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
+		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
+		added new method to print JSON to stream object and tests to ensure it works properly
+		added new global command --json
+		added conditional at the end of command cycle to print JSON is enabled
+		added method to append to classes and tests to ensure items are appended correctly
+		added new method to add errors to existing errors key or create a new one
+		Fixed issues with extra white spaces in files from Review Bot
+		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
+		Fixed minor formatting issues in test_main.py

Diff:

Revision 5 (+370 -68)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary
-		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
-		added new method to print JSON to stream object and tests to ensure it works properly
-		added new global command --json
-		added conditional at the end of command cycle to print JSON is enabled
-		added method to append to classes and tests to ensure items are appended correctly
-		added new method to add errors to existing errors key or create a new one
-		Fixed issues with extra white spaces in files from Review Bot
-		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
-		Fixed minor formatting issues in test_main.py
+		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
+		added new method to print JSON to stream object and tests to ensure it works properly
+		added new global command --json
+		added conditional at the end of command cycle to print JSON is enabled
+		added method to append to classes and tests to ensure items are appended correctly
+		added new method to add errors to existing errors key or create a new one
+		Fixed issues with extra white spaces in files from Review Bot
+		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
+		Fixed minor formatting issues in test_main.py
+		Updated JSONOutput docstrings to format with guidelines

Diff:

Revision 6 (+441 -79)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 6)
Show all issues
```
W291 trailing whitespace
```

Commits:

	Summary
-		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
-		added new method to print JSON to stream object and tests to ensure it works properly
-		added new global command --json
-		added conditional at the end of command cycle to print JSON is enabled
-		added method to append to classes and tests to ensure items are appended correctly
-		added new method to add errors to existing errors key or create a new one
-		Fixed issues with extra white spaces in files from Review Bot
-		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
-		Fixed minor formatting issues in test_main.py
-		Updated JSONOutput docstrings to format with guidelines
+		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
+		added new method to print JSON to stream object and tests to ensure it works properly
+		added new global command --json
+		added conditional at the end of command cycle to print JSON is enabled
+		added method to append to classes and tests to ensure items are appended correctly
+		added new method to add errors to existing errors key or create a new one
+		Fixed issues with extra white spaces in files from Review Bot
+		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
+		Fixed minor formatting issues in test_main.py
+		Updated JSONOutput docstrings to format with guidelines
+		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines

Diff:

Revision 7 (+456 -98)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/tests/test_main.py (Diff revision 7)
Show all issues
```
W291 trailing whitespace
```

Commits:

	Summary
-		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
-		added new method to print JSON to stream object and tests to ensure it works properly
-		added new global command --json
-		added conditional at the end of command cycle to print JSON is enabled
-		added method to append to classes and tests to ensure items are appended correctly
-		added new method to add errors to existing errors key or create a new one
-		Fixed issues with extra white spaces in files from Review Bot
-		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
-		Fixed minor formatting issues in test_main.py
-		Updated JSONOutput docstrings to format with guidelines
-		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
+		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
+		added new method to print JSON to stream object and tests to ensure it works properly
+		added new global command --json
+		added conditional at the end of command cycle to print JSON is enabled
+		added method to append to classes and tests to ensure items are appended correctly
+		added new method to add errors to existing errors key or create a new one
+		Fixed issues with extra white spaces in files from Review Bot
+		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
+		Fixed minor formatting issues in test_main.py
+		Updated JSONOutput docstrings to format with guidelines
+		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
+		Checking if there are any errors in json to decide status

Diff:

Revision 8 (+466 -98)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 8)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 8)
Show all issues
```
W291 trailing whitespace
```

Commits:

	Summary
-		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
-		added new method to print JSON to stream object and tests to ensure it works properly
-		added new global command --json
-		added conditional at the end of command cycle to print JSON is enabled
-		added method to append to classes and tests to ensure items are appended correctly
-		added new method to add errors to existing errors key or create a new one
-		Fixed issues with extra white spaces in files from Review Bot
-		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
-		Fixed minor formatting issues in test_main.py
-		Updated JSONOutput docstrings to format with guidelines
-		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
-		Checking if there are any errors in json to decide status
+		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
+		added new method to print JSON to stream object and tests to ensure it works properly
+		added new global command --json
+		added conditional at the end of command cycle to print JSON is enabled
+		added method to append to classes and tests to ensure items are appended correctly
+		added new method to add errors to existing errors key or create a new one
+		Fixed issues with extra white spaces in files from Review Bot
+		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
+		Fixed minor formatting issues in test_main.py
+		Updated JSONOutput docstrings to format with guidelines
+		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
+		Checking if there are any errors in json to decide status
+		Fixed trailing white space in test_main.test_hson_wrapper_append

Diff:

Revision 9 (+467 -99)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 9)
Show all issues
```
W293 blank line contains whitespace
```

Commits:

	Summary
-		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
-		added new method to print JSON to stream object and tests to ensure it works properly
-		added new global command --json
-		added conditional at the end of command cycle to print JSON is enabled
-		added method to append to classes and tests to ensure items are appended correctly
-		added new method to add errors to existing errors key or create a new one
-		Fixed issues with extra white spaces in files from Review Bot
-		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
-		Fixed minor formatting issues in test_main.py
-		Updated JSONOutput docstrings to format with guidelines
-		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
-		Checking if there are any errors in json to decide status
-		Fixed trailing white space in test_main.test_hson_wrapper_append
+		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
+		added new method to print JSON to stream object and tests to ensure it works properly
+		added new global command --json
+		added conditional at the end of command cycle to print JSON is enabled
+		added method to append to classes and tests to ensure items are appended correctly
+		added new method to add errors to existing errors key or create a new one
+		Fixed issues with extra white spaces in files from Review Bot
+		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
+		Fixed minor formatting issues in test_main.py
+		Updated JSONOutput docstrings to format with guidelines
+		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
+		Checking if there are any errors in json to decide status
+		Fixed trailing white space in test_main.test_hson_wrapper_append
+		Fixed blank lines with spaces in __init__ Command.run_from_argv

Diff:

Revision 10 (+468 -100)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary
-		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
-		added new method to print JSON to stream object and tests to ensure it works properly
-		added new global command --json
-		added conditional at the end of command cycle to print JSON is enabled
-		added method to append to classes and tests to ensure items are appended correctly
-		added new method to add errors to existing errors key or create a new one
-		Fixed issues with extra white spaces in files from Review Bot
-		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
-		Fixed minor formatting issues in test_main.py
-		Updated JSONOutput docstrings to format with guidelines
-		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
-		Checking if there are any errors in json to decide status
-		Fixed trailing white space in test_main.test_hson_wrapper_append
-		Fixed blank lines with spaces in __init__ Command.run_from_argv
+		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
+		added new method to print JSON to stream object and tests to ensure it works properly
+		added new global command --json
+		added conditional at the end of command cycle to print JSON is enabled
+		added method to append to classes and tests to ensure items are appended correctly
+		added new method to add errors to existing errors key or create a new one
+		Fixed issues with extra white spaces in files from Review Bot
+		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
+		Fixed minor formatting issues in test_main.py
+		Updated JSONOutput docstrings to format with guidelines
+		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
+		Checking if there are any errors in json to decide status
+		Fixed trailing white space in test_main.test_hson_wrapper_append
+		Fixed blank lines with spaces in __init__ Command.run_from_argv
+		Added any CommandError caught to errors key

Diff:

Revision 11 (+470 -100)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/commands/__init__.py (Diff revision 11)

Show all issues

I think it might be better to do self.json.add_error(str(e)) because most of the errors raised (ex. CommandError, ApiError) are not JSON serializable.

Commits:

	Summary
-		added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py
-		added new method to print JSON to stream object and tests to ensure it works properly
-		added new global command --json
-		added conditional at the end of command cycle to print JSON is enabled
-		added method to append to classes and tests to ensure items are appended correctly
-		added new method to add errors to existing errors key or create a new one
-		Fixed issues with extra white spaces in files from Review Bot
-		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
-		Fixed minor formatting issues in test_main.py
-		Updated JSONOutput docstrings to format with guidelines
-		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
-		Checking if there are any errors in json to decide status
-		Fixed trailing white space in test_main.test_hson_wrapper_append
-		Fixed blank lines with spaces in __init__ Command.run_from_argv
-		Added any CommandError caught to errors key
+		merged in Output Wrapper Object from r#11401
+		added new method to print JSON to stream object and tests to ensure it works properly
+		added new global command --json
+		added conditional at the end of command cycle to print JSON is enabled
+		added method to append to classes and tests to ensure items are appended correctly
+		added new method to add errors to existing errors key or create a new one
+		Fixed issues with extra white spaces in files from Review Bot
+		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
+		Fixed minor formatting issues in test_main.py
+		Updated JSONOutput docstrings to format with guidelines
+		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
+		Checking if there are any errors in json to decide status
+		Fixed trailing white space in test_main.test_hson_wrapper_append
+		Fixed blank lines with spaces in __init__ Command.run_from_argv
+		Added any CommandError caught to errors key
+		Fixed bug where test_main.py was imported JSONWrapper instead of JSONOutput
+		Disabling standard output and error when --json option is enabled

Diff:

Revision 12 (+471 -103)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	[WIP] JSON wrapper which inputs to a dictionary and outputs a JSON object
+	JSON wrapper which inputs to a dictionary and outputs a JSON object

Groups:

+	students

Depends On:

+	~~11401 - OutputWrapper class to Commands which outputs to stream object of choice~~

Commits:

	Summary
-		merged in Output Wrapper Object from r#11401
-		added new method to print JSON to stream object and tests to ensure it works properly
-		added new global command --json
-		added conditional at the end of command cycle to print JSON is enabled
-		added method to append to classes and tests to ensure items are appended correctly
-		added new method to add errors to existing errors key or create a new one
-		Fixed issues with extra white spaces in files from Review Bot
-		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
-		Fixed minor formatting issues in test_main.py
-		Updated JSONOutput docstrings to format with guidelines
-		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
-		Checking if there are any errors in json to decide status
-		Fixed trailing white space in test_main.test_hson_wrapper_append
-		Fixed blank lines with spaces in __init__ Command.run_from_argv
-		Added any CommandError caught to errors key
-		Fixed bug where test_main.py was imported JSONWrapper instead of JSONOutput
-		Disabling standard output and error when --json option is enabled
+		merged in Output Wrapper Object from r#11401
+		added new method to print JSON to stream object and tests to ensure it works properly
+		added new global command --json
+		added conditional at the end of command cycle to print JSON is enabled
+		added method to append to classes and tests to ensure items are appended correctly
+		added new method to add errors to existing errors key or create a new one
+		Fixed issues with extra white spaces in files from Review Bot
+		Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput
+		Fixed minor formatting issues in test_main.py
+		Updated JSONOutput docstrings to format with guidelines
+		Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines
+		Checking if there are any errors in json to decide status
+		Fixed trailing white space in test_main.test_hson_wrapper_append
+		Fixed blank lines with spaces in __init__ Command.run_from_argv
+		Added any CommandError caught to errors key
+		Fixed bug where test_main.py was imported JSONWrapper instead of JSONOutput
+		Disabling standard output and error when --json option is enabled
+		Casting errors as string before adding to JSON object

Diff:

Revision 13 (+472 -104)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

		JSON wrapper class which inputs to a dictionary and outputs a JSON object. Class
		is defined in `rbtools/commands/__init__.py` Command class. New command `--json`
		added to global options, which can be added to any command. When `--json` is active
		`run_from_argv` will print the json object using Python's json library.
	+
	+	For a full list of proposed JSON objects for each command see:
	+	https://www.notion.so/reviewboard/a8cd6ee32806415fb7bba484d630863e?v=25fb1c9182064421ab17e55606da765b

JSON wrapper which inputs to a dictionary and outputs a JSON object

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (2 succeeded)

Summary:

Groups:

Depends On:

Commits:

Diff:

Checks run (2 succeeded)

Description:

Status: Closed (submitted)