Summary

JSON Output for RBTools Patch Command

Review Request #11588 — Created April 11, 2021 and submitted Oct. 25, 2021, 9:38 p.m.

Information

Owner

ryankang

Repository

RBTools

Branch

master

Bugs

Depends On

~~11521~~

Reviewers

Groups

rbtools, students

People

Description

Depends on JSON output object from r#11521.

JSON object includes:

patch_output: result of result.patch_output.strip()
conflicting_files: list of filenames that are conflicting with patch
diff_body: contents of the patches

Testing Done

Ran unit tests in Commands and passed all tests

Commits

Summary	ID
Added standard output to JSON output	fb29f108bae7614f448d27b4210b50170dc5d913
Added more errors to JSON object when conflicts are found	44e017d84f74bc82f8711ca562150c2b8b961d05
Fixed space error in blank line	17701eeaf6b511019b1aee697f736f0a80c0f5f9

Issues

Description	From	Last Updated
W293 blank line contains whitespace	reviewbot	April 11, 2021, 2:58 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/patch.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Commits:

	Summary	ID
	Added standard output to JSON output	fb29f108bae7614f448d27b4210b50170dc5d913
	Added more errors to JSON object when conflicts are found	44e017d84f74bc82f8711ca562150c2b8b961d05
	Added standard output to JSON output	fb29f108bae7614f448d27b4210b50170dc5d913
	Added more errors to JSON object when conflicts are found	44e017d84f74bc82f8711ca562150c2b8b961d05
	Fixed space error in blank line	17701eeaf6b511019b1aee697f736f0a80c0f5f9

Diff:

Revision 2 (+29 -1)

Show changes

rbtools/commands/patch.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to master (e0f124c)

rbtools/commands/patch.py (Diff revision 1)