- Download Diff

Summary:

OutputWrapper class to Commands which outputs to stream object of choice

Review Request #11401 — Created Jan. 23, 2021 and updated March 5, 2021, 7:26 p.m.

Information
Owner:	ryankang
Repository:	RBTools
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	rbtools, students
People:

Description

RBTools commands were previously using print and sys.stderr 

to output messages. This change abstracting outputting by using a 

wrapper around a stream output object. This makes it easier to customize 

output streams and suppress output. 4 wrappers (2 for standard output 

unicode and byte, 2 for standard error unicode and byte) are initiated 

in the Command class that is accessible to all child classes.

Testing Done

Ran all tests in ./tests/runtests.py rbtools.commands and passed.

Added two new tests for __init__.py. One that tests if output stream
object is set correctly for OutputWrapper and another test that makes
sure OutputWrapper passes the correct message to the output stream object

Commits

Summary
added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
replaced all of the prints with output wrapper and initiated wrapper in Command init
Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()
Fixed white space error at the end of rbtools/commands/__init__.py
changed print statements in __init__.py to use output wrapper
fixed Review Bot issues where lines where over 80 characters in __init__.py
moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests
fixed indentation and misspelled words issues in test_main.py:OutputWrapper
moved OutputWrapper tests to test_main.py and imported KGB

Screenshots

Issues

Description	From	Last Updated
All the changes suggested have to do with consistency with self.stdout.new_line(). Other than that, everything else looks good to me!	amohapatra	Feb. 13, 2021, 2:51 p.m.
Your summary should be much shorter, about 70 columns. Further detail (for example, what tests were added) should be in ...	david	March 2, 2021, 9 p.m.
E501 line too long (85 > 79 characters)	reviewbot	Jan. 24, 2021, 8:11 a.m.
E501 line too long (91 > 79 characters)	reviewbot	Jan. 24, 2021, 8:11 a.m.
W293 blank line contains whitespace	reviewbot	Jan. 24, 2021, 8:13 a.m.
E501 line too long (85 > 79 characters)	reviewbot	Jan. 24, 2021, 8:14 a.m.
E501 line too long (88 > 79 characters)	reviewbot	Jan. 24, 2021, 8:33 a.m.
E501 line too long (89 > 79 characters)	reviewbot	Jan. 24, 2021, 8:33 a.m.
E211 whitespace before '('	reviewbot	Jan. 24, 2021, 8:35 a.m.
E501 line too long (91 > 79 characters)	reviewbot	Jan. 24, 2021, 8:39 a.m.
E501 line too long (90 > 79 characters)	reviewbot	Jan. 24, 2021, 8:39 a.m.
E501 line too long (89 > 79 characters)	reviewbot	Jan. 24, 2021, 8:57 a.m.
E501 line too long (88 > 79 characters)	reviewbot	Jan. 24, 2021, 8:57 a.m.
E501 line too long (85 > 79 characters)	reviewbot	Jan. 24, 2021, 8:57 a.m.
E501 line too long (84 > 79 characters)	reviewbot	Jan. 24, 2021, 8:57 a.m.
E501 line too long (86 > 79 characters)	reviewbot	Feb. 6, 2021, 11:46 a.m.
E501 line too long (83 > 79 characters)	reviewbot	Feb. 6, 2021, 11:46 a.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 6, 2021, 11:46 a.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 6, 2021, 11:46 a.m.
E501 line too long (91 > 79 characters)	reviewbot	Feb. 6, 2021, 11:46 a.m.
E501 line too long (81 > 79 characters)	reviewbot	Feb. 6, 2021, 11:47 a.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 6, 2021, 11:47 a.m.
E501 line too long (83 > 79 characters)	reviewbot	Feb. 6, 2021, 11:47 a.m.
E501 line too long (88 > 79 characters)	reviewbot	Feb. 6, 2021, 11:47 a.m.
E501 line too long (89 > 79 characters)	reviewbot	Feb. 6, 2021, 11:48 a.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 6, 2021, 11:48 a.m.
W292 no newline at end of file	reviewbot	Feb. 6, 2021, 11:48 a.m.
W291 trailing whitespace	reviewbot	Feb. 6, 2021, 11:52 a.m.
E124 closing bracket does not match visual indentation	reviewbot	Feb. 6, 2021, 11:52 a.m.
E231 missing whitespace after ','	reviewbot	Feb. 6, 2021, 11:52 a.m.
E501 line too long (86 > 79 characters)	reviewbot	Feb. 6, 2021, 11:53 a.m.
W291 trailing whitespace	reviewbot	Feb. 6, 2021, 11:56 a.m.
For consistency with the other changes, should this maybe instead be self.stdout.new_line() ?	amohapatra	Feb. 13, 2021, 2:54 p.m.
Again for consistency, maybe this should be self.stdout.new_line() ?	amohapatra	Feb. 13, 2021, 2:54 p.m.
This should be self.stdout.new_line()?	amohapatra	Feb. 13, 2021, 2:53 p.m.
This should be self.stdout.new_line() ?	amohapatra	Feb. 13, 2021, 2:53 p.m.
This should also be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 2:53 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 2:53 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 2:53 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 2:53 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 2:52 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 2:52 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 2:52 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 2:52 p.m.
W292 no newline at end of file	reviewbot	Feb. 13, 2021, 2:59 p.m.
W391 blank line at end of file	reviewbot	Feb. 13, 2021, 3:06 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 13, 2021, 3:06 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Feb. 19, 2021, 11:32 a.m.
E501 line too long (89 > 79 characters)	reviewbot	Feb. 19, 2021, 11:32 a.m.
E501 line too long (83 > 79 characters)	reviewbot	Feb. 19, 2021, 11:32 a.m.
E501 line too long (89 > 79 characters)	reviewbot	Feb. 19, 2021, 11:32 a.m.
All test cases should be in files called test_X, not the __init__.py. In this case I think you could probably ...	david	March 2, 2021, 8:56 p.m.
A few changes in here: The file needs a module docstring The first thing after that docstring should be from ...	david	March 5, 2021, 7:26 p.m.
Dedent this three spaces.	david	March 2, 2021, 8:58 p.m.
Typo: strea -> stream	david	March 2, 2021, 9 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 1)
Show all issues
```
E501 line too long (85 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 1)
Show all issues
```
E501 line too long (91 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/alias.py (Diff revision 1)
Show all issues
```
E501 line too long (85 > 79 characters)
```
rbtools/commands/alias.py (Diff revision 1)
Show all issues
```
E501 line too long (88 > 79 characters)
```
rbtools/commands/alias.py (Diff revision 1)
Show all issues
```
E501 line too long (89 > 79 characters)
```
rbtools/commands/info.py (Diff revision 1)
Show all issues
```
E211 whitespace before '('
```
rbtools/commands/land.py (Diff revision 1)
Show all issues
```
E501 line too long (91 > 79 characters)
```
rbtools/commands/land.py (Diff revision 1)
Show all issues
```
E501 line too long (90 > 79 characters)
```
rbtools/commands/patch.py (Diff revision 1)
Show all issues
```
E501 line too long (89 > 79 characters)
```
rbtools/commands/patch.py (Diff revision 1)
Show all issues
```
E501 line too long (88 > 79 characters)
```
rbtools/commands/patch.py (Diff revision 1)
Show all issues
```
E501 line too long (85 > 79 characters)
```
rbtools/commands/patch.py (Diff revision 1)
Show all issues
```
E501 line too long (84 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
Show all issues
```
E501 line too long (86 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
Show all issues
```
E501 line too long (83 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
Show all issues
```
E501 line too long (84 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
Show all issues
```
E501 line too long (91 > 79 characters)
```
rbtools/commands/publish.py (Diff revision 1)
Show all issues
```
E501 line too long (81 > 79 characters)
```
rbtools/commands/setup_completion.py (Diff revision 1)
Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/setup_repo.py (Diff revision 1)
Show all issues
```
E501 line too long (83 > 79 characters)
```
rbtools/commands/setup_repo.py (Diff revision 1)
Show all issues
```
E501 line too long (88 > 79 characters)
```
rbtools/commands/setup_repo.py (Diff revision 1)
Show all issues
```
E501 line too long (89 > 79 characters)
```
rbtools/commands/tests/__init__.py (Diff revision 1)
Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/tests/__init__.py (Diff revision 1)
Show all issues
```
W292 no newline at end of file
```

Summary:

-	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	[WIP] Added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object

Description:

~		[WIP] RBTools commands were previously using `print` and `sys.stderr`
	~	RBTools commands were previously using `print` and `sys.stderr`
		to output messages. This change abstracting outputting by using a
		wrapper around a stream output object. This makes it easier to customize
		output streams and suppress output. 4 wrappers (2 for standard output
		unicode and byte, 2 for standard error unicode and byte) are initiated
		in the Command class that is accessible to all child classes.

Groups:

+	students

Change Summary:

Fixing Review Bot issues and multiline string formatting

Commits:

	Summary
-	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
-	replaced all of the prints with output wrapper and initiated wrapper in Command init
+	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	replaced all of the prints with output wrapper and initiated wrapper in Command init
+	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts

Diff:

Revision 2 (+496 -344)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```

rbtools/commands/land.py (Diff revision 2)

Show all issues

E124 closing bracket does not match visual indentation

rbtools/commands/setup_repo.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
rbtools/commands/status_update.py (Diff revision 2)
Show all issues
```
E501 line too long (86 > 79 characters)
```
rbtools/commands/tests/__init__.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```

Commits:

	Summary
-	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
-	replaced all of the prints with output wrapper and initiated wrapper in Command init
-	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
+	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	replaced all of the prints with output wrapper and initiated wrapper in Command init
+	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
+	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters

Diff:

Revision 3 (+506 -352)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Added new test for Outputwrapper's new_line() that ensures output stream receives new line character

Commits:

	Summary
-	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
-	replaced all of the prints with output wrapper and initiated wrapper in Command init
-	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
-	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
+	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	replaced all of the prints with output wrapper and initiated wrapper in Command init
+	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
+	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
+	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called

Diff:

Revision 4 (+527 -355)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/tests/__init__.py (Diff revision 4)
Show all issues
```
W292 no newline at end of file
```

rbtools/commands/patch.py (Diff revision 4)

Show all issues

For consistency with the other changes, should this maybe instead be self.stdout.new_line() ?

rbtools/commands/post.py (Diff revision 4)

Show all issues

Again for consistency, maybe this should be self.stdout.new_line() ?

rbtools/commands/setup_repo.py (Diff revision 4)
Show all issues
```
This should be self.stdout.new_line()?
```
rbtools/commands/setup_repo.py (Diff revision 4)
Show all issues
```
This should be self.stdout.new_line() ?
```
rbtools/commands/setup_repo.py (Diff revision 4)
Show all issues
```
This should also be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
Show all issues
```
This should be self.stdout.new_line()
```

Show all issues

All the changes suggested have to do with consistency with self.stdout.new_line(). Other than that, everything else looks good to me!

Change Summary:

Replaced self.stdout.write("\n") with self.stdout.new_line()

Commits:

	Summary
-	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
-	replaced all of the prints with output wrapper and initiated wrapper in Command init
-	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
-	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
-	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
+	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	replaced all of the prints with output wrapper and initiated wrapper in Command init
+	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
+	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
+	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
+	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()

Diff:

Revision 5 (+543 -369)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/tests/__init__.py (Diff revision 5)
Show all issues
```
W391 blank line at end of file
```
rbtools/commands/tests/__init__.py (Diff revision 5)
Show all issues
```
W293 blank line contains whitespace
```

Commits:

	Summary
-	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
-	replaced all of the prints with output wrapper and initiated wrapper in Command init
-	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
-	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
-	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
-	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()
+	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	replaced all of the prints with output wrapper and initiated wrapper in Command init
+	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
+	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
+	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
+	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()
+	Fixed white space error at the end of rbtools/commands/__init__.py

Diff:

Revision 6 (+542 -370)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Changed status from work in progress to in review

Summary:

-	[WIP] Added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	Added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object

Testing Done:

~		Ran all tests in ./tests/runtests.py rbtools/commands/ and passed.
	~	Ran all tests in `./tests/runtests.py rbtools.commands` and passed.

~		Added two new tests for `__init.py`. One that tests if output stream
	~	Added two new tests for `__init__.py`. One that tests if output stream
		object is set correctly for `OutputWrapper` and another test that makes
		sure `OutputWrapper` passes the correct message to the output stream object

Commits:

	Summary
-	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
-	replaced all of the prints with output wrapper and initiated wrapper in Command init
-	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
-	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
-	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
-	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()
-	Fixed white space error at the end of rbtools/commands/__init__.py
+	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	replaced all of the prints with output wrapper and initiated wrapper in Command init
+	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
+	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
+	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
+	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()
+	Fixed white space error at the end of rbtools/commands/__init__.py
+	changed print statements in __init__.py to use output wrapper

Diff:

Revision 7 (+570 -398)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 7)
Show all issues
```
E501 line too long (81 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 7)
Show all issues
```
E501 line too long (89 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 7)
Show all issues
```
E501 line too long (83 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 7)
Show all issues
```
E501 line too long (89 > 79 characters)
```

Commits:

	Summary
-	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
-	replaced all of the prints with output wrapper and initiated wrapper in Command init
-	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
-	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
-	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
-	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()
-	Fixed white space error at the end of rbtools/commands/__init__.py
-	changed print statements in __init__.py to use output wrapper
+	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	replaced all of the prints with output wrapper and initiated wrapper in Command init
+	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
+	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
+	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
+	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()
+	Fixed white space error at the end of rbtools/commands/__init__.py
+	changed print statements in __init__.py to use output wrapper
+	fixed Review Bot issues where lines where over 80 characters in __init__.py

Diff:

Revision 8 (+579 -405)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/commands/tests/__init__.py (Diff revision 8)

Show all issues

All test cases should be in files called test_X, not the __init__.py. In this case I think you could probably add your new test class to the existing test_main.py file.
This class should also probably be called OutputWrapperTests.

rbtools/commands/tests/__init__.py (Diff revision 8)

Show all issues

A few changes in here:

The file needs a module docstring
The first thing after that docstring should be from __future__ import unicode_literals
Imports should be structured in three groups: standard library, third-party libraries, and then rbtools. In each group we alphabetize the imports. So these should look like:


import sys

from kgb import SpyAgency

from rbtools.commands import OutputWrapper
from rbtools.utils.testbase import RBTestBase

rbtools/commands/tests/__init__.py (Diff revision 8)
Show all issues
```
Dedent this three spaces.
```
rbtools/commands/tests/__init__.py (Diff revision 8)
Show all issues
```
Typo: strea -> stream
```

Show all issues

Your summary should be much shorter, about 70 columns. Further detail (for example, what tests were added) should be in the description.

Summary:

-	Added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	OutputWrapper class to Commands which outputs to stream object of choice

Commits:

	Summary
-	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
-	replaced all of the prints with output wrapper and initiated wrapper in Command init
-	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
-	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
-	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
-	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()
-	Fixed white space error at the end of rbtools/commands/__init__.py
-	changed print statements in __init__.py to use output wrapper
-	fixed Review Bot issues where lines where over 80 characters in __init__.py
+	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	replaced all of the prints with output wrapper and initiated wrapper in Command init
+	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
+	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
+	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
+	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()
+	Fixed white space error at the end of rbtools/commands/__init__.py
+	changed print statements in __init__.py to use output wrapper
+	fixed Review Bot issues where lines where over 80 characters in __init__.py
+	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests
+	fixed indentation and misspelled words issues in test_main.py:OutputWrapper

Diff:

Revision 9 (+615 -449)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary
-	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
-	replaced all of the prints with output wrapper and initiated wrapper in Command init
-	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
-	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
-	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
-	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()
-	Fixed white space error at the end of rbtools/commands/__init__.py
-	changed print statements in __init__.py to use output wrapper
-	fixed Review Bot issues where lines where over 80 characters in __init__.py
-	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests
-	fixed indentation and misspelled words issues in test_main.py:OutputWrapper
+	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	replaced all of the prints with output wrapper and initiated wrapper in Command init
+	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts
+	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters
+	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called
+	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()
+	Fixed white space error at the end of rbtools/commands/__init__.py
+	changed print statements in __init__.py to use output wrapper
+	fixed Review Bot issues where lines where over 80 characters in __init__.py
+	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests
+	fixed indentation and misspelled words issues in test_main.py:OutputWrapper
+	moved OutputWrapper tests to test_main.py and imported KGB

Diff:

Revision 10 (+617 -449)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

You have a pending review.

OutputWrapper class to Commands which outputs to stream object of choice

flake8

Summary:

Description:

Groups:

Change Summary:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (2 succeeded)

Change Summary:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Change Summary:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (2 succeeded)

Change Summary:

Summary:

Testing Done:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (2 succeeded)

Summary:

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (2 succeeded)