Summary

OutputWrapper class to Commands which outputs to stream object of choice

Review Request #11401 — Created Jan. 23, 2021 and submitted Aug. 30, 2021, 2:47 p.m.

Information

Owner

ryankang

Repository

RBTools

Branch

master

Bugs

Depends On

Blocks

11521

Reviewers

Groups

rbtools, students

People

Description

RBTools commands were previously using print and sys.stderr 

to output messages. This change abstracting outputting by using a 

wrapper around a stream output object. This makes it easier to customize 

output streams and suppress output. 4 wrappers (2 for standard output 

unicode and byte, 2 for standard error unicode and byte) are initiated 

in the Command class that is accessible to all child classes.

Testing Done

Ran all tests in ./tests/runtests.py rbtools.commands and passed.

Added two new tests for __init__.py. One that tests if output stream
object is set correctly for OutputWrapper and another test that makes
sure OutputWrapper passes the correct message to the output stream object

Commits

Summary	ID
added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997
moved OutputWrapper tests to test_main.py and imported KGB	ef64e449e9026ac8a171ef712a8295b30a90a88c
Added docstrings for OutputWrapper methods changed stdout_byte to stdout_bytes and stderr_byte to stderr_bytes in Command __init__ String styling changes to properly align tabs and to ensure spaces go on end of strings Changed importing kgb SpyAgency to import kgb Added spacing where needed and alphabetical ordering of test_main.py imports Improved description of OutputWrapperTests in test_main.py	c25d2df4c21dd1da9a1f6f9df6dbdc483ec5bea1
Changed docstrings to follow Review Board documentation guide. Spacing issues between statements fixed Added attributes to Command docstring that summarizes attributes defined in its __init__ Refactored patch.py outputting of byte strings to use self.stdout_bytes properly Indentation issues from lint checkers fixed Fixed docstrings of OutputWrapperTests in test_main.py to format correctly with documentation	86196002cfc2c374c4cfa56123fd63da123e657f
Fixed multiple blank lines with indentation problems Fixed lines which exceeded 80 characters Fixed overindentation in setup_repo.py	b7f620e9317c269ef71f3288f6747b02088533f1

Issues

Description	From	Last Updated
All the changes suggested have to do with consistency with self.stdout.new_line(). Other than that, everything else looks good to me!	amohapatra	Feb. 13, 2021, 3:51 p.m.
Your summary should be much shorter, about 70 columns. Further detail (for example, what tests were added) should be in …	david	March 2, 2021, 10 p.m.
E501 line too long (85 > 79 characters)	reviewbot	Jan. 24, 2021, 9:11 a.m.
E501 line too long (91 > 79 characters)	reviewbot	Jan. 24, 2021, 9:11 a.m.
W293 blank line contains whitespace	reviewbot	Jan. 24, 2021, 9:13 a.m.
E501 line too long (85 > 79 characters)	reviewbot	Jan. 24, 2021, 9:14 a.m.
E501 line too long (88 > 79 characters)	reviewbot	Jan. 24, 2021, 9:33 a.m.
E501 line too long (89 > 79 characters)	reviewbot	Jan. 24, 2021, 9:33 a.m.
E211 whitespace before '('	reviewbot	Jan. 24, 2021, 9:35 a.m.
E501 line too long (91 > 79 characters)	reviewbot	Jan. 24, 2021, 9:39 a.m.
E501 line too long (90 > 79 characters)	reviewbot	Jan. 24, 2021, 9:39 a.m.
E501 line too long (89 > 79 characters)	reviewbot	Jan. 24, 2021, 9:57 a.m.
E501 line too long (88 > 79 characters)	reviewbot	Jan. 24, 2021, 9:57 a.m.
E501 line too long (85 > 79 characters)	reviewbot	Jan. 24, 2021, 9:57 a.m.
E501 line too long (84 > 79 characters)	reviewbot	Jan. 24, 2021, 9:57 a.m.
E501 line too long (86 > 79 characters)	reviewbot	Feb. 6, 2021, 12:46 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Feb. 6, 2021, 12:46 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Feb. 6, 2021, 12:46 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 6, 2021, 12:46 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Feb. 6, 2021, 12:46 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Feb. 6, 2021, 12:47 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 6, 2021, 12:47 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Feb. 6, 2021, 12:47 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Feb. 6, 2021, 12:47 p.m.
E501 line too long (89 > 79 characters)	reviewbot	Feb. 6, 2021, 12:48 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 6, 2021, 12:48 p.m.
W292 no newline at end of file	reviewbot	Feb. 6, 2021, 12:48 p.m.
W291 trailing whitespace	reviewbot	Feb. 6, 2021, 12:52 p.m.
E124 closing bracket does not match visual indentation	reviewbot	Feb. 6, 2021, 12:52 p.m.
E231 missing whitespace after ','	reviewbot	Feb. 6, 2021, 12:52 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Feb. 6, 2021, 12:53 p.m.
W291 trailing whitespace	reviewbot	Feb. 6, 2021, 12:56 p.m.
For consistency with the other changes, should this maybe instead be self.stdout.new_line() ?	amohapatra	Feb. 13, 2021, 3:54 p.m.
Again for consistency, maybe this should be self.stdout.new_line() ?	amohapatra	Feb. 13, 2021, 3:54 p.m.
This should be self.stdout.new_line()?	amohapatra	Feb. 13, 2021, 3:53 p.m.
This should be self.stdout.new_line() ?	amohapatra	Feb. 13, 2021, 3:53 p.m.
This should also be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 3:53 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 3:53 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 3:53 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 3:53 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 3:52 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 3:52 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 3:52 p.m.
This should be self.stdout.new_line()	amohapatra	Feb. 13, 2021, 3:52 p.m.
W292 no newline at end of file	reviewbot	Feb. 13, 2021, 3:59 p.m.
W391 blank line at end of file	reviewbot	Feb. 13, 2021, 4:06 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 13, 2021, 4:06 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Feb. 19, 2021, 12:32 p.m.
E501 line too long (89 > 79 characters)	reviewbot	Feb. 19, 2021, 12:32 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Feb. 19, 2021, 12:32 p.m.
E501 line too long (89 > 79 characters)	reviewbot	Feb. 19, 2021, 12:32 p.m.
All test cases should be in files called test_X, not the __init__.py. In this case I think you could probably …	david	March 2, 2021, 9:56 p.m.
A few changes in here: The file needs a module docstring The first thing after that docstring should be from …	david	March 5, 2021, 8:26 p.m.
Dedent this three spaces.	david	March 2, 2021, 9:58 p.m.
Typo: strea -> stream	david	March 2, 2021, 10 p.m.
This needs a method docstring.	david	March 27, 2021, 1:19 p.m.
This needs a method docstring.	david	March 27, 2021, 1:21 p.m.
This needs a method docstring.	david	March 27, 2021, 1:21 p.m.
Can we call these _bytes instead of _byte?	david	March 27, 2021, 1:24 p.m.
Let's add another newline in here, before the format operation. Otherwise it's sometimes easy to miss when scanning quickly through …	david	March 27, 2021, 1:26 p.m.
The second line here needs to be indented a bit more: % (review_request.submitter.fullname or review_request.submitter.username))	david	March 27, 2021, 1:26 p.m.
When we wrap a string, we put the space at the end of the first line. Let's also put the …	david	March 27, 2021, 1:27 p.m.
Please undo the changes here (so the space is at the end of the first line).	david	March 27, 2021, 1:28 p.m.
One thing Christian just pointed out to me is that he's been moving to just import kgb, and then using …	david	March 27, 2021, 1:30 p.m.
Please make sure this is sorted alphabetically.	david	March 27, 2021, 1:31 p.m.
We still need two blank lines here.	david	March 27, 2021, 2:04 p.m.
This isn't a good description. Let's say "Unit tests for command OutputWrapper"	david	March 27, 2021, 2:05 p.m.
Docstrings need to be in the following form: """Single-line summary. Multi-line description. """ Along with this, for any newly-introduced classes …	chipx86	April 2, 2021, 1:08 p.m.
Function docstrings must follow the same form, and specify any arguments, return values, and exceptions raised. Take a look at …	chipx86	April 2, 2021, 1:43 p.m.
We expect a blank line between the end of a block and a new statememt, to help separate that out …	chipx86	April 2, 2021, 1:52 p.m.
There's some typos in these docstrings ("charater" here, "specifiy" in the class docstring). If your editor supports it, I recommend …	chipx86	April 2, 2021, 1:53 p.m.
This docstring is old, and needs to be modernized. As a step toward this, since you're introducing some really important …	chipx86	April 3, 2021, 11:09 a.m.
There's an inconsistency in variable names. You have stderr_bytes (plural) and stderr_byte (singular). The plural form is what we want, …	chipx86	April 3, 2021, 11:10 a.m.
Here's an area where the new output wrappers solve a problem! Not all diffs can be decoded as UTF-8, so …	chipx86	April 3, 2021, 12:37 p.m.
The string is a parameter to textwrap.fill(), rather than a second parameter to stdout.write. Since we're wrapping to the following …	chipx86	April 3, 2021, 12:43 p.m.
To keep lint checkers from complaining about indentations being multiples of 4, this should actually be in the same form …	chipx86	April 3, 2021, 12:53 p.m.
This should be a single import statement.	chipx86	April 3, 2021, 12:54 p.m.
This is a class docstring, so it needs to have a trailing period.	chipx86	April 3, 2021, 12:56 p.m.
All unit test docstrings should be in the form of Testing <Thing> <condition>. For instance, Testing OutputWrapper initializes stream Testing …	chipx86	April 3, 2021, 1:13 p.m.
W293 blank line contains whitespace	reviewbot	April 3, 2021, 1:23 p.m.
W293 blank line contains whitespace	reviewbot	April 3, 2021, 1:23 p.m.
W293 blank line contains whitespace	reviewbot	April 3, 2021, 1:24 p.m.
E501 line too long (80 > 79 characters)	reviewbot	April 3, 2021, 1:24 p.m.
W293 blank line contains whitespace	reviewbot	April 3, 2021, 1:24 p.m.
W293 blank line contains whitespace	reviewbot	April 3, 2021, 1:24 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	April 3, 2021, 1:30 p.m.
F401 'rbtools.commands.JSONWrapper' imported but unused	reviewbot	April 10, 2021, 7:17 p.m.
F821 undefined name 'JSONOutput'	reviewbot	April 10, 2021, 7:17 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (85 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (91 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/alias.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (85 > 79 characters)
```
rbtools/commands/alias.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (88 > 79 characters)
```
rbtools/commands/alias.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (89 > 79 characters)
```
rbtools/commands/info.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E211 whitespace before '('
```
rbtools/commands/land.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (91 > 79 characters)
```
rbtools/commands/land.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (90 > 79 characters)
```
rbtools/commands/patch.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (89 > 79 characters)
```
rbtools/commands/patch.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (88 > 79 characters)
```
rbtools/commands/patch.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (85 > 79 characters)
```
rbtools/commands/patch.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (84 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (84 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (91 > 79 characters)
```
rbtools/commands/publish.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
rbtools/commands/setup_completion.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/setup_repo.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
rbtools/commands/setup_repo.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (88 > 79 characters)
```
rbtools/commands/setup_repo.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (89 > 79 characters)
```
rbtools/commands/tests/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/tests/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W292 no newline at end of file
```

Summary:

-	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	[WIP] Added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object

Description:

~		[WIP] RBTools commands were previously using `print` and `sys.stderr`
	~	RBTools commands were previously using `print` and `sys.stderr`
		to output messages. This change abstracting outputting by using a
		wrapper around a stream output object. This makes it easier to customize
		output streams and suppress output. 4 wrappers (2 for standard output
		unicode and byte, 2 for standard error unicode and byte) are initiated
		in the Command class that is accessible to all child classes.

Groups:

+	students

Change Summary:

Fixing Review Bot issues and multiline string formatting

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6

Diff:

Revision 2 (+496 -344)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/commands/land.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E124 closing bracket does not match visual indentation
```
rbtools/commands/setup_repo.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
rbtools/commands/status_update.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
rbtools/commands/tests/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413

Diff:

Revision 3 (+506 -352)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Added new test for Outputwrapper's new_line() that ensures output stream receives new line character

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30

Diff:

Revision 4 (+527 -355)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/tests/__init__.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W292 no newline at end of file
```

rbtools/commands/patch.py (Diff revision 4)

The issue has been resolved. Show all issues

For consistency with the other changes, should this maybe instead be self.stdout.new_line() ?

rbtools/commands/post.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Again for consistency, maybe this should be self.stdout.new_line() ?
```
rbtools/commands/setup_repo.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This should be self.stdout.new_line()?
```
rbtools/commands/setup_repo.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This should be self.stdout.new_line() ?
```
rbtools/commands/setup_repo.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This should also be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This should be self.stdout.new_line()
```
rbtools/commands/setup_repo.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This should be self.stdout.new_line()
```

The issue has been resolved. Show all issues

All the changes suggested have to do with consistency with self.stdout.new_line(). Other than that, everything else looks good to me!

Change Summary:

Replaced self.stdout.write("\n") with self.stdout.new_line()

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4

Diff:

Revision 5 (+543 -369)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/tests/__init__.py (Diff revision 5)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```
rbtools/commands/tests/__init__.py (Diff revision 5)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9

Diff:

Revision 6 (+542 -370)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Changed status from work in progress to in review

Summary:

-	[WIP] Added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	Added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object

Testing Done:

~		Ran all tests in ./tests/runtests.py rbtools/commands/ and passed.
	~	Ran all tests in `./tests/runtests.py rbtools.commands` and passed.

~		Added two new tests for `__init.py`. One that tests if output stream
	~	Added two new tests for `__init__.py`. One that tests if output stream
		object is set correctly for `OutputWrapper` and another test that makes
		sure `OutputWrapper` passes the correct message to the output stream object

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9

Diff:

Revision 7 (+570 -398)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (89 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (89 > 79 characters)
```

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f

Diff:

Revision 8 (+579 -405)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/commands/tests/__init__.py (Diff revision 8)

The issue has been resolved. Show all issues

All test cases should be in files called test_X, not the __init__.py. In this case I think you could probably add your new test class to the existing test_main.py file.
This class should also probably be called OutputWrapperTests.

rbtools/commands/tests/__init__.py (Diff revision 8)

The issue has been resolved. Show all issues

A few changes in here:

The file needs a module docstring
The first thing after that docstring should be from __future__ import unicode_literals
Imports should be structured in three groups: standard library, third-party libraries, and then rbtools. In each group we alphabetize the imports. So these should look like:


import sys

from kgb import SpyAgency

from rbtools.commands import OutputWrapper
from rbtools.utils.testbase import RBTestBase

rbtools/commands/tests/__init__.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Dedent this three spaces.
```
rbtools/commands/tests/__init__.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Typo: strea -> stream
```

The issue has been resolved. Show all issues

Your summary should be much shorter, about 70 columns. Further detail (for example, what tests were added) should be in the description.

Summary:

-	Added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object
+	OutputWrapper class to Commands which outputs to stream object of choice

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
	fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997

Diff:

Revision 9 (+615 -449)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
	fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
	fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997
	moved OutputWrapper tests to test_main.py and imported KGB	ef64e449e9026ac8a171ef712a8295b30a90a88c

Diff:

Revision 10 (+617 -449)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/commands/__init__.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/commands/__init__.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/commands/__init__.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/commands/__init__.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Can we call these _bytes instead of _byte?
```

rbtools/commands/__init__.py (Diff revision 10)

The issue has been resolved. Show all issues

Let's add another newline in here, before the format operation. Otherwise it's sometimes easy to miss when scanning quickly through the code.

self.stdout.write('Please log in to the Review Board server at '
                  '%s.'
                  % urlparse(uri)[1])

rbtools/commands/info.py (Diff revision 10)

The issue has been resolved. Show all issues

The second line here needs to be indented a bit more:

% (review_request.submitter.fullname or
   review_request.submitter.username))

rbtools/commands/land.py (Diff revision 10)

The issue has been resolved. Show all issues

When we wrap a string, we put the space at the end of the first line. Let's also put the format parameters on their own line:

self.stdout.write('Recursively landing dependencies of '
                  'review request %s.'
                  % review_request_id)

rbtools/commands/patch.py (Diff revision 10)

The issue has been resolved. Show all issues

Please undo the changes here (so the space is at the end of the first line).

rbtools/commands/status_update.py (Diff revision 10)

The new formatting here is so much nicer! Good work.

rbtools/commands/tests/test_main.py (Diff revision 10)

The issue has been resolved. Show all issues

One thing Christian just pointed out to me is that he's been moving to just import kgb, and then using kgb.SpyAgency where necessary. This makes it easier when we want to add things later like spy operations.

rbtools/commands/tests/test_main.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please make sure this is sorted alphabetically.
```
rbtools/commands/tests/test_main.py (Diff revision 10)
The issue has been resolved. Show all issues
```
We still need two blank lines here.
```
rbtools/commands/tests/test_main.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This isn't a good description. Let's say "Unit tests for command OutputWrapper"
```

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
	fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997
	moved OutputWrapper tests to test_main.py and imported KGB	ef64e449e9026ac8a171ef712a8295b30a90a88c
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
	fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997
	moved OutputWrapper tests to test_main.py and imported KGB	ef64e449e9026ac8a171ef712a8295b30a90a88c
	Added docstrings for OutputWrapper methods changed stdout_byte to stdout_bytes and stderr_byte to stderr_bytes in Command __init__ String styling changes to properly align tabs and to ensure spaces go on end of strings Changed importing kgb SpyAgency to import kgb Added spacing where needed and alphabetical ordering of test_main.py imports Improved description of OutputWrapperTests in test_main.py	c25d2df4c21dd1da9a1f6f9df6dbdc483ec5bea1

Diff:

Revision 11 (+652 -458)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/commands/__init__.py (Diff revision 11)

The issue has been resolved. Show all issues

Docstrings need to be in the following form:

"""Single-line summary.

Multi-line description.
"""

Along with this, for any newly-introduced classes (or new functions/attributes on existing classes), we want to include version information directly below the description, like so:

"""Single-line summary.

Multi-line description.

Version Added:
    3.0
"""

rbtools/commands/__init__.py (Diff revision 11)

The issue has been resolved. Show all issues

Function docstrings must follow the same form, and specify any arguments, return values, and exceptions raised. Take a look at the docs for this on Notion.
We do have a lot of old docstrings in RBTools that don't conform to the modern standard, but if you grep around for "Args:" or "Returns:", you'll see examples.
This comment applies throughout the change.

rbtools/commands/__init__.py (Diff revision 11)

The issue has been resolved. Show all issues

We expect a blank line between the end of a block and a new statememt, to help separate that out as a new chunk of code.

rbtools/commands/__init__.py (Diff revision 11)

The issue has been resolved. Show all issues

There's some typos in these docstrings ("charater" here, "specifiy" in the class docstring). If your editor supports it, I recommend running a spell check.

rbtools/commands/__init__.py (Diff revision 11)

The issue has been resolved. Show all issues

This docstring is old, and needs to be modernized. As a step toward this, since you're introducing some really important new attributes, let's begin documenting them.

To do this, add an Attributes section at the end of this docstring:

"""...

...

Attributes:
    stderr (OutputWrapper):
        Standard error output wrapper that subclasses must write to.

    stdout (OutputWrapper):
        ...

    ...

Attributes should be in alphabetical order.

rbtools/commands/__init__.py (Diff revision 11)

The issue has been resolved. Show all issues

There's an inconsistency in variable names. You have stderr_bytes (plural) and stderr_byte (singular).

The plural form is what we want, I think.

Also, this if/else always sets both, so we have no reason to default to None above.

rbtools/commands/patch.py (Diff revision 11)

The issue has been resolved. Show all issues

Here's an area where the new output wrappers solve a problem!
Not all diffs can be decoded as UTF-8, so we want to write as a byte string. This code here was using sys.stdout.buffer.write to let us do that on Python 3, and just print() on Python 2.
The correct thing will be to replace this entire chunk of logic with a write to self.stdout_bytes.
Make sure, along with replacing print statements, that you're looking for and replacing sys.stdout or sys.stderr.

rbtools/commands/setup_repo.py (Diff revision 11)

The issue has been resolved. Show all issues

The string is a parameter to textwrap.fill(), rather than a second parameter to stdout.write. Since we're wrapping to the following line to give us room for the text, we need to keep it 4 spaces indented from the start of the main statement. In order words, what we had before was correct.

rbtools/commands/setup_repo.py (Diff revision 11)

The issue has been resolved. Show all issues

To keep lint checkers from complaining about indentations being multiples of 4, this should actually be in the same form we had before. The parameters indent to 4 spaces relative to the statement, allowing dictionary keys to indent 4 spaces from that. So you can revert these indentation changes, and keep the string on the second line.

rbtools/commands/tests/test_main.py (Diff revision 11)
The issue has been resolved. Show all issues
```
This should be a single import statement.
```
rbtools/commands/tests/test_main.py (Diff revision 11)
The issue has been resolved. Show all issues
```
This is a class docstring, so it needs to have a trailing period.
```

rbtools/commands/tests/test_main.py (Diff revision 11)

The issue has been resolved. Show all issues

All unit test docstrings should be in the form of Testing <Thing> <condition>.

For instance, Testing OutputWrapper initializes stream

Testing OutputWrapper.write with ...

Testing OutputWrapper.new_line

etc.

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
	fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997
	moved OutputWrapper tests to test_main.py and imported KGB	ef64e449e9026ac8a171ef712a8295b30a90a88c
	Added docstrings for OutputWrapper methods changed stdout_byte to stdout_bytes and stderr_byte to stderr_bytes in Command __init__ String styling changes to properly align tabs and to ensure spaces go on end of strings Changed importing kgb SpyAgency to import kgb Added spacing where needed and alphabetical ordering of test_main.py imports Improved description of OutputWrapperTests in test_main.py	c25d2df4c21dd1da9a1f6f9df6dbdc483ec5bea1
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
	fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997
	moved OutputWrapper tests to test_main.py and imported KGB	ef64e449e9026ac8a171ef712a8295b30a90a88c
	Added docstrings for OutputWrapper methods changed stdout_byte to stdout_bytes and stderr_byte to stderr_bytes in Command __init__ String styling changes to properly align tabs and to ensure spaces go on end of strings Changed importing kgb SpyAgency to import kgb Added spacing where needed and alphabetical ordering of test_main.py imports Improved description of OutputWrapperTests in test_main.py	c25d2df4c21dd1da9a1f6f9df6dbdc483ec5bea1
	Changed docstrings to follow Review Board documentation guide. Spacing issues between statements fixed Added attributes to Command docstring that summarizes attributes defined in its __init__ Refactored patch.py outputting of byte strings to use self.stdout_bytes properly Indentation issues from lint checkers fixed Fixed docstrings of OutputWrapperTests in test_main.py to format correctly with documentation	86196002cfc2c374c4cfa56123fd63da123e657f

Diff:

Revision 12 (+752 -500)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 12)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/__init__.py (Diff revision 12)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/__init__.py (Diff revision 12)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/__init__.py (Diff revision 12)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 12)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/__init__.py (Diff revision 12)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/setup_repo.py (Diff revision 12)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
	fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997
	moved OutputWrapper tests to test_main.py and imported KGB	ef64e449e9026ac8a171ef712a8295b30a90a88c
	Added docstrings for OutputWrapper methods changed stdout_byte to stdout_bytes and stderr_byte to stderr_bytes in Command __init__ String styling changes to properly align tabs and to ensure spaces go on end of strings Changed importing kgb SpyAgency to import kgb Added spacing where needed and alphabetical ordering of test_main.py imports Improved description of OutputWrapperTests in test_main.py	c25d2df4c21dd1da9a1f6f9df6dbdc483ec5bea1
	Changed docstrings to follow Review Board documentation guide. Spacing issues between statements fixed Added attributes to Command docstring that summarizes attributes defined in its __init__ Refactored patch.py outputting of byte strings to use self.stdout_bytes properly Indentation issues from lint checkers fixed Fixed docstrings of OutputWrapperTests in test_main.py to format correctly with documentation	86196002cfc2c374c4cfa56123fd63da123e657f
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
	fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997
	moved OutputWrapper tests to test_main.py and imported KGB	ef64e449e9026ac8a171ef712a8295b30a90a88c
	Added docstrings for OutputWrapper methods changed stdout_byte to stdout_bytes and stderr_byte to stderr_bytes in Command __init__ String styling changes to properly align tabs and to ensure spaces go on end of strings Changed importing kgb SpyAgency to import kgb Added spacing where needed and alphabetical ordering of test_main.py imports Improved description of OutputWrapperTests in test_main.py	c25d2df4c21dd1da9a1f6f9df6dbdc483ec5bea1
	Changed docstrings to follow Review Board documentation guide. Spacing issues between statements fixed Added attributes to Command docstring that summarizes attributes defined in its __init__ Refactored patch.py outputting of byte strings to use self.stdout_bytes properly Indentation issues from lint checkers fixed Fixed docstrings of OutputWrapperTests in test_main.py to format correctly with documentation	86196002cfc2c374c4cfa56123fd63da123e657f
	Fixed multiple blank lines with indentation problems Fixed lines which exceeded 80 characters Fixed overindentation in setup_repo.py	b7f620e9317c269ef71f3288f6747b02088533f1

Diff:

Revision 13 (+765 -515)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
	fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997
	moved OutputWrapper tests to test_main.py and imported KGB	ef64e449e9026ac8a171ef712a8295b30a90a88c
	Added docstrings for OutputWrapper methods changed stdout_byte to stdout_bytes and stderr_byte to stderr_bytes in Command __init__ String styling changes to properly align tabs and to ensure spaces go on end of strings Changed importing kgb SpyAgency to import kgb Added spacing where needed and alphabetical ordering of test_main.py imports Improved description of OutputWrapperTests in test_main.py	c25d2df4c21dd1da9a1f6f9df6dbdc483ec5bea1
	Changed docstrings to follow Review Board documentation guide. Spacing issues between statements fixed Added attributes to Command docstring that summarizes attributes defined in its __init__ Refactored patch.py outputting of byte strings to use self.stdout_bytes properly Indentation issues from lint checkers fixed Fixed docstrings of OutputWrapperTests in test_main.py to format correctly with documentation	86196002cfc2c374c4cfa56123fd63da123e657f
	Fixed multiple blank lines with indentation problems Fixed lines which exceeded 80 characters Fixed overindentation in setup_repo.py	b7f620e9317c269ef71f3288f6747b02088533f1
	merged in Output Wrapper Object from r#11401	fc3442b40f7688eae2dc8943c3905de1189aba49
	added new method to print JSON to stream object and tests to ensure it works properly	93a7f52f930aec3fe39c3d0d9c0f15ee4a14922c
	added new global command --json	8d6ea988b098794628c133cbbcd42f524293d873
	added conditional at the end of command cycle to print JSON is enabled	312b2d649dc71fa01637c427209d5f972c193402
	added method to append to classes and tests to ensure items are appended correctly	9ecb2ddb435c1889c5b000d2ad2d57f7bc3f04b8
	added new method to add errors to existing errors key or create a new one	99df72a53c52f7b839decff237fa694d19baa190
	Fixed issues with extra white spaces in files from Review Bot	505c93c8f2a525fc8a8114e37b69ccdf4f283b9d
	Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput Improved command hint for --json Fixed header in test_main to import kgb and concatonated imports from rbtools.commands Created _setup() method in JSONOutputTests test class to standardize JSONOutput initialization	1c4e3367bd82af470f4889056c35e1e137b9d9ff
	Fixed minor formatting issues in test_main.py	c110d05aca25324d53b55ed678169610aa9a7c07
	Updated JSONOutput docstrings to format with guidelines	d58d4e8f8bbe7b1c4486479d2d4ebc25cb545010
	Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines	29daf66756b65033e122b5cb2466e588ad4a7635
	Checking if there are any errors in json to decide status	a0ee53dabe7e1c7894412281719b38db1410f16f
	Fixed trailing white space in test_main.test_hson_wrapper_append	40c9ab291084fd36bed86e74761ed579706a612c
	Fixed blank lines with spaces in __init__ Command.run_from_argv	fe0dd7c90d293e3885890f4ca3be0dafe506a63a
	Added any CommandError caught to errors key	b662b573e9452277ea177d990b2f8d750028f2f2

Diff:

Revision 14 (+465 -99)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/tests/test_main.py (Diff revision 14)
The issue has been resolved. Show all issues
```
F401 'rbtools.commands.JSONWrapper' imported but unused
```
rbtools/commands/tests/test_main.py (Diff revision 14)
The issue has been resolved. Show all issues
```
F821 undefined name 'JSONOutput'
```

Commits:

	Summary	ID
	merged in Output Wrapper Object from r#11401	fc3442b40f7688eae2dc8943c3905de1189aba49
	added new method to print JSON to stream object and tests to ensure it works properly	93a7f52f930aec3fe39c3d0d9c0f15ee4a14922c
	added new global command --json	8d6ea988b098794628c133cbbcd42f524293d873
	added conditional at the end of command cycle to print JSON is enabled	312b2d649dc71fa01637c427209d5f972c193402
	added method to append to classes and tests to ensure items are appended correctly	9ecb2ddb435c1889c5b000d2ad2d57f7bc3f04b8
	added new method to add errors to existing errors key or create a new one	99df72a53c52f7b839decff237fa694d19baa190
	Fixed issues with extra white spaces in files from Review Bot	505c93c8f2a525fc8a8114e37b69ccdf4f283b9d
	Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput Improved command hint for --json Fixed header in test_main to import kgb and concatonated imports from rbtools.commands Created _setup() method in JSONOutputTests test class to standardize JSONOutput initialization	1c4e3367bd82af470f4889056c35e1e137b9d9ff
	Fixed minor formatting issues in test_main.py	c110d05aca25324d53b55ed678169610aa9a7c07
	Updated JSONOutput docstrings to format with guidelines	d58d4e8f8bbe7b1c4486479d2d4ebc25cb545010
	Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines	29daf66756b65033e122b5cb2466e588ad4a7635
	Checking if there are any errors in json to decide status	a0ee53dabe7e1c7894412281719b38db1410f16f
	Fixed trailing white space in test_main.test_hson_wrapper_append	40c9ab291084fd36bed86e74761ed579706a612c
	Fixed blank lines with spaces in __init__ Command.run_from_argv	fe0dd7c90d293e3885890f4ca3be0dafe506a63a
	Added any CommandError caught to errors key	b662b573e9452277ea177d990b2f8d750028f2f2
	merged in Output Wrapper Object from r#11401	fc3442b40f7688eae2dc8943c3905de1189aba49
	added new method to print JSON to stream object and tests to ensure it works properly	93a7f52f930aec3fe39c3d0d9c0f15ee4a14922c
	added new global command --json	8d6ea988b098794628c133cbbcd42f524293d873
	added conditional at the end of command cycle to print JSON is enabled	312b2d649dc71fa01637c427209d5f972c193402
	added method to append to classes and tests to ensure items are appended correctly	9ecb2ddb435c1889c5b000d2ad2d57f7bc3f04b8
	added new method to add errors to existing errors key or create a new one	99df72a53c52f7b839decff237fa694d19baa190
	Fixed issues with extra white spaces in files from Review Bot	505c93c8f2a525fc8a8114e37b69ccdf4f283b9d
	Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput Improved command hint for --json Fixed header in test_main to import kgb and concatonated imports from rbtools.commands Created _setup() method in JSONOutputTests test class to standardize JSONOutput initialization	1c4e3367bd82af470f4889056c35e1e137b9d9ff
	Fixed minor formatting issues in test_main.py	c110d05aca25324d53b55ed678169610aa9a7c07
	Updated JSONOutput docstrings to format with guidelines	d58d4e8f8bbe7b1c4486479d2d4ebc25cb545010
	Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines	29daf66756b65033e122b5cb2466e588ad4a7635
	Checking if there are any errors in json to decide status	a0ee53dabe7e1c7894412281719b38db1410f16f
	Fixed trailing white space in test_main.test_hson_wrapper_append	40c9ab291084fd36bed86e74761ed579706a612c
	Fixed blank lines with spaces in __init__ Command.run_from_argv	fe0dd7c90d293e3885890f4ca3be0dafe506a63a
	Added any CommandError caught to errors key	b662b573e9452277ea177d990b2f8d750028f2f2
	Fixed bug where test_main.py was imported JSONWrapper instead of JSONOutput	412f531a218f3c9bf2eac16ebb765ef74d0bcb30

Diff:

Revision 15 (+466 -100)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/tests/test_main.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	merged in Output Wrapper Object from r#11401	fc3442b40f7688eae2dc8943c3905de1189aba49
	added new method to print JSON to stream object and tests to ensure it works properly	93a7f52f930aec3fe39c3d0d9c0f15ee4a14922c
	added new global command --json	8d6ea988b098794628c133cbbcd42f524293d873
	added conditional at the end of command cycle to print JSON is enabled	312b2d649dc71fa01637c427209d5f972c193402
	added method to append to classes and tests to ensure items are appended correctly	9ecb2ddb435c1889c5b000d2ad2d57f7bc3f04b8
	added new method to add errors to existing errors key or create a new one	99df72a53c52f7b839decff237fa694d19baa190
	Fixed issues with extra white spaces in files from Review Bot	505c93c8f2a525fc8a8114e37b69ccdf4f283b9d
	Added docstrings to JSONOutput class and changed name from JSONWrapper to JSONOutput Improved command hint for --json Fixed header in test_main to import kgb and concatonated imports from rbtools.commands Created _setup() method in JSONOutputTests test class to standardize JSONOutput initialization	1c4e3367bd82af470f4889056c35e1e137b9d9ff
	Fixed minor formatting issues in test_main.py	c110d05aca25324d53b55ed678169610aa9a7c07
	Updated JSONOutput docstrings to format with guidelines	d58d4e8f8bbe7b1c4486479d2d4ebc25cb545010
	Updated docstrings in JSONOutputTests in test_main.py to comply with guidelines	29daf66756b65033e122b5cb2466e588ad4a7635
	Checking if there are any errors in json to decide status	a0ee53dabe7e1c7894412281719b38db1410f16f
	Fixed trailing white space in test_main.test_hson_wrapper_append	40c9ab291084fd36bed86e74761ed579706a612c
	Fixed blank lines with spaces in __init__ Command.run_from_argv	fe0dd7c90d293e3885890f4ca3be0dafe506a63a
	Added any CommandError caught to errors key	b662b573e9452277ea177d990b2f8d750028f2f2
	Fixed bug where test_main.py was imported JSONWrapper instead of JSONOutput	412f531a218f3c9bf2eac16ebb765ef74d0bcb30
	added OutputWrapper class to Commands which outputs to stream object of choice. Added test suite that checks if OutputWrapper has correct stream and that OutputWrapper passes correct message to stream object	ca88dd1ff65187e387fdf17dc19f4c0c89fb903c
	replaced all of the prints with output wrapper and initiated wrapper in Command init	e31adcfce9cf6cdbc5272a57a81cb0c7acdd7c5b
	Fixed all of the Review Bot string formatting issues and fixed consistency issues with strings on multiple lines by aligning their starts	360b92a955667e881394ee9f8a482d397bf176e6
	Fixed Review Bot issues on trailing white spaces, indentation, whitespace after comma, and lines over 79 characters	0e77eec5effa3e23f3d13fb7578f2ef22037f413
	Added new test for OutputWrapper than ensures it passes a new line character to output stream when new_line() is called	f137a9331459e3d88d9cb96f3e499730c6adcb30
	Fixed inconsistency of the use of new_line(). Replaced self.stdout.write(n) with self.stdout.new_line()	70cfb2c6f67be4b3f10af316835aae37488328e4
	Fixed white space error at the end of rbtools/commands/__init__.py	91baf8a9e9f2e4d8c9b30a19c76d72b0860849b9
	changed print statements in __init__.py to use output wrapper	7d65b3e5683ebcc7b9e0920146a7bf0b20bd28a9
	fixed Review Bot issues where lines where over 80 characters in __init__.py	43788831f5c440ae0832f705ce943535f8d1936f
	moved OutputWrapper tests from __init__.py to test_main.py and renamed test class to OutputWrapperTests	d8a51ac5c9d2315030b6c514177fc089ab9da020
	fixed indentation and misspelled words issues in test_main.py:OutputWrapper	5b2937ea7acf8e4e602f03abdd97dde2ebaae997
	moved OutputWrapper tests to test_main.py and imported KGB	ef64e449e9026ac8a171ef712a8295b30a90a88c
	Added docstrings for OutputWrapper methods changed stdout_byte to stdout_bytes and stderr_byte to stderr_bytes in Command __init__ String styling changes to properly align tabs and to ensure spaces go on end of strings Changed importing kgb SpyAgency to import kgb Added spacing where needed and alphabetical ordering of test_main.py imports Improved description of OutputWrapperTests in test_main.py	c25d2df4c21dd1da9a1f6f9df6dbdc483ec5bea1
	Changed docstrings to follow Review Board documentation guide. Spacing issues between statements fixed Added attributes to Command docstring that summarizes attributes defined in its __init__ Refactored patch.py outputting of byte strings to use self.stdout_bytes properly Indentation issues from lint checkers fixed Fixed docstrings of OutputWrapperTests in test_main.py to format correctly with documentation	86196002cfc2c374c4cfa56123fd63da123e657f
	Fixed multiple blank lines with indentation problems Fixed lines which exceeded 80 characters Fixed overindentation in setup_repo.py	b7f620e9317c269ef71f3288f6747b02088533f1

Diff:

Revision 16 (+765 -515)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

Making some tweaks and getting this landed. Thanks!

Status: Closed (submitted)

Change Summary:

Pushed to master (db0c1f5)