JSON Output for RBTools Post Command

 






 

 


  Review Request #11560
  —
  Created March 28, 2021 and submitted 

 




















 

  

   Information

  





 
 

  ryankang
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  11521
 






 




 

  

   Reviewers

  





 
 

  rbtools, students
 









 
 

  
 






 








 





  


 
 

  
Depends on JSON output object from r#11521. Output from Post's

review request id and review request url is added to json object.

Any errors from Post command are added to errors list.

 








  


 
 

  
Ran all tests in rbtools/commands/tests and passed them all.


All tests of JSONOutput are included in r#11521

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     
added review_request and review_request_url from post.py


    		
    8a5d2889b5c7f58e840ca7e2fc7d82298f50576e

   


   


    

     
Added errors to error key


    		
    abdb439b510631041984661d4c9c91e5352ac554

   


   


    

     
Removed setting status in post.py because it is handled in __init__.py


    		
    d982def8707396267d3a0c3f045758c92b23eeb8

   


   


    

     
Indentation errors fixed in post.py to align multiline strings


    		
    f6303dc89aac5f0b8c52b764b18746314aea80fc

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
E127 continuation line over-indented for visual indent

      		
      
       reviewbotreviewbot
      
      
       
      
     




     

      
       
       
E128 continuation line under-indented for visual indent

      		
      
       reviewbotreviewbot
      
      
       
      
     


    
   

  

 







 






  

 



















 




 




 














 



 

  

   




ryankang




   

   

  

 



 















 



 

  

   




ryankang




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  











 



  

   
Summary:

   
    
-[WIP] JSON Output for RBTools Post Command
+JSON Output for RBTools Post Command

   		
  




  

   
Commits:

   
    





 

  
   


    

    Summary
    ID

   

  
  

   


    

    

     
added review_request and review_request_url from post.py


    		
    04a61cdbe29497c59e80c1d442b530ae2735ec90

   


   


    

    

     
Added errors to error key


    		
    e3849018a446aab21c86996014b2cb1448741171

   




   


    

    

     
added review_request and review_request_url from post.py


    		
    8a5d2889b5c7f58e840ca7e2fc7d82298f50576e

   


   


    

    

     
Added errors to error key


    		
    abdb439b510631041984661d4c9c91e5352ac554

   


   


    

    

     
Removed setting status in post.py because it is handled in __init__.py


    		
    d982def8707396267d3a0c3f045758c92b23eeb8

   



  
 







   		
  




  

   
Depends On:

   
    
+11521 - JSON wrapper which inputs to a dictionary and outputs a JSON object

   		
  




  

   
Groups:

   
    
+students

   		
  




  

   
Diff:

   
    
 Revision 3 (+29 -3)
Show changes
 
    rbtools/commands/post.py 
 

   		
  



 









 

  
Checks run (1 failed, 1 succeeded)



  

 flake8
 failed.
 





  

 JSHint
 passed.
 





 







 
flake8

 


 















  

 
















 



 

  

   




ryankang




   

   

  

 



 















 



 

  

   




ryankang




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (3bc6ce8)





 


 










  

 









     

    

   

  

  

   
   Loading...