Summary:

JSON Output for RBTools Post Command

Review Request #11560 — Created March 28, 2021 and submitted Oct. 25, 2021, 9:38 p.m.

Information
Owner:	ryankang
Repository:	RBTools
Branch:	master
Bugs:
Depends On:	~~11521~~
Reviewers
Groups:	rbtools, students
People:

Description

Depends on JSON output object from r#11521. Output from Post's
review request id and review request url is added to json object.
Any errors from Post command are added to errors list.

Testing Done

Ran all tests in rbtools/commands/tests and passed them all.

All tests of JSONOutput are included in r#11521

Commits

Summary
added review_request and review_request_url from post.py
Added errors to error key
Removed setting status in post.py because it is handled in __init__.py
Indentation errors fixed in post.py to align multiline strings

Screenshots

Issues

Description	From	Last Updated
E127 continuation line over-indented for visual indent	reviewbot	April 11, 2021, 11:04 a.m.
E128 continuation line under-indented for visual indent	reviewbot	April 11, 2021, 11:05 a.m.

flake8 passed.

JSHint passed.

Commits:

	Summary
-	added review_request and review_request_url from post.py
+	added review_request and review_request_url from post.py
+	Added errors to error key

Diff:

Revision 2 (+30 -2)

Show changes

rbtools/commands/post.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	[WIP] JSON Output for RBTools Post Command
+	JSON Output for RBTools Post Command

Commits:

	Summary
-	added review_request and review_request_url from post.py
-	Added errors to error key
+	added review_request and review_request_url from post.py
+	Added errors to error key
+	Removed setting status in post.py because it is handled in __init__.py

Depends On:

+	~~11521 - JSON wrapper which inputs to a dictionary and outputs a JSON object~~

Groups:

+	students

Diff:

Revision 3 (+29 -3)

Show changes

rbtools/commands/post.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/post.py (Diff revision 3)

Show all issues

E127 continuation line over-indented for visual indent

rbtools/commands/post.py (Diff revision 3)

Show all issues

E128 continuation line under-indented for visual indent

Commits:

	Summary
-	added review_request and review_request_url from post.py
-	Added errors to error key
-	Removed setting status in post.py because it is handled in __init__.py
+	added review_request and review_request_url from post.py
+	Added errors to error key
+	Removed setting status in post.py because it is handled in __init__.py
+	Indentation errors fixed in post.py to align multiline strings

Diff:

Revision 4 (+31 -5)

Show changes

rbtools/commands/post.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to master (3bc6ce8)