Summary

JSON Output for RBTools Status Command

Review Request #11541 — Created March 20, 2021 and submitted Oct. 25, 2021, 9:38 p.m.

Information

Owner

ryankang

Repository

RBTools

Branch

master

Bugs

Depends On

~~11521~~

Reviewers

Groups

rbtools, students

People

Description

Depends on JSON output object from r#11521. Adding information
that goes into rows of the status table into a JSON object. If no requests
are found the array remains empty. Also adds info if format_results is
called.

Testing Done

Ran unit tests in Commands and passed all tests

Commits

Summary	ID
added new method to print JSON to stream object and tests to ensure it works properly	25df4d28942b92a8a571329ce54f43e57b46c8bc
each summary is added as a json object to a list in summaries	675fa33dbdf470e4495e932a90482bacab2ead93
moved definition of summaries to before if statement so that if no requests are found, there still exists a summaries key	3d10681f8240fa5053af5dad2e1648db8bede9b3
fixed extra spaces in no line	46632b15806c44edddf1bfc46fc56b7bfa3d62a7
Removed setting status because it is done in __init__ by checking for errosr	592bf7da19c2e27eeea64dfa0adae7252953d0ff
Importing kgb instead of specific package inside kgb	b06f922afd219110b044a97519632fd6ae919458

Issues

Description	From	Last Updated
The diff of this includes the changes from your other review request. You probably want to post and explicitly specify …	david	March 28, 2021, 4:05 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 2:46 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 2:46 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 2:47 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 2:47 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 2:48 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 2:48 p.m.
E303 too many blank lines (2)	reviewbot	March 28, 2021, 2:48 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 2:48 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 2:48 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 28, 2021, 2:48 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 2:48 p.m.
W291 trailing whitespace	reviewbot	March 28, 2021, 2:48 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 4:04 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 4:04 p.m.
W293 blank line contains whitespace	reviewbot	March 28, 2021, 4:04 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/status.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/status.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/status.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```
rbtools/commands/tests/test_main.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/tests/test_main.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_main.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```

The issue has been resolved. Show all issues

The diff of this includes the changes from your other review request.

You probably want to post and explicitly specify which commits you want to include. For example, to include just the latest two commits:

rbt post -r 11541 HEAD^^..HEAD

If you have two branch tips, you can also do:

rbt post -r 11541 json-branch..json-status-branch

Commits:

	Summary	ID
	added JSON wrapper class to main.py which inputs to a dictionary and outputs a JSON object. Added tests for JSON wrapper functionality in test_main.py	9bfcd1b986f5b42603b0809c7d78b638f6cee848
	added new method to print JSON to stream object and tests to ensure it works properly	fbd48ac58a17e2f8d9feb7a219f66d061eed989c
	added new global command --json	9cf5b3f5bb931691494dfb7922a5a0c910ea8a2d
	added conditional at the end of command cycle to print JSON is enabled	2876f2452d8b0655055e362ef6684de8b8e32ae7
	added method to append to classes and tests to ensure items are appended correctly	bcf004f831c02cbb35dfb5dc3d61b5e3406af2b5
	added new method to add errors to existing errors key or create a new one	195b6bf5193604d04511431c6761790a033fb74f
	each summary is added as a json object to a list in summaries	0972da07e52fc7a97b1afd350a473f451476441c
	moved definition of summaries to before if statement so that if no requests are found, there still exists a summaries key	1279e6b76c47cc0091fd769275a778b412875817
	each summary is added as a json object to a list in summaries	0972da07e52fc7a97b1afd350a473f451476441c
	moved definition of summaries to before if statement so that if no requests are found, there still exists a summaries key	1279e6b76c47cc0091fd769275a778b412875817

Diff:

Revision 2 (+31 -5)

Show changes

rbtools/commands/status.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/status.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/status.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/status.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Commits:

	Summary	ID
	each summary is added as a json object to a list in summaries	0972da07e52fc7a97b1afd350a473f451476441c
	moved definition of summaries to before if statement so that if no requests are found, there still exists a summaries key	1279e6b76c47cc0091fd769275a778b412875817
	fixed extra spaces in no line	fdd6fb0a9012ca7319a6c30f953f3a78542a013d

Diff:

Revision 3 (+6 -6)

Show changes

rbtools/commands/status.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	fixed extra spaces in no line	fdd6fb0a9012ca7319a6c30f953f3a78542a013d
	each summary is added as a json object to a list in summaries	0972da07e52fc7a97b1afd350a473f451476441c
	moved definition of summaries to before if statement so that if no requests are found, there still exists a summaries key	1279e6b76c47cc0091fd769275a778b412875817
	fixed extra spaces in no line	fdd6fb0a9012ca7319a6c30f953f3a78542a013d

Diff:

Revision 4 (+32 -6)

Show changes

rbtools/commands/status.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	each summary is added as a json object to a list in summaries	0972da07e52fc7a97b1afd350a473f451476441c
	moved definition of summaries to before if statement so that if no requests are found, there still exists a summaries key	1279e6b76c47cc0091fd769275a778b412875817
	fixed extra spaces in no line	fdd6fb0a9012ca7319a6c30f953f3a78542a013d
	each summary is added as a json object to a list in summaries	0972da07e52fc7a97b1afd350a473f451476441c
	moved definition of summaries to before if statement so that if no requests are found, there still exists a summaries key	1279e6b76c47cc0091fd769275a778b412875817
	fixed extra spaces in no line	fdd6fb0a9012ca7319a6c30f953f3a78542a013d

Diff:

Revision 5 (+32 -6)

Show changes

rbtools/commands/status.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

~		Depends on JSON wrapper object from r#11521. Adding information
	~	Depends on JSON output object from r#11521. Adding information
		that goes into rows of the status table into a JSON object. If no requests
		are found the array remains empty. Also adds `info` if format_results is
		called.

Commits:

	Summary	ID
	each summary is added as a json object to a list in summaries	0972da07e52fc7a97b1afd350a473f451476441c
	moved definition of summaries to before if statement so that if no requests are found, there still exists a summaries key	1279e6b76c47cc0091fd769275a778b412875817
	fixed extra spaces in no line	fdd6fb0a9012ca7319a6c30f953f3a78542a013d
	each summary is added as a json object to a list in summaries	97a2d1bff9fdc8242767a16b30b67fe86072bbd6
	moved definition of summaries to before if statement so that if no requests are found, there still exists a summaries key	255f82782e54cd54b20e8a96fe76efe51568a958
	fixed extra spaces in no line	51e7d7939e95b6e64640a56d62b35be529f6ebaf
	Removed setting status because it is done in __init__ by checking for errosr	637621991f2bdda5365afc61e7b60b2921843e13

Diff:

Revision 6 (+30 -8)

Show changes

rbtools/commands/status.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	[WIP] JSON Output for RBTools Status Command
+	JSON Output for RBTools Status Command

Commits:

	Summary	ID
	each summary is added as a json object to a list in summaries	97a2d1bff9fdc8242767a16b30b67fe86072bbd6
	moved definition of summaries to before if statement so that if no requests are found, there still exists a summaries key	255f82782e54cd54b20e8a96fe76efe51568a958
	fixed extra spaces in no line	51e7d7939e95b6e64640a56d62b35be529f6ebaf
	Removed setting status because it is done in __init__ by checking for errosr	637621991f2bdda5365afc61e7b60b2921843e13
	added new method to print JSON to stream object and tests to ensure it works properly	25df4d28942b92a8a571329ce54f43e57b46c8bc
	each summary is added as a json object to a list in summaries	675fa33dbdf470e4495e932a90482bacab2ead93
	moved definition of summaries to before if statement so that if no requests are found, there still exists a summaries key	3d10681f8240fa5053af5dad2e1648db8bede9b3
	fixed extra spaces in no line	46632b15806c44edddf1bfc46fc56b7bfa3d62a7
	Removed setting status because it is done in __init__ by checking for errosr	592bf7da19c2e27eeea64dfa0adae7252953d0ff
	Importing kgb instead of specific package inside kgb	b06f922afd219110b044a97519632fd6ae919458

Depends On:

+	~~11521 - JSON wrapper which inputs to a dictionary and outputs a JSON object~~

Groups:

+	students

Diff:

Revision 7 (+34 -12)

Show changes

rbtools/commands/status.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to master (82a7118)

rbtools/commands/status.py (Diff revision 1)

rbtools/commands/status.py (Diff revision 1)

rbtools/commands/status.py (Diff revision 1)

rbtools/commands/status.py (Diff revision 2)