JSON Output for RBTools Land Command

Review Request #11572 — Created April 4, 2021 and submitted

ryankang
RBTools
master
11521
rbtools, students

Depends on JSON output object from r#11521.

JSON object includes:

type: whether Land performed as squash or merge
source_branch: branch landing from
destination_branch: branch landing to
review_request: If not source branch, id of review_request being landed

Ran unit tests in Commands and passed all tests

Summary
Added review_request.id, source_branch, destination_branch, and type to JSON object
Adding additional JSON key value pairs at each output
Fixed line length too long issue in land.py
Description From Last Updated

E501 line too long (80 > 79 characters)

reviewbotreviewbot
ryankang
Review request changed

Summary:

-[WIP] JSON Output for RBTools Land Command
+JSON Output for RBTools Land Command

Commits:

Summary
-
Added review_request.id, source_branch, destination_branch, and type to JSON object
+
Added review_request.id, source_branch, destination_branch, and type to JSON object
+
Adding additional JSON key value pairs at each output

Depends On:

+11521 - JSON wrapper which inputs to a dictionary and outputs a JSON object

Groups:

+students

Diff:

Revision 2 (+36 -14)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

ryankang
ryankang
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (edf8b14)
Loading...