Summary:

JSON Output for RBTools Land Command

Review Request #11572 — Created April 4, 2021 and submitted Oct. 25, 2021, 9:38 p.m.

Information
Owner:	ryankang
Repository:	RBTools
Branch:	master
Bugs:
Depends On:	~~11521~~
Reviewers
Groups:	rbtools, students
People:

Description

Depends on JSON output object from r#11521.

JSON object includes:

type: whether Land performed as squash or merge
source_branch: branch landing from
destination_branch: branch landing to
review_request: If not source branch, id of review_request being landed

Testing Done

Ran unit tests in Commands and passed all tests

Commits

Summary
Added review_request.id, source_branch, destination_branch, and type to JSON object
Adding additional JSON key value pairs at each output
Fixed line length too long issue in land.py

Screenshots

Issues

Description	From	Last Updated
E501 line too long (80 > 79 characters)	reviewbot	April 11, 2021, 10:57 a.m.

flake8 passed.

JSHint passed.

Summary:

-	[WIP] JSON Output for RBTools Land Command
+	JSON Output for RBTools Land Command

Commits:

Summary

Added review_request.id, source_branch, destination_branch, and type to JSON object

Added review_request.id, source_branch, destination_branch, and type to JSON object

Adding additional JSON key value pairs at each output

Depends On:

+	~~11521 - JSON wrapper which inputs to a dictionary and outputs a JSON object~~

Groups:

+	students

Diff:

Revision 2 (+36 -14)

Show changes

rbtools/commands/land.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/land.py (Diff revision 2)
Show all issues
```
E501 line too long (80 > 79 characters)
```

Commits:

	Summary
-	Added review_request.id, source_branch, destination_branch, and type to JSON object
-	Adding additional JSON key value pairs at each output
+	Added review_request.id, source_branch, destination_branch, and type to JSON object
+	Adding additional JSON key value pairs at each output
+	Fixed line length too long issue in land.py

Diff:

Revision 3 (+39 -15)

Show changes

rbtools/commands/land.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to master (edf8b14)

rbtools/commands/land.py (Diff revision 2)