This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (4aed9cd)

Summary

Fix log messages

Review Request #9650 — Created Feb. 16, 2018 and submitted 7 years, 1 month ago

Information

Owner

solarmist*

Repository

RBTools

Branch

master

Bugs

Depends On

~~9649~~

Commit

3ec8f9d...

Reviewers

Groups

rbtools

People

Description*

Fix log messages

log message do the formatting for you, so there's no need to use % in these.

Testing Done

All tests passed in python 2.7

Description	From	Last Updated
There are no open issues

flake8 passed.

JSHint passed.

Description:: Fix log messages
+
+
https://reviews.reviewboard.org/r/9648/
+ https://reviews.reviewboard.org/r/9649/
+ https://reviews.reviewboard.org/r/9650/
+ https://reviews.reviewboard.org/r/9651/
+ https://reviews.reviewboard.org/r/9652/
+ https://reviews.reviewboard.org/r/9653/
+ https://reviews.reviewboard.org/r/9654/
+ https://reviews.reviewboard.org/r/9655/
Depends On:: ~~9648 - Fix exception handling, and update imports~~
~~9649 - Make six use consistant.~~
~~9650 - Fix log messages~~
~~9651 - Make quote use consistent across repo~~
~~9652 - Fix various things for python 3 compatibility~~
~~9653 - Refactor encode_multipart_formdata and tests to be easier to read and maintain~~
~~9654 - Fix unit tests to not pollute the test directories of other tests.~~
~~9655 - Fix various PEP 8, style and PyFlakes issues~~

Description:

		Fix log messages

~		https://reviews.reviewboard.org/r/9648/
	~	log message do the formatting for you, so there's no need to use % in these.
-		https://reviews.reviewboard.org/r/9649/
-		https://reviews.reviewboard.org/r/9650/
-		https://reviews.reviewboard.org/r/9651/
-		https://reviews.reviewboard.org/r/9652/
-		https://reviews.reviewboard.org/r/9653/
-		https://reviews.reviewboard.org/r/9654/
-		https://reviews.reviewboard.org/r/9655/

Depends On:

~~9650 - Fix log messages~~

Commit:

f96bf12f5509de135543ed266812df7f40f02c10

13d187d815f02037d6060ab11db3b84f98133ccd

Diff:

Revision 2 (+48 -51)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/clients/__init__.py
	rbtools/clients/clearcase.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/plastic.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Could you rebase this onto the latest master branch? There are some conflicts.

It would also be helpful if you could updated the "Depends On" field for all of these to indicate the order in which they should be applied. Right now everything depends on everything else so I don't know which things should be reviewed/landed first.

Testing Done:

~		Not sure what to put here since these intermediate commits don't pass tests or flake8.
	~	All tests passed in python 2.7

Depends On:

~~9648 - Fix exception handling, and update imports~~

~~9651 - Make quote use consistent across repo~~

~~9652 - Fix various things for python 3 compatibility~~

~~9653 - Refactor encode_multipart_formdata and tests to be easier to read and maintain~~

~~9654 - Fix unit tests to not pollute the test directories of other tests.~~

~~9655 - Fix various PEP 8, style and PyFlakes issues~~

Commit:

13d187d815f02037d6060ab11db3b84f98133ccd

3ec8f9d4fb6d19f8f60f02364aaf0127ee403d13

Diff:

Revision 3 (+40 -40)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/clients/__init__.py
	rbtools/clients/clearcase.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/plastic.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (4aed9cd)