Validate commits before posting

Review Request #9921 — Created May 9, 2018 and updated

brennie
RBTools
master
9920
10100
7123760...
rbtools

RBTools now supports the commit validation resource introduced in
/r/9920/. We now post all commits to the validation API before posting
them to the draft commit API for publishing.

Ran unit tests.
Posted this review request.
Posted /r/9609/ through to /r/9920/ to a single review request with history.

  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
david
  1. 
      
  2. rbtools/commands/post.py (Diff revision 1)
     
     
     

    This seems like verbose output. Do we need to show it all?

    If it's not near-instantaneous and we want some feedback, we do already pull in tqdm as a dependency, which would let us show a nifty progress bar.

  3. rbtools/commands/post.py (Diff revision 1)
     
     

    they -> it

  4. rbtools/commands/post.py (Diff revision 1)
     
     
     

    Having both "validating" and "validated" printed to the log output seems verbose (even with debug turned on).

  5. 
      
brennie
Review request changed

Change Summary:

Use TQDM to show a progress bar.

Commit:

-a3f6fe70e98b5d68eda1ce04638b00b431937378
+7123760bfd3affc7ee3f9a5979ab7952e561f731

Diff:

Revision 2 (+189 -54)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...