Post review requests with history when supported

Review Request #9911 — Created May 4, 2018 and updated

brennie
RBTools
master
ea75b0c...
rbtools

When the Review Board server has the review_request.supports_history
capability, we will default to posting with history. Using history can
be forced with the new -H/--with-history flag, which will cause an
error if the server does not support it.

Traditional-style squashed review requests are still supported: they can
be posted with -S/--squash-history.

Review requests that were created with history will always be updated
with history and review requests not created with history will,
likewise, never be updated with history. Since review requests in
Review Board exist in one state or the other, attempting to post would
result in an error, so we do not let users attempt such posts.

If the server does not support history, the -S and -H options are
ignored.

Posted this review request.
Posted a review request with multiple commits to my devserver.

  • 0
  • 0
  • 14
  • 0
  • 14
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

brennie
david
  1. 
      
  2. rbtools/api/resource.py (Diff revision 2)
     
     

    Docstring?

  3. rbtools/clients/git.py (Diff revision 2)
     
     

    XXX is meaningless without some kind of detail. Why is this comment here?

    1. This was from a TODO comment to myself that accidentally got left in. Oopsie.

  4. rbtools/commands/post.py (Diff revision 2)
     
     

    typo: Attrirbutes

  5. rbtools/commands/post.py (Diff revision 2)
     
     

    commandline -> command line

  6. rbtools/commands/post.py (Diff revision 2)
     
     

    Creates or updates, and uploads -> Create or update, and upload

  7. rbtools/commands/post.py (Diff revision 2)
     
     

    Commandline -> Command line

  8. rbtools/commands/post.py (Diff revision 2)
     
     

    It was already like this, but commandline -> command line.

  9. rbtools/commands/post.py (Diff revision 2)
     
     

    Can we wrap the arg value in parens?

  10. rbtools/commands/post.py (Diff revision 2)
     
     

    commandline -> command line

  11. rbtools/commands/post.py (Diff revision 2)
     
     

    commandline -> command line

  12. rbtools/commands/post.py (Diff revision 2)
     
     
     

    Wrapping is a little weird here.

  13. 
      
brennie
brennie
brennie
Review request changed

Change Summary:

Include parent diff for first commit.

Commit:

-02cd04b60aef289049af8c39215bf1b28032178d
+ea75b0c4650d784adca7da9d4887e0d5edbc04bf

Diff:

Revision 5 (+818 -193)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...