Use ASCII progress bars in debug mode

Review Request #10100 — Created July 24, 2018 and discarded

brennie
RBTools
master
9921
rbtools

TQDM by default will use Unicode drawing characters if the terminal
supports it. However, when we don't need this in a debug setting and
avoid using these as they may be submitted as part of a bug report and
may not render correctly.

Ran the commands that use tqdm in --debug mode and saw ASCII bars.

  • 3
  • 0
  • 0
  • 0
  • 3
Description From Last Updated
The description doesn't read right. Feels like there's two different thoughts going on. chipx86 chipx86
Alphabetical order. chipx86 chipx86
It would be really nice to wrap all this. We are going to lose consistency very fast if every caller ... chipx86 chipx86
chipx86
  1. 
      
  2. The description doesn't read right. Feels like there's two different thoughts going on.

  3. rbtools/commands/install.py (Diff revision 1)
     
     
     
     

    Alphabetical order.

  4. rbtools/commands/install.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     

    It would be really nice to wrap all this. We are going to lose consistency very fast if every caller is having to be responsible for all this information.

    A def show_progress on the base class would be a good start.

  5. 
      
brennie
Review request changed

Status: Discarded

Loading...