Summary

Use ASCII progress bars in debug mode

Review Request #10100 — Created July 24, 2018 and discarded Aug. 20, 2018, 1:22 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

master

Bugs

Depends On

~~9921~~

Reviewers

Groups

rbtools

People

Description

TQDM by default will use Unicode drawing characters if the terminal
supports it. However, when we don't need this in a debug setting and
avoid using these as they may be submitted as part of a bug report and
may not render correctly.

Testing Done

Ran the commands that use tqdm in --debug mode and saw ASCII bars.

Issues

Description	From	Last Updated
The description doesn't read right. Feels like there's two different thoughts going on.	chipx86	Aug. 17, 2018, 4:46 p.m.
Alphabetical order.	chipx86	Aug. 17, 2018, 4:46 p.m.
It would be really nice to wrap all this. We are going to lose consistency very fast if every caller …	chipx86	Aug. 17, 2018, 4:46 p.m.

flake8 passed.

JSHint passed.

Fix it!

An issue was opened. Show all issues

The description doesn't read right. Feels like there's two different thoughts going on.

rbtools/commands/install.py (Diff revision 1)
An issue was opened. Show all issues
```
Alphabetical order.
```

rbtools/commands/install.py (Diff revision 1)

An issue was opened. Show all issues

It would be really nice to wrap all this. We are going to lose consistency very fast if every caller is having to be responsible for all this information.
A def show_progress on the base class would be a good start.

Status:: Discarded