Support the new API workflow for posting commit series
Review Request #10240 — Created Oct. 18, 2018 and submitted
RBTools now uploads a cumulative diff of the entire commit series after
all commits have been uploaded so (a) Review Board can have a copy of
this diff instead of generating it and (b) Review Board can validate
the uploaded commits fully represent the range uploaded.
Posted a commit series for review and then published it. It worked!
Description | From | Last Updated |
---|---|---|
Leftover debug output? |
|
|
Can you add something like: if isinstance(cumulative_diff, bytes): raise TypeError('cumulative_diff must be a byte string, not %s' % type(cumulative_diff)) |
|
|
Same here. |
|
|
Should this be bytes? |
|
|
This should be a Unicode string. |
|
|
Parameter validation should be done at the top of the function, before we do anything else. |
|
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+58 -15) |
Checks run (2 succeeded)
Change Summary:
Addressed feedback
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+57 -15) |
Checks run (2 succeeded)
-
-
rbtools/api/resource.py (Diff revision 3) Can you add something like:
if isinstance(cumulative_diff, bytes): raise TypeError('cumulative_diff must be a byte string, not %s' % type(cumulative_diff))
-
-
Change Summary:
Addressed feedback.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+65 -15) |
Checks run (2 succeeded)
-
-
-
rbtools/api/resource.py (Diff revision 4) Parameter validation should be done at the top of the function, before we do anything else.
Change Summary:
Addressed feedback
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+65 -15) |