Rbslack with Integration framework

Review Request #7221 - Created April 17, 2015 and discarded

Xuanyi Lin
rb-extension-pack
master
6918, 7105, 7136, 7106
rb-extension-pack, students

This is a simple reimplementation of rbslack extension with the integration framework. This allow multiple instance of the integration, with different configuration for different channels. A custom form and template is also added for the configure integration page.

Additionally, it also allow the user to configure the integration such that the channel will only receive notification if the review request is intended for the selected groups.

Lastly, the integration can be configure to target a local site. Notification will only be send to Slack if the review belongs to the particular local site.

Manual testing with different configuration and different review's update.

  • No local site and group
  • Target a single group
  • Target multiple groups
  • Local site
  • Local site with groups
  • Multiple Slack integration.
  • 12
  • 0
  • 18
  • 0
  • 30
Description From Last Updated
All functions that take integration as the first parameter should probably be member functions of the integration class if they're ... Barret Rennie Barret Rennie
This comment should be just above the local_site_reverse('user', ...) call. David Trowbridge David Trowbridge
This should all fit on one line. David Trowbridge David Trowbridge
We should use something other than type, which is a reserved word. David Trowbridge David Trowbridge
Mark for translation. David Trowbridge David Trowbridge
Mark for translation. David Trowbridge David Trowbridge
This should probably just be a couple paragraphs rather than a list. David Trowbridge David Trowbridge
Mark for translation. David Trowbridge David Trowbridge
Mark for translation. David Trowbridge David Trowbridge
Mark for translation. David Trowbridge David Trowbridge
Mark for translation. David Trowbridge David Trowbridge
Mark for translation. David Trowbridge David Trowbridge
Review Bot
Xuanyi Lin
Review Bot
Barret Rennie
Xuanyi Lin
Review Bot
Review Bot
Barret Rennie
Xuanyi Lin
Review Bot
Xuanyi Lin
Review Bot
Xuanyi Lin
David Trowbridge
Christian Hammond
Review request changed

Status: Discarded

Change Summary:

Discarded in favor of the new rbintegrations package, containing Slack.

Loading...