Webapi Resource for integrations

Review Request #7105 - Created March 23, 2015 and discarded

Xuanyi Lin
Review Board
master
6918
7221, 7136, 7106
reviewboard, students

This provides the webapi resource and the views for the integration admin page.

The webapi resource for both Integration and ConfiguredIntegration are provided here. The Integration resource allows for getting the list of Integrations that implements the class and hook defined in review 6918.

The ConfiguredIntegration resource allows GET, PUT and DELETE call to manage individual configured integration.

Unit test done.
Tested with WebapiResource test for both integrations and configuredIntegration resource.

  • 12
  • 23
  • 2
  • 37
Description From Last Updated
No blank line here. David Trowbridge David Trowbridge
All str in here should be six.text_type for future Python 3 compatibility. Here and below. David Trowbridge David Trowbridge
I think I'd prefer if these conditionals were switched: if config and config.integration: return config.integration.name else: return None David Trowbridge David Trowbridge
Same as above. David Trowbridge David Trowbridge
Same as above. David Trowbridge David Trowbridge
Same as above. David Trowbridge David Trowbridge
This should have a docstring. David Trowbridge David Trowbridge
This should have a docstring. David Trowbridge David Trowbridge
No blank line here. David Trowbridge David Trowbridge
All str items in here should be six.text_type David Trowbridge David Trowbridge
Please switch the conditional to test if integration: and return None in the else clause. David Trowbridge David Trowbridge
This should have a docstring. David Trowbridge David Trowbridge
Review Bot
Xuanyi Lin
Review Bot
Xuanyi Lin
Review Bot
Xuanyi Lin
Review Bot
Xuanyi Lin
Review Bot
Xuanyi Lin
Review Bot
Barret Rennie
Xuanyi Lin
Review Bot
Barret Rennie
Xuanyi Lin
Review Bot
David Trowbridge
Xuanyi Lin
Review request changed

Status: Discarded

Change Summary:

Closed in favor of a revised version of Integrations that landed for 3.0.

Loading...