Integration admin page

Review Request #7106 — Created March 23, 2015 and discarded

Information

Review Board
master

Reviewers

The integration admin page provides a single interface to manage all the configured integrations. Admmin user can add, delete, change or toggle the state of the integration through this interface. On this page, the admin user will get to see all the configured integrations within the user's permission settings. Each of these integrations will be group according to their integration type, with a simple description and possible actions.

All of the interaction are achieved through the backbone model, which relies on the integration WebApiResource.

Unit test done.

Manual testing on the integration page.

  • Toggle of state
  • Delete of integration
  • Multiple integration class
  • Single integration class

Description From Last Updated

"Respresents" Also, maybe capitalize integration

CR cristocrat

"... an integration class"

CR cristocrat

maybe get rid of the first "the"

CR cristocrat

maybe reword to: "... ConfiguredIntegration object, which provides enabling or disabling of the instance."

CR cristocrat

provides (with an s)

CR cristocrat

provides (with an s)

CR cristocrat

Maybe capitalize integration

CR cristocrat

"It will also provide a link to create a new instance of this"

CR cristocrat

"This will load a configured..."

CR cristocrat

"...objects that belong to..."

CR cristocrat

"Displays a configured integration in a Manage Integration list."

CR cristocrat

will with two l's "...deleting of the instance."

CR cristocrat

"This destroys..." "... by calling HTTP DLETE..."

CR cristocrat

destroy typo

CR cristocrat

This should use RB.BaseResource, which handles URLs, parsing, etc.

daviddavid

I doubt we want to append another period--all the error strings in webapi/errors.py have text that ends in a period.

daviddavid

I doubt we want to append another period--all the error strings in webapi/errors.py have text that ends in a period.

daviddavid

This should use RB.BaseResource, which handles URLs, parsing, etc.

daviddavid

The "Add" text should be passed in as a variable, and run through gettext().

daviddavid

This text should be passed in and run through gettext().

daviddavid

This text should be run through gettext().

daviddavid

We shouldn't add another period.

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
  2. 
      
XU
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
  2. 
      
XU
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
  2. 
      
CR
  1. Code looks good! Just a few typos in the doc strings

  2. Show all issues

    "Respresents"

    Also, maybe capitalize integration

  3. Show all issues

    "... an integration class"

  4. Show all issues

    maybe get rid of the first "the"

  5. Show all issues

    maybe reword to:

    "... ConfiguredIntegration object, which provides enabling or disabling of the instance."

  6. Show all issues

    provides (with an s)

  7. Show all issues

    provides (with an s)

  8. Show all issues

    Maybe capitalize integration

  9. Show all issues

    "It will also provide a link to create a new instance of this"

  10. Show all issues

    "This will load a configured..."

  11. Show all issues

    "...objects that belong to..."

  12. Show all issues

    "Displays a configured integration in a Manage Integration list."

  13. Show all issues

    will with two l's

    "...deleting of the instance."

  14. Show all issues

    "This destroys..." "... by calling HTTP DLETE..."

  15. Show all issues

    destroy typo

  16. 
      
XU
XU
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
  2. 
      
XU
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
  2. 
      
XU
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
  2. 
      
XU
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/templates/integrations/integration_list.html
        reviewboard/templates/admin/base_site.html
        reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
        reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    
    
  2. 
      
david
  1. 
      
  2. Show all issues

    This should use RB.BaseResource, which handles URLs, parsing, etc.

  3. Show all issues

    I doubt we want to append another period--all the error strings in webapi/errors.py have text that ends in a period.

  4. Show all issues

    I doubt we want to append another period--all the error strings in webapi/errors.py have text that ends in a period.

  5. Show all issues

    This should use RB.BaseResource, which handles URLs, parsing, etc.

  6. Show all issues

    The "Add" text should be passed in as a variable, and run through gettext().

  7. Show all issues

    This text should be passed in and run through gettext().

  8. Show all issues

    This text should be run through gettext().

  9. Show all issues

    We shouldn't add another period.

  10. 
      
XU
Review request changed
Status:
Discarded
Change Summary:

Closed in favor of a revised version of Integrations that landed for 3.0.