Integration admin page
Review Request #7106 — Created March 23, 2015 and discarded
| Information | |
|---|---|
| xuanyi | |
| Review Board | |
| master | |
|
|
|
| 7221, 7136 | |
| Reviewers | |
| reviewboard, students | |
The integration admin page provides a single interface to manage all the configured integrations. Admmin user can add, delete, change or toggle the state of the integration through this interface. On this page, the admin user will get to see all the configured integrations within the user's permission settings. Each of these integrations will be group according to their integration type, with a simple description and possible actions.
All of the interaction are achieved through the backbone model, which relies on the integration WebApiResource.
Unit test done.
Manual testing on the integration page.
- Toggle of state
- Delete of integration
- Multiple integration class
- Single integration class
| Description | From | Last Updated |
|---|---|---|
|
"Respresents" Also, maybe capitalize integration |
CR cristocrat | |
|
"... an integration class" |
CR cristocrat | |
|
maybe get rid of the first "the" |
CR cristocrat | |
|
maybe reword to: "... ConfiguredIntegration object, which provides enabling or disabling of the instance." |
CR cristocrat | |
|
provides (with an s) |
CR cristocrat | |
|
provides (with an s) |
CR cristocrat | |
|
Maybe capitalize integration |
CR cristocrat | |
|
"It will also provide a link to create a new instance of this" |
CR cristocrat | |
|
"This will load a configured..." |
CR cristocrat | |
|
"...objects that belong to..." |
CR cristocrat | |
|
"Displays a configured integration in a Manage Integration list." |
CR cristocrat | |
|
will with two l's "...deleting of the instance." |
CR cristocrat | |
|
"This destroys..." "... by calling HTTP DLETE..." |
CR cristocrat | |
|
destroy typo |
CR cristocrat | |
|
This should use RB.BaseResource, which handles URLs, parsing, etc. |
 david
|
|
|
I doubt we want to append another period--all the error strings in webapi/errors.py have text that ends in a period. |
david
|
|
|
I doubt we want to append another period--all the error strings in webapi/errors.py have text that ends in a period. |
david
|
|
|
This should use RB.BaseResource, which handles URLs, parsing, etc. |
david
|
|
|
The "Add" text should be passed in as a variable, and run through gettext(). |
david
|
|
|
This text should be passed in and run through gettext(). |
david
|
|
|
This text should be run through gettext(). |
david
|
|
|
We shouldn't add another period. |
david
|
XU
-
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js
XU
Diff: |
Revision 3 (+602)
|
|---|
-
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js
CR
-
Code looks good! Just a few typos in the doc strings
-
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3) "Respresents"
Also, maybe capitalize integration
-
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3) "... an integration class"
-
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3) maybe get rid of the first "the"
-
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3) maybe reword to:
"... ConfiguredIntegration object, which provides enabling or disabling of the instance."
-
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3) provides (with an s)
-
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3) provides (with an s)
-
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3) Maybe capitalize integration
-
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3) "It will also provide a link to create a new instance of this"
-
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3) "This will load a configured..."
-
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3) "...objects that belong to..."
-
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3) "Displays a configured integration in a Manage Integration list."
-
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3) will with two l's
"...deleting of the instance."
-
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3) "This destroys..." "... by calling HTTP DLETE..."
-
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3) destroy typo
XU
Change Summary:
Update the description
Description: |
|
|---|
XU
Change Summary:
Fix comments for various methods
Diff: |
Revision 4 (+602)
|
|---|
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js
XU
Diff: |
Revision 5 (+602)
|
|---|
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js
XU
Diff: |
Revision 6 (+602)
|
|---|
-
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js
XU
Change Summary:
Clean up css
Diff: |
Revision 7 (+598)
|
|---|
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js
-
-
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 7) This should use RB.BaseResource, which handles URLs, parsing, etc.
-
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 7) I doubt we want to append another period--all the error strings in
webapi/errors.pyhave text that ends in a period. -
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 7) I doubt we want to append another period--all the error strings in
webapi/errors.pyhave text that ends in a period. -
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 7) This should use RB.BaseResource, which handles URLs, parsing, etc.
-
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 7) The "Add" text should be passed in as a variable, and run through
gettext(). -
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 7) This text should be passed in and run through
gettext(). -
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 7) This text should be run through
gettext(). -
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 7) We shouldn't add another period.
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/configure_integration.html reviewboard/templates/integrations/integration_list.html reviewboard/templates/admin/base_site.html reviewboard/static/rb/js/integrations/models/integrationManagerModel.js reviewboard/static/rb/js/integrations/views/integrationManagerView.js