Summary

Integration forms and config template

Review Request #7136 — Created March 30, 2015 and discarded April 28, 2016, 2:20 a.m.

Information

Owner

xuanyi

Repository

Review Board

Branch

master

Bugs

Depends On

~~6918~~, ~~7105~~, ~~7106~~

Blocks

7221

Reviewers

Groups

reviewboard, students

People

Description

This provides the integration forms class to manage the configuration of a integration in the configure page. The config template allows integration to display additional information in the configure integration page.
This form provides some preset form fields that are common for an integration. Integration could further customize the form for its own configuration by subclassing the integration forms.
The config template allows integration to provide a more detailed description, with extra content to simplify the process of setting up an integration.

Testing Done

Manual testing with a dummy integration.
Pass all unit test.

Files

Issues

Description	From	Last Updated
Sets -> Set	JY jyuen	April 13, 2015, 6:35 a.m.
Loads -> Load	JY jyuen	April 13, 2015, 6:35 a.m.
Saves -> Save	JY jyuen	April 13, 2015, 6:35 a.m.
Col: 80 E501 line too long (90 > 79 characters)	reviewbot	April 13, 2015, 6:35 a.m.
Creates -> Create	JY jyuen	April 13, 2015, 6:35 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	May 5, 2015, 7:49 p.m.
This should use super	david	May 19, 2015, 6:07 p.m.
This can be combined: try: return self.config.integration.default_configurations[key] except KeyError: raise KeyError(...)	david	May 19, 2015, 6:07 p.m.
Add another blank line here.	david	May 19, 2015, 6:07 p.m.
Add a trailing comma here.	david	May 19, 2015, 6:07 p.m.
Only one blank line here.	david	May 19, 2015, 6:07 p.m.
HTML should be single-space indented.	david	May 19, 2015, 6:07 p.m.
This should still be in a blocktrans. You can use blocktrans with to define the variable.	david	May 19, 2015, 6:07 p.m.
This should still be in a blocktrans. You can use blocktrans with to define the variable.	david	May 19, 2015, 6:07 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_configured_integration.py
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/configurations.py
    reviewboard/integrations/manager.py
    reviewboard/integrations/integration.py



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_configured_integration.py
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/configurations.py
    reviewboard/integrations/manager.py
    reviewboard/integrations/integration.py

reviewboard/integrations/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (90 > 79 characters)
```

Just some nitpicks for PEP-257 compliancy... :)

reviewboard/integrations/configurations.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Sets -> Set
```
reviewboard/integrations/configurations.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Loads -> Load
```
reviewboard/integrations/configurations.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Saves -> Save
```
reviewboard/webapi/tests/test_configured_integration.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Creates -> Create
```

Change Summary:

Fix issues from review

Testing Done:

Manual testing with a dummy integration.

Commit:

-	f1656f2503ade52ca9c328d139d6af06754eb4f1
+	c8d3d067d37fff56f94be3dea245fbe0968e227a

Diff:

Revision 2 (+141 -8)

Show changes

	reviewboard/integrations/configurations.py
	reviewboard/integrations/forms.py
	reviewboard/integrations/integration.py
	reviewboard/integrations/views.py
	reviewboard/templates/integrations/configure_integration.html

Tool: Pyflakes
Processed Files:
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/integration.py
    reviewboard/integrations/configurations.py

Ignored Files:
    reviewboard/templates/integrations/configure_integration.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/integration.py
    reviewboard/integrations/configurations.py

Ignored Files:
    reviewboard/templates/integrations/configure_integration.html

Summary:

-	[WIP] Integration forms and config template
+	Integration forms and config template

Description:

~		This provides the integration forms class to manage the configuration of a integration in the configure page.
	~	This provides the integration forms class to manage the configuration of a integration in the configure page. The config template allows integration to display additional information in the configure integration page.

Testing Done:

~		Manual testing with a dummy integration.
	~	Manual testing with a dummy integration.
	+	Pass all unit test.

Commit:

-	c8d3d067d37fff56f94be3dea245fbe0968e227a
+	487740d6f8af370734331b9cda8066a1ff915d9d

Diff:

Revision 3 (+174 -11)

Show changes

	reviewboard/integrations/configurations.py
	reviewboard/integrations/forms.py
	reviewboard/integrations/integration.py
	reviewboard/integrations/views.py
	reviewboard/static/rb/css/pages/integration.less
	reviewboard/templates/integrations/config_template.html
	reviewboard/templates/integrations/configure_integration.html

Added Files:

Tool: Pyflakes
Processed Files:
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/integration.py
    reviewboard/integrations/configurations.py

Ignored Files:
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/config_template.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/integration.py
    reviewboard/integrations/configurations.py

Ignored Files:
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/config_template.html

Description:

		This provides the integration forms class to manage the configuration of a integration in the configure page. The config template allows integration to display additional information in the configure integration page.
	+
	+	This form provides some preset form fields that are common for an integration. Integration could further customize the form for its own configuration by subclassing the integration forms.
	+
	+	The config template allows integration to provide a more detailed description, with extra content to simplify the process of setting up an integration.

Commit:

-	487740d6f8af370734331b9cda8066a1ff915d9d
+	cb4d3a3dd5b652578cc06b5f055753d5e34bc3ba

Diff:

Revision 4 (+175 -12)

Show changes

	reviewboard/integrations/configurations.py
	reviewboard/integrations/forms.py
	reviewboard/integrations/integration.py
	reviewboard/integrations/views.py
	reviewboard/static/rb/css/pages/integration.less
	reviewboard/templates/integrations/config_template.html
	reviewboard/templates/integrations/configure_integration.html

Tool: Pyflakes
Processed Files:
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/integration.py
    reviewboard/integrations/configurations.py

Ignored Files:
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/config_template.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/integration.py
    reviewboard/integrations/configurations.py

Ignored Files:
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/config_template.html

Commit:

-	cb4d3a3dd5b652578cc06b5f055753d5e34bc3ba
+	1ba3e404029cc412a0924904e07495fd05b1978a

Diff:

Revision 5 (+208 -13)

Show changes

	reviewboard/integrations/configurations.py
	reviewboard/integrations/forms.py
	reviewboard/integrations/integration.py
	reviewboard/integrations/views.py
	reviewboard/static/rb/css/pages/integration.less
	reviewboard/templates/integrations/config_template.html
	reviewboard/templates/integrations/configure_integration.html

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/integration.py
    reviewboard/integrations/configurations.py

Ignored Files:
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/config_template.html



Tool: Pyflakes
Processed Files:
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/integration.py
    reviewboard/integrations/configurations.py

Ignored Files:
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/config_template.html

reviewboard/integrations/forms.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```

Commit:

-	1ba3e404029cc412a0924904e07495fd05b1978a
+	2d7653cb3753a2492b32fffc7aa07a68df8127ee

Diff:

Revision 6 (+207 -13)

Show changes

	reviewboard/integrations/configurations.py
	reviewboard/integrations/forms.py
	reviewboard/integrations/integration.py
	reviewboard/integrations/views.py
	reviewboard/static/rb/css/pages/integration.less
	reviewboard/templates/integrations/config_template.html
	reviewboard/templates/integrations/configure_integration.html

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/integration.py
    reviewboard/integrations/configurations.py

Ignored Files:
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/config_template.html



Tool: Pyflakes
Processed Files:
    reviewboard/integrations/forms.py
    reviewboard/integrations/views.py
    reviewboard/integrations/integration.py
    reviewboard/integrations/configurations.py

Ignored Files:
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/config_template.html

Fix it!

reviewboard/integrations/configurations.py (Diff revision 6)
An issue was opened. Show all issues
```
This should use super
```

reviewboard/integrations/configurations.py (Diff revision 6)

An issue was opened. Show all issues

This can be combined:

try:
    return self.config.integration.default_configurations[key]
except KeyError:
    raise KeyError(...)

reviewboard/integrations/integration.py (Diff revision 6)
An issue was opened. Show all issues
```
Add another blank line here.
```
reviewboard/integrations/views.py (Diff revision 6)
An issue was opened. Show all issues
```
Add a trailing comma here.
```
reviewboard/static/rb/css/pages/integration.less (Diff revision 6)
An issue was opened. Show all issues
```
Only one blank line here.
```
reviewboard/templates/integrations/config_template.html (Diff revision 6)
An issue was opened. Show all issues
```
HTML should be single-space indented.
```
reviewboard/templates/integrations/configure_integration.html (Diff revision 6)
An issue was opened. Show all issues
```
This should still be in a blocktrans. You can use blocktrans with to define the variable.
```
reviewboard/templates/integrations/configure_integration.html (Diff revision 6)
An issue was opened. Show all issues
```
This should still be in a blocktrans. You can use blocktrans with to define the variable.
```

Status: Discarded

Change Summary:

Closed in favor of a revised version of Integrations that landed for 3.0.