Integration forms and config template
Review Request #7136 — Created March 30, 2015 and discarded
| Information | |
|---|---|
| xuanyi | |
| Review Board | |
| master | |
|
|
|
| 7221 | |
| Reviewers | |
| reviewboard, students | |
This provides the integration forms class to manage the configuration of a integration in the configure page. The config template allows integration to display additional information in the configure integration page.
This form provides some preset form fields that are common for an integration. Integration could further customize the form for its own configuration by subclassing the integration forms.
The config template allows integration to provide a more detailed description, with extra content to simplify the process of setting up an integration.
Manual testing with a dummy integration.
Pass all unit test.
| Description | From | Last Updated |
|---|---|---|
|
Sets -> Set |
JY jyuen | |
|
Loads -> Load |
JY jyuen | |
|
Saves -> Save |
JY jyuen | |
|
Col: 80 E501 line too long (90 > 79 characters) |
 reviewbot
|
|
|
Creates -> Create |
JY jyuen | |
|
Col: 9 E123 closing bracket does not match indentation of opening bracket's line |
reviewbot
|
|
|
This should use super |
 david
|
|
|
This can be combined: try: return self.config.integration.default_configurations[key] except KeyError: raise KeyError(...) |
david
|
|
|
Add another blank line here. |
david
|
|
|
Add a trailing comma here. |
david
|
|
|
Only one blank line here. |
david
|
|
|
HTML should be single-space indented. |
david
|
|
|
This should still be in a blocktrans. You can use blocktrans with to define the variable. |
david
|
|
|
This should still be in a blocktrans. You can use blocktrans with to define the variable. |
david
|
JY
-
Just some nitpicks for PEP-257 compliancy... :)
-
-
-
-
XU
Change Summary:
Fix issues from review
Testing Done: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+141 -8) |
-
Tool: Pyflakes Processed Files: reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/integration.py reviewboard/integrations/configurations.py Ignored Files: reviewboard/templates/integrations/configure_integration.html Tool: PEP8 Style Checker Processed Files: reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/integration.py reviewboard/integrations/configurations.py Ignored Files: reviewboard/templates/integrations/configure_integration.html
XU
Summary: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||
Testing Done: |
|
|||||||||
Commit: |
|
|||||||||
Diff: |
Revision 3 (+174 -11) |
|||||||||
Added Files: |
-
Tool: Pyflakes Processed Files: reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/integration.py reviewboard/integrations/configurations.py Ignored Files: reviewboard/templates/integrations/configure_integration.html reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/config_template.html Tool: PEP8 Style Checker Processed Files: reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/integration.py reviewboard/integrations/configurations.py Ignored Files: reviewboard/templates/integrations/configure_integration.html reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/config_template.html
XU
Description: |
|
|||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||
Diff: |
Revision 4 (+175 -12) |
-
Tool: Pyflakes Processed Files: reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/integration.py reviewboard/integrations/configurations.py Ignored Files: reviewboard/templates/integrations/configure_integration.html reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/config_template.html Tool: PEP8 Style Checker Processed Files: reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/integration.py reviewboard/integrations/configurations.py Ignored Files: reviewboard/templates/integrations/configure_integration.html reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/config_template.html
XU
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+208 -13) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/integration.py reviewboard/integrations/configurations.py Ignored Files: reviewboard/templates/integrations/configure_integration.html reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/config_template.html Tool: Pyflakes Processed Files: reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/integration.py reviewboard/integrations/configurations.py Ignored Files: reviewboard/templates/integrations/configure_integration.html reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/config_template.html -
reviewboard/integrations/forms.py (Diff revision 5) Col: 9 E123 closing bracket does not match indentation of opening bracket's line
XU
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 6 (+207 -13) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/integration.py reviewboard/integrations/configurations.py Ignored Files: reviewboard/templates/integrations/configure_integration.html reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/config_template.html Tool: Pyflakes Processed Files: reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/integration.py reviewboard/integrations/configurations.py Ignored Files: reviewboard/templates/integrations/configure_integration.html reviewboard/static/rb/css/pages/integration.less reviewboard/templates/integrations/config_template.html
-
-
-
reviewboard/integrations/configurations.py (Diff revision 6) This can be combined:
try: return self.config.integration.default_configurations[key] except KeyError: raise KeyError(...) -
-
-
-
reviewboard/templates/integrations/config_template.html (Diff revision 6) HTML should be single-space indented.
-
reviewboard/templates/integrations/configure_integration.html (Diff revision 6) This should still be in a blocktrans. You can use
blocktrans withto define the variable. -
reviewboard/templates/integrations/configure_integration.html (Diff revision 6) This should still be in a blocktrans. You can use
blocktrans withto define the variable.
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/test_configured_integration.py reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/configurations.py reviewboard/integrations/manager.py reviewboard/integrations/integration.py Tool: Pyflakes Processed Files: reviewboard/webapi/tests/test_configured_integration.py reviewboard/integrations/forms.py reviewboard/integrations/views.py reviewboard/integrations/configurations.py reviewboard/integrations/manager.py reviewboard/integrations/integration.py