Integration forms and config template

Review Request #7136 - Created March 30, 2015 and discarded

Xuanyi Lin
Review Board
master
6918, 7105, 7106
7221
reviewboard, students

This provides the integration forms class to manage the configuration of a integration in the configure page. The config template allows integration to display additional information in the configure integration page.

This form provides some preset form fields that are common for an integration. Integration could further customize the form for its own configuration by subclassing the integration forms.

The config template allows integration to provide a more detailed description, with extra content to simplify the process of setting up an integration.

Manual testing with a dummy integration.
Pass all unit test.

Loading file attachments...

  • 8
  • 0
  • 6
  • 0
  • 14
Description From Last Updated
This should use super David Trowbridge David Trowbridge
This can be combined: try: return self.config.integration.default_configurations[key] except KeyError: raise KeyError(...) David Trowbridge David Trowbridge
Add another blank line here. David Trowbridge David Trowbridge
Add a trailing comma here. David Trowbridge David Trowbridge
Only one blank line here. David Trowbridge David Trowbridge
HTML should be single-space indented. David Trowbridge David Trowbridge
This should still be in a blocktrans. You can use blocktrans with to define the variable. David Trowbridge David Trowbridge
This should still be in a blocktrans. You can use blocktrans with to define the variable. David Trowbridge David Trowbridge
Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/tests/test_configured_integration.py
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/configurations.py
        reviewboard/integrations/manager.py
        reviewboard/integrations/integration.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/tests/test_configured_integration.py
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/configurations.py
        reviewboard/integrations/manager.py
        reviewboard/integrations/integration.py
    
    
  2. reviewboard/integrations/forms.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (90 > 79 characters)
    
  3. 
      
Jessica Yuen
  1. Just some nitpicks for PEP-257 compliancy... :)

  2. Sets -> Set

  3. Loads -> Load

  4. Saves -> Save

  5. 
      
Xuanyi Lin
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
    
    
  2. 
      
Xuanyi Lin
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
  2. 
      
Xuanyi Lin
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
  2. 
      
Xuanyi Lin
Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
  2. reviewboard/integrations/forms.py (Diff revision 5)
     
     
    Col: 9
     E123 closing bracket does not match indentation of opening bracket's line
    
  3. 
      
Xuanyi Lin
Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
  2. 
      
David Trowbridge
  1. 
      
  2. This should use super

  3. reviewboard/integrations/configurations.py (Diff revision 6)
     
     
     
     
     
     
     
     
     

    This can be combined:

    try:
        return self.config.integration.default_configurations[key]
    except KeyError:
        raise KeyError(...)
    
  4. reviewboard/integrations/integration.py (Diff revision 6)
     
     

    Add another blank line here.

  5. reviewboard/integrations/views.py (Diff revision 6)
     
     

    Add a trailing comma here.

  6. Only one blank line here.

  7. HTML should be single-space indented.

  8. This should still be in a blocktrans. You can use blocktrans with to define the variable.

  9. This should still be in a blocktrans. You can use blocktrans with to define the variable.

  10. 
      
Xuanyi Lin
Review request changed

Status: Discarded

Change Summary:

Closed in favor of a revised version of Integrations that landed for 3.0.

Loading...