Integration forms and config template

Review Request #7136 — Created March 30, 2015 and discarded

Information

Review Board
master

Reviewers

This provides the integration forms class to manage the configuration of a integration in the configure page. The config template allows integration to display additional information in the configure integration page.

This form provides some preset form fields that are common for an integration. Integration could further customize the form for its own configuration by subclassing the integration forms.

The config template allows integration to provide a more detailed description, with extra content to simplify the process of setting up an integration.

Manual testing with a dummy integration.
Pass all unit test.


Description From Last Updated

Sets -> Set

JY jyuen

Loads -> Load

JY jyuen

Saves -> Save

JY jyuen

Col: 80 E501 line too long (90 > 79 characters)

reviewbotreviewbot

Creates -> Create

JY jyuen

Col: 9 E123 closing bracket does not match indentation of opening bracket's line

reviewbotreviewbot

This should use super

daviddavid

This can be combined: try: return self.config.integration.default_configurations[key] except KeyError: raise KeyError(...)

daviddavid

Add another blank line here.

daviddavid

Add a trailing comma here.

daviddavid

Only one blank line here.

daviddavid

HTML should be single-space indented.

daviddavid

This should still be in a blocktrans. You can use blocktrans with to define the variable.

daviddavid

This should still be in a blocktrans. You can use blocktrans with to define the variable.

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/tests/test_configured_integration.py
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/configurations.py
        reviewboard/integrations/manager.py
        reviewboard/integrations/integration.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/tests/test_configured_integration.py
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/configurations.py
        reviewboard/integrations/manager.py
        reviewboard/integrations/integration.py
    
    
  2. reviewboard/integrations/forms.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (90 > 79 characters)
    
  3. 
      
JY
  1. Just some nitpicks for PEP-257 compliancy... :)

  2. Show all issues

    Sets -> Set

  3. Show all issues

    Loads -> Load

  4. Show all issues

    Saves -> Save

  5. Show all issues

    Creates -> Create

  6. 
      
XU
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
    
    
  2. 
      
XU
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
  2. 
      
XU
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
  2. 
      
XU
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
  2. reviewboard/integrations/forms.py (Diff revision 5)
     
     
    Show all issues
    Col: 9
     E123 closing bracket does not match indentation of opening bracket's line
    
  3. 
      
XU
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/integrations/forms.py
        reviewboard/integrations/views.py
        reviewboard/integrations/integration.py
        reviewboard/integrations/configurations.py
    
    Ignored Files:
        reviewboard/templates/integrations/configure_integration.html
        reviewboard/static/rb/css/pages/integration.less
        reviewboard/templates/integrations/config_template.html
    
    
  2. 
      
david
  1. 
      
  2. Show all issues

    This should use super

  3. reviewboard/integrations/configurations.py (Diff revision 6)
     
     
     
     
     
     
     
     
     
    Show all issues

    This can be combined:

    try:
        return self.config.integration.default_configurations[key]
    except KeyError:
        raise KeyError(...)
    
  4. reviewboard/integrations/integration.py (Diff revision 6)
     
     
    Show all issues

    Add another blank line here.

  5. reviewboard/integrations/views.py (Diff revision 6)
     
     
    Show all issues

    Add a trailing comma here.

  6. Show all issues

    Only one blank line here.

  7. Show all issues

    HTML should be single-space indented.

  8. Show all issues

    This should still be in a blocktrans. You can use blocktrans with to define the variable.

  9. Show all issues

    This should still be in a blocktrans. You can use blocktrans with to define the variable.

  10. 
      
XU
Review request changed
Status:
Discarded
Change Summary:

Closed in favor of a revised version of Integrations that landed for 3.0.