Summary

Always opt-in to subqueries and join types for assertQueries().

Review Request #13434 — Created Nov. 26, 2023 and submitted Dec. 7, 2023, 1:33 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

~~13432~~, ~~13433~~, ~~13424~~

Reviewers

Groups

reviewboard

People

Description

Review Board's TestCase class now wraps assertQueries() and turns on

join type and subquery checks in order to ensure that we always test

with these features in all cases.
All affected equeries have been updated to include join_types

information. This includes the equery-building utility functions.
All assertQueries() calls that explicitly opted into these flags have

been converted to bare assertQueries() calls.

Testing Done

All unit tests pass.

Commits

Summary	ID
Always opt-in to subqueries and join types for assertQueries(). Review Board's `TestCase` class now wraps `assertQueries()` and turns on join type and subquery checks in order to ensure that we always test with these features in all cases. All affected equeries have been updated to include `join_types` information. This includes the equery-building utility functions. All `assertQueries()` calls that explicitly opted into these flags have been converted to bare `assertQueries()` calls.	7b7df2e0ec82d7eb33ae70b1c5684f5e4856ca8c

Summary

Always opt-in to subqueries and join types for assertQueries().

Review Board's `TestCase` class now wraps `assertQueries()` and turns on join type and subquery checks in order to ensure that we always test with these features in all cases. All affected equeries have been updated to include `join_types` information. This includes the equery-building utility functions. All `assertQueries()` calls that explicitly opted into these flags have been converted to bare `assertQueries()` calls.

7b7df2e0ec82d7eb33ae70b1c5684f5e4856ca8c

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (dcb9034)