Always opt-in to subqueries and join types for assertQueries().

Review Request #13434 — Created Nov. 26, 2023 and submitted

Information

Review Board
release-5.0.x

Reviewers

Review Board's TestCase class now wraps assertQueries() and turns on
join type and subquery checks in order to ensure that we always test
with these features in all cases.

All affected equeries have been updated to include join_types
information. This includes the equery-building utility functions.

All assertQueries() calls that explicitly opted into these flags have
been converted to bare assertQueries() calls.

All unit tests pass.

Summary ID
Always opt-in to subqueries and join types for assertQueries().
Review Board's `TestCase` class now wraps `assertQueries()` and turns on join type and subquery checks in order to ensure that we always test with these features in all cases. All affected equeries have been updated to include `join_types` information. This includes the equery-building utility functions. All `assertQueries()` calls that explicitly opted into these flags have been converted to bare `assertQueries()` calls.
7b7df2e0ec82d7eb33ae70b1c5684f5e4856ca8c
david
  1. Ship It!
  2. 
      
maubin
  1. 
      
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.0.x (dcb9034)