Add support for matching join types in equeries.

Review Request #13424 — Created Nov. 18, 2023 and submitted

Information

Djblets
release-3.x

Reviewers

This introduces a join_types field for equeries, which helps
instrument join types (such as INNER vs. OUTER JOINs). That can be
useful in ensuring that queries are joining in a way that the developers
expect, which can have an impact on results.

This is off by default, for compatibility. If a mismatch would have been
reported, then a warning will be issued advising the developer to opt in
and that it will be made the default in a future version.

There's also a fix for formatting sets, ensuring they're both sorted
and pretty-printed.

Unit tests pass.

Made use of this in some in-progress tests.

Summary ID
Add support for matching join types in equeries.
This introduces a `join_types` field for equeries, which helps instrument join types (such as INNER vs. OUTER JOINs). That can be useful in ensuring that queries are joining in a way that the developers expect, which can have an impact on results. This is off by default, for compatibility. If a mismatch would have been reported, then a warning will be issued advising the developer to opt in and that it will be made the default in a future version.
39a8aab653ca7aa5d5689e13e365e5887ba780bd
Description From Last Updated

'djblets.deprecation.RemovedInDjblets50Warning' imported but unused Column: 1 Error code: F401

reviewbotreviewbot

dictionary key '_unchecked_mismatched_attrs' repeated with different values Column: 17 Error code: F601

reviewbotreviewbot

dictionary key '_unchecked_mismatched_attrs' repeated with different values Column: 17 Error code: F601

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
chipx86
david
  1. Ship It!
  2. 
      
maubin
  1. 
      
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.x (92a25bf)