Summary

Add support for matching join types in equeries.

Review Request #13424 — Created Nov. 18, 2023 and submitted Dec. 2, 2023, 5:23 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Blocks

13434

Reviewers

Groups

djblets

People

Description

This introduces a join_types field for equeries, which helps
instrument join types (such as INNER vs. OUTER JOINs). That can be
useful in ensuring that queries are joining in a way that the developers
expect, which can have an impact on results.

This is off by default, for compatibility. If a mismatch would have been
reported, then a warning will be issued advising the developer to opt in
and that it will be made the default in a future version.

There's also a fix for formatting sets, ensuring they're both sorted
and pretty-printed.

Testing Done

Unit tests pass.

Made use of this in some in-progress tests.

Commits

Summary	ID
Add support for matching join types in equeries. This introduces a `join_types` field for equeries, which helps instrument join types (such as INNER vs. OUTER JOINs). That can be useful in ensuring that queries are joining in a way that the developers expect, which can have an impact on results. This is off by default, for compatibility. If a mismatch would have been reported, then a warning will be issued advising the developer to opt in and that it will be made the default in a future version.	39a8aab653ca7aa5d5689e13e365e5887ba780bd

Summary

Add support for matching join types in equeries.

This introduces a `join_types` field for equeries, which helps instrument join types (such as INNER vs. OUTER JOINs). That can be useful in ensuring that queries are joining in a way that the developers expect, which can have an impact on results. This is off by default, for compatibility. If a mismatch would have been reported, then a warning will be issued advising the developer to opt in and that it will be made the default in a future version.

39a8aab653ca7aa5d5689e13e365e5887ba780bd

Issues

Description	From	Last Updated
'djblets.deprecation.RemovedInDjblets50Warning' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 26, 2023, 10:03 p.m.
dictionary key '_unchecked_mismatched_attrs' repeated with different values Column: 17 Error code: F601	reviewbot	Nov. 26, 2023, 10:03 p.m.
dictionary key '_unchecked_mismatched_attrs' repeated with different values Column: 17 Error code: F601	reviewbot	Nov. 26, 2023, 10:03 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/db/query_comparator.py (Diff revision 1)

The issue has been resolved. Show all issues

'djblets.deprecation.RemovedInDjblets50Warning' imported but unused

Column: 1
Error code: F401

djblets/db/tests/test_query_comparator.py (Diff revision 1)

The issue has been resolved. Show all issues

dictionary key '_unchecked_mismatched_attrs' repeated with different values

Column: 17
Error code: F601

djblets/db/tests/test_query_comparator.py (Diff revision 1)

The issue has been resolved. Show all issues

dictionary key '_unchecked_mismatched_attrs' repeated with different values

Column: 17
Error code: F601

Change Summary:


Fixed table names appearing in join_types that aren't actually part of a true join (they were just considered for one internally).
Changed how opt-in and deprecation for this feature works.
Removed an unused import.
Fixed a duplicate key in a dictionary.

Commits:

	Summary	ID
	Add support for matching join types in equeries. This introduces a `join_types` field for equeries, which helps instrument join types (such as INNER vs. OUTER JOINs). That can be useful in ensuring that queries are joining in a way that the developers expect, which can have an impact on results. This is off by default, for compatibility. If a mismatch would have been reported, then a warning will be issued advising the developer to opt in and that it will be made the default in a future version.	109154d493bd90124cc03a0d1f7b70cef193141e
	Add support for matching join types in equeries. This introduces a `join_types` field for equeries, which helps instrument join types (such as INNER vs. OUTER JOINs). That can be useful in ensuring that queries are joining in a way that the developers expect, which can have an impact on results. This is off by default, for compatibility. If a mismatch would have been reported, then a warning will be issued advising the developer to opt in and that it will be made the default in a future version.	3e6c0ff3cfad126440b02b30bfb0f4665a87048d

Diff:

Revision 2 (+306 -20)

Show changes

	djblets/db/query_comparator.py
	djblets/db/tests/test_query_comparator.py
	djblets/testing/testcases.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed disabling join checks in subqueries.

Commits:

	Summary	ID
	Add support for matching join types in equeries. This introduces a `join_types` field for equeries, which helps instrument join types (such as INNER vs. OUTER JOINs). That can be useful in ensuring that queries are joining in a way that the developers expect, which can have an impact on results. This is off by default, for compatibility. If a mismatch would have been reported, then a warning will be issued advising the developer to opt in and that it will be made the default in a future version.	3e6c0ff3cfad126440b02b30bfb0f4665a87048d
	Add support for matching join types in equeries. This introduces a `join_types` field for equeries, which helps instrument join types (such as INNER vs. OUTER JOINs). That can be useful in ensuring that queries are joining in a way that the developers expect, which can have an impact on results. This is off by default, for compatibility. If a mismatch would have been reported, then a warning will be issued advising the developer to opt in and that it will be made the default in a future version.	39a8aab653ca7aa5d5689e13e365e5887ba780bd

Diff:

Revision 3 (+308 -20)

Show changes

	djblets/db/query_comparator.py
	djblets/db/tests/test_query_comparator.py
	djblets/testing/testcases.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

Status:: Completed
Change Summary:: Pushed to release-3.x (92a25bf)