Summary

Add permission lookup control and prep separation for equeries.

Review Request #13432 — Created Nov. 26, 2023 and submitted Dec. 7, 2023, 1:33 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Blocks

13434

Reviewers

Groups

reviewboard

People

Description

This splits out the permission lookups from the review group equeries
into get_user_permissions_equeries() in
reviewboard.accounts.testing.queries.

The review group and review request equeries have been updated to take
flags indicating whether permission lookup queries are expected. This
would be disabled if they've already been fetched by this point (since
they're cached).

There's a little bit of related cleanup in parts, changing where some
logic (e.g., superuser checks for review group access queries) lives and
better reusing state from expected Q results for prep equeries. These
will be important for upcoming changes.

Testing Done

All unit tests pass.

Commits

Summary	ID
Add permission lookup control and prep separation for equeries. This splits out the permission lookups from the review group equeries into `get_user_permissions_equeries()` in `reviewboard.accounts.testing.queries`. The review group and review request equeries have been updated to take flags indicating whether permission lookup queries are expected. This would be disabled if they've already been fetched by this point (since they're cached). There's a little bit of related cleanup in parts, changing where some logic (e.g., superuser checks for review group access queries) lives and better reusing state from expected Q results for prep equeries. These will be important for upcoming changes.	553f39eaad955d7e24df16cf13c8ea822ed9d125

Summary

Add permission lookup control and prep separation for equeries.

This splits out the permission lookups from the review group equeries into `get_user_permissions_equeries()` in `reviewboard.accounts.testing.queries`. The review group and review request equeries have been updated to take flags indicating whether permission lookup queries are expected. This would be disabled if they've already been fetched by this point (since they're cached). There's a little bit of related cleanup in parts, changing where some logic (e.g., superuser checks for review group access queries) lives and better reusing state from expected Q results for prep equeries. These will be important for upcoming changes.

553f39eaad955d7e24df16cf13c8ea822ed9d125

Issues

Description	From	Last Updated
'reviewboard.reviews.testing.queries.review_groups.get_review_groups_accessible_prep_equeries' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 26, 2023, 9:36 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/testing/queries/review_requests.py (Diff revision 1)

The issue has been resolved. Show all issues

'reviewboard.reviews.testing.queries.review_groups.get_review_groups_accessible_prep_equeries' imported but unused

Column: 1
Error code: F401

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Add permission lookup control and prep separation for equeries. This splits out the permission lookups from the review group equeries into `get_user_permissions_equeries()` in `reviewboard.accounts.testing.queries`. The review group and review request equeries have been updated to take flags indicating whether permission lookup queries are expected. This would be disabled if they've already been fetched by this point (since they're cached). There's a little bit of related cleanup in parts, changing where some logic (e.g., superuser checks for review group access queries) lives and better reusing state from expected Q results for prep equeries. These will be important for upcoming changes.	f8f4984e15350f2a7430dc88c380dab96d9f9b3a
	Add permission lookup control and prep separation for equeries. This splits out the permission lookups from the review group equeries into `get_user_permissions_equeries()` in `reviewboard.accounts.testing.queries`. The review group and review request equeries have been updated to take flags indicating whether permission lookup queries are expected. This would be disabled if they've already been fetched by this point (since they're cached). There's a little bit of related cleanup in parts, changing where some logic (e.g., superuser checks for review group access queries) lives and better reusing state from expected Q results for prep equeries. These will be important for upcoming changes.	553f39eaad955d7e24df16cf13c8ea822ed9d125

Diff:

Revision 2 (+246 -116)

Show changes

	reviewboard/accounts/testing/queries.py
	reviewboard/reviews/testing/queries/review_groups.py
	reviewboard/reviews/testing/queries/review_requests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (1c4cb12)