Add permission lookup control and prep separation for equeries.

Review Request #13432 — Created Nov. 26, 2023 and submitted

Information

Review Board
release-5.0.x

Reviewers

This splits out the permission lookups from the review group equeries
into get_user_permissions_equeries() in
reviewboard.accounts.testing.queries.

The review group and review request equeries have been updated to take
flags indicating whether permission lookup queries are expected. This
would be disabled if they've already been fetched by this point (since
they're cached).

There's a little bit of related cleanup in parts, changing where some
logic (e.g., superuser checks for review group access queries) lives and
better reusing state from expected Q results for prep equeries. These
will be important for upcoming changes.

All unit tests pass.

Summary ID
Add permission lookup control and prep separation for equeries.
This splits out the permission lookups from the review group equeries into `get_user_permissions_equeries()` in `reviewboard.accounts.testing.queries`. The review group and review request equeries have been updated to take flags indicating whether permission lookup queries are expected. This would be disabled if they've already been fetched by this point (since they're cached). There's a little bit of related cleanup in parts, changing where some logic (e.g., superuser checks for review group access queries) lives and better reusing state from expected Q results for prep equeries. These will be important for upcoming changes.
553f39eaad955d7e24df16cf13c8ea822ed9d125
Description From Last Updated

'reviewboard.reviews.testing.queries.review_groups.get_review_groups_accessible_prep_equeries' imported but unused Column: 1 Error code: F401

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
maubin
  1. 
      
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.0.x (1c4cb12)