Summary

Update API testing to use common equery functions.

Review Request #13433 — Created Nov. 26, 2023 and submitted Dec. 7, 2023, 1:33 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Blocks

13434

Reviewers

Groups

reviewboard

People

Description

The API unit tests now make use of some of the existing equery utility
functions, as well as providing a couple new functions for handling
incoming requests and outgoing responses.

This significantly reduces the code required for query assertions in the
API, and will make the logic more maintainable going forward.

Testing Done

All unit tests pass.

Commits

Summary	ID
Update API testing to use common equery functions. The API unit tests now make use of some of the existing equery utility functions, as well as providing a couple new functions for handling incoming requests and outgoing responses. This significantly reduces the code required for query assertions in the API, and will make the logic more maintainable going forward.	ac70de3bdc8fed8edc3c17fcb47f14534cdf6ec7

Issues

Description	From	Last Updated
'reviewboard.reviews.testing.queries.review_requests.get_review_requests_accessible_equeries' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 26, 2023, 10:13 p.m.
'reviewboard.reviews.testing.queries.review_requests.get_review_requests_accessible_prep_equeries' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 26, 2023, 10:13 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_review_request.py (Diff revision 1)

The issue has been resolved. Show all issues

'reviewboard.reviews.testing.queries.review_requests.get_review_requests_accessible_equeries' imported but unused

Column: 1
Error code: F401

reviewboard/webapi/tests/test_review_request.py (Diff revision 1)

The issue has been resolved. Show all issues

'reviewboard.reviews.testing.queries.review_requests.get_review_requests_accessible_prep_equeries' imported but unused

Column: 1
Error code: F401

Change Summary:

Removed unused imports.

Commits:

	Summary	ID
	Update API testing to use common equery functions. The API unit tests now make use of some of the existing equery utility functions, as well as providing a couple new functions for handling incoming requests and outgoing responses. This significantly reduces the code required for query assertions in the API, and will make the logic more maintainable going forward.	3b7fe4f6bb85143a3eb3c2ecec16221c47231e10
	Update API testing to use common equery functions. The API unit tests now make use of some of the existing equery utility functions, as well as providing a couple new functions for handling incoming requests and outgoing responses. This significantly reduces the code required for query assertions in the API, and will make the logic more maintainable going forward.	3898236fca4ade7ac9799ff2eb481cb6f691a121

Diff:

Revision 2 (+768 -2430)

Show changes

	docs/manual/extending/coderef/index.rst
	reviewboard/webapi/testing/__init__.py
	reviewboard/webapi/testing/queries.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Added back a missing model key in an equery.

Commits:

	Summary	ID
	Update API testing to use common equery functions. The API unit tests now make use of some of the existing equery utility functions, as well as providing a couple new functions for handling incoming requests and outgoing responses. This significantly reduces the code required for query assertions in the API, and will make the logic more maintainable going forward.	3898236fca4ade7ac9799ff2eb481cb6f691a121
	Update API testing to use common equery functions. The API unit tests now make use of some of the existing equery utility functions, as well as providing a couple new functions for handling incoming requests and outgoing responses. This significantly reduces the code required for query assertions in the API, and will make the logic more maintainable going forward.	ac70de3bdc8fed8edc3c17fcb47f14534cdf6ec7

Diff:

Revision 3 (+770 -2430)

Show changes

	docs/manual/extending/coderef/index.rst
	reviewboard/webapi/testing/__init__.py
	reviewboard/webapi/testing/queries.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (d71fb86)