Display commit lists for review requests created with history

Review Request #10094 — Created July 18, 2018 and updated

brennie
Review Board
release-4.0.x
10099, 10082
4d5da3f...
reviewboard

The CommitListField renders the summaries (and authors if they differ
from the review request submitter) of the commits that make up a
multi-commit review request. This field has been added to a new
ExtraFieldSet, which exists below the MainFieldSet. This is due to
the RB.ReviewRequestEditorView expecting the last field in the main
field set to be an editable text field and working around this
limitation was more complex and convoluted than adding a new fieldset.

The JS RB.ReviewRequestFields.CommitListFieldView is responsible for
toggling between the full commit message (if it is longer than a single
line) and the summary.

  • Ran unit tests.
  • Uploaded review requests with multiple commits and saw the correct
    commits displayed in the field and in change descriptions.
  • TODO: Add unit tests for the field.
Loading file attachments...

  • 0
  • 0
  • 6
  • 0
  • 6
Description From Last Updated
Checks run (1 failed, 1 failed with error)
flake8 failed.
JSHint internal error.

flake8

brennie
Review request changed

Summary:

-WIP
+Display commit lists for review requests created with history

Description:

~  

WIP

  ~

The CommitListField renders the summaries (and authors if they differ

  + from the review request submitter) of the commits that make up a
  + multi-commit review request. This field has been added to a new
  + ExtraFieldSet, which exists below the MainFieldSet. This is due to
  + the RB.ReviewRequestEditorView expecting the last field in the main
  + field set to be an editable text field and working around this
  + limitation was more complex and convoluted than adding a new fieldset.

  +
  +

The JS RB.ReviewRequestFields.CommitListFieldView is responsible for

  + toggling between the full commit message (if it is longer than a single
  + line) and the summary.

Testing Done:

  +
  • Ran unit tests.
  +
  • Uploaded review requests with multiple commits and saw the correct
    commits displayed in the field and in change descriptions.
  +
  • TODO: Add unit tests for the field.

Depends On:

+10099 - Correctly return line counts in the FileDiffCollectionMixin

Commit:

-af8a4800e4076aa05c36f4b489023be474aab363
+bec2c2299fc198e5674b709d1a041b3e0f1064dc

Diff:

Revision 2 (+561 -20)

Show changes

Added Files:

Checks run (1 failed, 1 failed with error)

flake8 failed.
JSHint internal error.

flake8

brennie
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

brennie
brennie
brennie
brennie
Review request changed
Loading...