Typo in the description: "commist" -> "commit"

Leftover debug output.

This can easily be in alphabetical order. (While that doesn't always make things better in CSS -- width and height, for instance, should usually go together -- it's worth doing here.)

Swap these.

Alphabetical order for these selectors.

This is using a trailing comma, but this file isn't a .es6.js. Can you rename the file?

Can you add a constant for the max length, and then compute the two numbers from that?

I'd prefer to be explicit and not use the shorthand. Especially when we're having to be explicit for other values in the dictionary.

Missing docs.

Missing a trailing comma.

interview? :)

Wrong number of spaces for indentation.

Extra blank line.

Alphabetical order.

Can you be more explicit in the TODO?

Can you split out the template parameters so it's consistent with other calls in the codebase and easier to update? One line per variable.

As above, I'd prefer being explicit with a key: value form.

Here, too.

Technically this is a jQuery.Event.
Same below.

Extra blank line.

Extra blank line.

We need to explicitly use function() with Jasmine instead of =>, as this matters.

Blank line between these.

No blank line here.

function(), not () =>.
Same with all others in the tests in this change.

No need for </div>.

No need to define to null.

Can you use the explicit expanded form?
Same below.

No spaces within the {}. This file is inconsistent on this.
Same with all below.

Missing trailing comma.

Missing trailing comma.

No need for the default value.

Comma before "if any."

Missing docs.

If we can avoid this form, we should. It ends up being unnecessarily expensive, since it doesn't really add anything beyond what we could do before and just expands to a bunch of otherwise useless code (in this usage).

Can you put this in alphabetical order?

In sync how?
Given the length and need for more details, this can use {% comment %}...{% endcomment %}.

Two blank lines on either side.

Should be Model Attributes.

boolean

Model Attribute.

Can you explain what needs to be kept in sync?

Multi-line comments should be in /* .. */ format.

Kinda looks wrong. Let's do:

$content =
    $(tableTemplate({
        ...
    }))
    .append(...)

boolean

Typo: "attribtues" -> "attributes".

Needs to be .call instead of .apply if not passing a list of arguments.

Alphabetical order.

The code is good. There's just a few inconsistencies within the new code that I want to address.

This defaults to an empty list, but the other view defaults to None. We should be consistent to avoid issues down the road.

Still need two blank lines.

Let's be explicit, especially since we are in the two cases above.

No spaces immediately within {..}

No spaces immediately within {..}

No spaces immediately within {..}

This can just be <p>.

Alphabetical order.

Alphabetical order.

Can you check isEmpty() instead?

These templates are all using 2 spaces for indentation in the HTML, but they should use 1 like all other HTML-based templates.

Can we put the expression in parens?

You don't need to use the $() around headerTemplate--you can just append the HTML.

Same here.

We should probably also do e.stopPropagation()

We should probably also do e.stopPropagation()

Needs "Args:" now.

Ship It!