Separate the ReviewRequestPageDataMixin from BuiltinFieldMixin

Review Request #10082 — Created July 13, 2018 and submitted

brennie
Review Board
release-3.0.x
10094, 10083
3e0242e...
reviewboard

The ReviewRequestPageDataMixin was built on the BuiltinFieldMixin.
However, this requires that the field being represented be available on
the review request draft as field_id or else the mixin will use the
review request instead. This is not ideal when the represented field is
derived state or not directly accessible as an attribute/property on the
review request draft, e.g., it is an attribute of the draft diff
instead.

Now the two are more separate and fields that require the old behaviour
inherit from both.

Ran unit tests.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

brennie
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (d89daba)
Loading...