Rename `diff_set` -> `diffset`, etc.
Review Request #9994 — Created May 31, 2018 and submitted
Information | |
---|---|
brennie | |
Review Board | |
release-4.0.x | |
9609 | |
0067603... | |
Reviewers | |
reviewboard | |
This patch renames the model files for
DiffSet
,FileDiff
, and
DiffSetHistory
to treatDiff{...}
as a single word in the filenames.
All docstrings have been udpated to refer to the new location.
Ran unit tests.
Change Summary:
Fix additional usage
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+219 -217) |
Checks run (1 succeeded, 1 failed with error)
flake8
internal error.
JSHint
passed.
-
-
reviewboard/webapi/resources/diffcommit.py (Diff revision 2) I feel like the API should still be
diff_commits
. This does not need to match the internal module name. -
-
reviewboard/webapi/resources/validate_diffcommit.py (Diff revision 2) And like above, I think we can separate out the "diff" from "commit."
Change Summary:
This is now the first commit in the series.
Description: |
|
|||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Depends On: |
|
|||||||||||||||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||||||||||||||
Diff: |
Revision 3 (+50 -39) |
Checks run (1 succeeded, 1 failed with error)
flake8
internal error.
JSHint
passed.