Rename `diff_set` -> `diffset`, etc.

Review Request #9994 — Created June 1, 2018 and updated

brennie
Review Board
release-4.0.x
9921
ba44e79...
reviewboard

This patch renames the model files for DiffSet, DiffCommit,
FileDiff, and DiffSetHistory to treat Diff{...} as a single word
in the filenames. All docstrings have been udpated to refer to the new
location.

Additionally, usages of diff_commit have been replaced with
diffcommit so that code reads the same for DiffCommits as it does
for DiffSets, etc.

Ran unit tests.

  • 3
  • 0
  • 0
  • 0
  • 3
Description From Last Updated
I feel like the API should still be diff_commits. This does not need to match the internal module name. chipx86 chipx86
Similarly, draft_diff_commit. chipx86 chipx86
And like above, I think we can separate out the "diff" from "commit." chipx86 chipx86
brennie
Review request changed

Checks run (1 succeeded, 1 failed with error)

flake8 internal error.
JSHint passed.
chipx86
  1. 
      
  2. I feel like the API should still be diff_commits. This does not need to match the internal module name.

  3. Similarly, draft_diff_commit.

  4. And like above, I think we can separate out the "diff" from "commit."

  5. 
      
Loading...