Summary

Rename `diff_set` -> `diffset`, etc.

Review Request #9994 — Created May 31, 2018 and submitted July 10, 2018, 7:55 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Blocks

9609

Commit

0067603...

Reviewers

Groups

reviewboard

People

Description

This patch renames the model files for DiffSet, FileDiff, and
DiffSetHistory to treat Diff{...} as a single word in the filenames.
All docstrings have been udpated to refer to the new location.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
I feel like the API should still be diff_commits. This does not need to match the internal module name.	chipx86	July 4, 2018, 2:46 p.m.
Similarly, draft_diff_commit.	chipx86	July 4, 2018, 2:46 p.m.
And like above, I think we can separate out the "diff" from "commit."	chipx86	July 4, 2018, 2:46 p.m.

flake8 internal error.

JSHint passed.

Change Summary:

Fix additional usage

Commit:

8f63f758c85e3ae90a25dac176dd9364f6adb292

ba44e79e052b21aa0e07ce0cf3763c27bff00ec0

Diff:

Revision 2 (+219 -217)

Show changes

	reviewboard/diffviewer/commitutils.py
	reviewboard/diffviewer/filediff_creator.py
	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models/__init__.py
	reviewboard/diffviewer/models/diff_commit.py
	reviewboard/diffviewer/models/diff_set.py
	reviewboard/diffviewer/models/diff_set_history.py
	19 more

Checks run (1 succeeded, 1 failed with error)

flake8 internal error.

JSHint passed.

reviewboard/webapi/resources/diffcommit.py (Diff revision 2)

The issue has been resolved. Show all issues

I feel like the API should still be diff_commits. This does not need to match the internal module name.

reviewboard/webapi/resources/draft_diffcommit.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Similarly, draft_diff_commit.
```
reviewboard/webapi/resources/validate_diffcommit.py (Diff revision 2)
The issue has been resolved. Show all issues
```
And like above, I think we can separate out the "diff" from "commit."
```

Change Summary:

This is now the first commit in the series.

Description:

~		This patch renames the model files for `DiffSet`, `DiffCommit`,
~		`FileDiff`, and `DiffSetHistory` to treat `Diff{...}` as a single word
~		in the filenames. All docstrings have been udpated to refer to the new
	~	This patch renames the model files for `DiffSet`, `FileDiff`, and
	~	`DiffSetHistory` to treat `Diff{...}` as a single word in the filenames.
	~	All docstrings have been udpated to refer to the new location.
-		location.
-
-		Additionally, usages of `diff_commit` have been replaced with
-		`diffcommit` so that code reads the same for `DiffCommit`s as it does
-		for `DiffSet`s, etc.

Depends On:

~~9921 - Validate commits before posting~~

Commit:

ba44e79e052b21aa0e07ce0cf3763c27bff00ec0

00676034c25b4ea95bb371a1d6ff34e7834c26a8

Diff:

Revision 3 (+50 -39)

Show changes

	reviewboard/attachments/forms.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/views.py
	reviewboard/diffviewer/models/__init__.py
	reviewboard/diffviewer/models/diff_set.py
	reviewboard/diffviewer/models/diff_set_history.py
	7 more

Checks run (1 succeeded, 1 failed with error)

flake8 internal error.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (497f50b)