Implementation of Review Request Infobox to the Dashboard

Review Request #8661 - Created Jan. 22, 2017 and updated

Sharleen Fisher
Review Board
master
7b14813...
reviewboard, students

This change introduces a new infobox to the dashboard upon hover, over a review request. The idea is similar to the infobox for users and bugs - the infobox will display some summary information regarding the review request, including the submitter, the summary and description, issue counts, and a few of the most recent reviews/activity on the request. This will allow users to get a quick overview of the review request without having to actually move to the page - in particular, what should be useful is the ability to see what recent activity has been done to a review request.

Code has been tested by running the development server and adjusting the tester review request for different scenarios.
Jasmine tests have been run - but at this point in time, the Jasmine tests find that the class label for the infobox is being generated on the Diff links, where it should not be.
Python tests have not been run.

Loading file attachments...

  • 3
  • 54
  • 17
  • 74
Description From Last Updated
We could refactor this bit into a new method, e.g., reviewboard.accounts.query.attach_visibility_to_queryset(queryset, user.id) or something similar Barret Rennie Barret Rennie
If you do the other refactor I suggested, you should be able to refactor this into a utility method. Barret Rennie Barret Rennie
Better not to have the extra spaces there. Just one. Christian Hammond Christian Hammond
Review Bot
Barret Rennie
Sharleen Fisher
Review Bot
Sharleen Fisher
Review Bot
Sharleen Fisher
Review Bot
David Trowbridge
Sharleen Fisher
Review Bot
Sharleen Fisher
Review Bot
Sharleen Fisher
Review Bot
Sharleen Fisher
Review Bot
Sharleen Fisher
Review Bot
David Trowbridge
Sharleen Fisher
Sharleen Fisher
Anni Cao
Anni Cao
Anni Cao
Anni Cao
Anni Cao
Anni Cao
Erik Johansson
Sharleen Fisher
David Trowbridge
David Trowbridge
Sharleen Fisher
Sharleen Fisher
Barret Rennie
Sharleen Fisher
Christian Hammond
Sharleen Fisher
Review request changed

Checks run (2 succeeded, 1 failed with error)

PEP8 Style Checker internal error.
Pyflakes passed.
JSHint passed.
Loading...