Implementation of Review Request Infobox to the Dashboard [WIP]

Review Request #8661 - Created Jan. 22, 2017 and updated

Sharleen Fisher
Review Board
master
06365e6...
reviewboard, students

This change introduces a new infobox to the dashboard upon hover, over a review request. The idea is similar to the infobox for users and bugs - the infobox will display some summary information regarding the review request, including the submitter, the summary and description, issue counts, and a few of the most recent reviews/activity on the request. This will allow users to get a quick overview of the review request without having to actually move to the page - in particular, what should be useful is the ability to see what recent activity has been done to a review request.

Code isn't ready to be run or tested at this point in time.

  • 3
  • 24
  • 13
  • 40
Description From Last Updated
The other infobox views here have an old style of docstring, but because this is new code, we should use ... David Trowbridge David Trowbridge
Python strings concatenate in the same way that C strings do, so you can just elide the + operator here. ... David Trowbridge David Trowbridge
Yep, you do. David Trowbridge David Trowbridge
Review Bot
Barret Rennie
Sharleen Fisher
Review Bot
Sharleen Fisher
Review Bot
Sharleen Fisher
Review Bot
David Trowbridge
Sharleen Fisher
Review Bot
Sharleen Fisher
Review Bot
Sharleen Fisher
Review Bot
Sharleen Fisher
Review Bot
Sharleen Fisher
Review request changed
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/views.py
        reviewboard/datagrids/columns.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/datagridPageView.js
        reviewboard/static/rb/js/utils/linkifyUtils.es6.js
        reviewboard/static/rb/css/common.less
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/js/common.es6.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/views.py
        reviewboard/datagrids/columns.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/static/rb/js/pages/views/datagridPageView.js
        reviewboard/static/rb/js/utils/linkifyUtils.es6.js
        reviewboard/static/rb/css/common.less
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/js/common.es6.js
    
    
David Trowbridge
  1. Now that you've started actually working on the CSS, can you start including a screenshot of what things look like whenever you do your code updates?

  2. reviewboard/reviews/builtin_fields.py (Diff revision 9)
     
     
     

    Python strings concatenate in the same way that C strings do, so you can just elide the + operator here. That said, the way things concatenate now, there won't be any space between title="..." and class="review_request". This probably parses OK on the browser side but it's not totally correct. Let's add some spaces at the beginning of the second line, which also helps make it more readable:

    rendered_item = format_html(
        '<a href="{url}" title="{summary"}'
        '   class="review_request">{id}</a>',
        ...
    
  3. Yep, you do.

Loading...