Add Mercurial hook to post to ReviewBoard on push

Review Request #8554 - Created Nov. 26, 2016 and updated

André Klitzing
RBTools
release-0.7.x
8553
e68ca96...
rbtools

Add Mercurial hook to post to ReviewBoard on push

The hook only allows to push if all commits have been approved in a
review requests, otherwise it rejects it and creates a review request
for the (new) commits. This is similar to "rbt post", but

1. Does not require the user to install RBTools locally.
2. Makes sure any changes pushed to the central server have been
reviewed and approved.
3. Adds references to tickets/bugs/issues, which rbt post doesn't do.
4. Automatically finds the right review request to update if there
are any new commits, based the commit ID and a date/author hash.
This does not require the user to confirm anything, which rbt post
(often) requires. This also allows the hook to recognize
rebased/amended changesets, because the date/author hash
is unchanged.

  • Created new review requests
  • Updated existing review requests
  • Tried to push not approved changesets
  • Pushed approved changesets
  • Checked matching of changesets with another date / author hash
  • 0
  • 16
  • 2
  • 18
Description From Last Updated
Review Bot
André Klitzing
André Klitzing
Review Bot
André Klitzing
Review Bot
David Trowbridge
André Klitzing
Review request changed

Commit:

-0a9341082aa8f72f6c31059a868f5773c7a27b14
+e68ca96568d04a3ad8a895de1294051ca065f32d

Diff:

Revision 4 (+744 -1)

Show changes

Review Bot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/hooks/mercurial.py
        contrib/tools/mercurial_push.py
        rbtools/clients/mercurial.py
        rbtools/hooks/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/hooks/mercurial.py
        contrib/tools/mercurial_push.py
        rbtools/clients/mercurial.py
        rbtools/hooks/tests.py
    
    
    1. Some chance to get it in? :-)

    2. ping?

Loading...