Summary

Add helper method to get and linkify issue numbers

Review Request #8553 — Created Nov. 26, 2016 and discarded Jan. 2, 2017, 10:47 p.m.

Information

Owner

misery

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Blocks

8554

Reviewers

Groups

rbtools

People

halvorlu

Description

The methods can be used to automatically find
issue numbers in review request description.

* linkify_ticket_refs: Make issues to a link
* get_ticket_refs: Returns issues as a set

Patch is based on work of Halvor Lund!

Testing Done

Tool: Pyflakes
Processed Files:
    rbtools/hooks/common.py
    rbtools/hooks/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/hooks/common.py
    rbtools/hooks/tests.py

Commit:

653733bdac71db97470eb991de33cf2f3f75a509

f9e159e09800411f7368153cd11093b3e3f3243a

Diff:

Revision 2 (+128)

Show changes

	rbtools/hooks/common.py
	rbtools/hooks/tests.py

Tool: Pyflakes
Processed Files:
    rbtools/hooks/common.py
    rbtools/hooks/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/hooks/common.py
    rbtools/hooks/tests.py

What is this used for?

misery Jan. 2, 2017, 1:12 a.m.

This can be used to parse possible issue numbers in a text like a commit description. So this can be used to automatically add issues to bugs_closed like https://reviews.reviewboard.org/r/8554/ do.

david Jan. 2, 2017, 9:40 a.m.

Oh, I was searching for linkify_ticket_refs, which /r/8554/ doesn't use. For now, I think I'd prefer this to be localized within rbtools/hooks/mercurial.py.

Status:: Discarded
Change Summary:: Merged into https://reviews.reviewboard.org/r/8554/