Add the URL Avatar Service as a default service

Review Request #8482 - Created Oct. 21, 2016 and submitted

Barret Rennie
Review Board
release-3.0.x
8480, 8481
reviewboard

The URLAvatarService is a new avatar service from Djblets to allow
absolute URLs for avatars. Users do not have access to this resource.
Instead, it is intended to be used with users that are created by
extensions so that they can provide their own avatars.

  • Ran unit tests.
  • Saw that the new avatar service was enabled by default.
  • Could not select the new avatar service in the config form.
  • 0
  • 0
  • 6
  • 0
  • 6
Description From Last Updated
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/avatars/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/avatars/registry.py
    
    
  2. 
      
David Trowbridge
  1. 
      
  2. reviewboard/avatars/registry.py (Diff revision 1)
     
     
     

    One per line?

  3. reviewboard/avatars/tests.py (Diff revision 1)
     
     
     

    One per line?

  4. reviewboard/avatars/tests.py (Diff revision 1)
     
     
     
     

    Can we reformat this?

    self.assertSetEqual(
        set(registry),
        {
            FileUploadService,
            GravatarService,
            URLAvatarService,
        })
    
  5. reviewboard/avatars/tests.py (Diff revision 1)
     
     
     
     

    Same here.

  6. reviewboard/avatars/tests.py (Diff revision 1)
     
     
     
     

    Can we format this as:

    [
        GravatarService.avatar_service_id,
        ...
    ]
    
  7. reviewboard/avatars/tests.py (Diff revision 1)
     
     
     
     

    And here.

  8. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/avatars/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/avatars/registry.py
    
    
  2. 
      
David Trowbridge
  1. Ship It!
  2. 
      
Christian Hammond
  1. 
      
  2. reviewboard/avatars/tests.py (Diff revision 2)
     
     

    We don't really need to use assertSetEqual or assertListEqual or things like that if we're passing in just sets or lists. assertEqual will use the right behavior.

    Not really worth changing all these (unless you want to), but worth mentioning.

  3. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (630ade4)
Loading...