Summary

Add the URL Avatar Service as a default service

Review Request #8482 — Created Oct. 21, 2016 and submitted Oct. 25, 2016, 9:51 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~8480~~, ~~8481~~

Reviewers

Groups

reviewboard

People

Description

The URLAvatarService is a new avatar service from Djblets to allow
absolute URLs for avatars. Users do not have access to this resource.
Instead, it is intended to be used with users that are created by
extensions so that they can provide their own avatars.

Testing Done


Ran unit tests.
Saw that the new avatar service was enabled by default.
Could not select the new avatar service in the config form.

Issues

Description	From	Last Updated
One per line?	david	Oct. 24, 2016, 4:30 p.m.
One per line?	david	Oct. 24, 2016, 4:30 p.m.
Can we reformat this? self.assertSetEqual( set(registry), { FileUploadService, GravatarService, URLAvatarService, })	david	Oct. 24, 2016, 4:31 p.m.
Same here.	david	Oct. 24, 2016, 4:31 p.m.
Can we format this as: [ GravatarService.avatar_service_id, ... ]	david	Oct. 24, 2016, 4:32 p.m.
And here.	david	Oct. 24, 2016, 4:32 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/avatars/tests.py
    reviewboard/avatars/registry.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/avatars/tests.py
    reviewboard/avatars/registry.py

reviewboard/avatars/registry.py (Diff revision 1)
The issue has been resolved. Show all issues
```
One per line?
```
reviewboard/avatars/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
One per line?
```

reviewboard/avatars/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we reformat this?

self.assertSetEqual(
    set(registry),
    {
        FileUploadService,
        GravatarService,
        URLAvatarService,
    })

reviewboard/avatars/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```

reviewboard/avatars/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we format this as:

[
    GravatarService.avatar_service_id,
    ...
]

reviewboard/avatars/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
And here.
```

Change Summary:

Address issues

Diff:

Revision 2 (+33 -12)

Show changes

	reviewboard/avatars/registry.py
	reviewboard/avatars/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/avatars/tests.py
    reviewboard/avatars/registry.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/avatars/tests.py
    reviewboard/avatars/registry.py

Ship it!

```
Ship It!
```

reviewboard/avatars/tests.py (Diff revision 2)

We don't really need to use assertSetEqual or assertListEqual or things like that if we're passing in just sets or lists. assertEqual will use the right behavior.

Not really worth changing all these (unless you want to), but worth mentioning.

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (630ade4)