Update Review Board to use the new avatar services APIs

Review Request #8480 - Created Oct. 21, 2016 and submitted

Barret Rennie
Review Board
release-3.0.x
8479
8482
reviewboard

This patch updates avatar services tests to use the new avatar services
registry API from r/8479. It also updates the user API and user
datagrid column to use the newer AvatarServicesRegistry.for_user
method to retrieve their preferred avatar service.

  • Ran unit tests.
  • Verified that avatar configuration still works.
  • Verified that avatar admin configuration still works.
  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/admin/forms.py
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
        reviewboard/datagrids/columns.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/admin/forms.py
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
        reviewboard/datagrids/columns.py
    
    
  2. 
      
Barret Rennie
David Trowbridge
  1. 
      
  2. reviewboard/admin/forms.py (Diff revision 1)
     
     

    I think the old method was cleaner.

  3. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/admin/forms.py
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
        reviewboard/datagrids/columns.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/admin/forms.py
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
        reviewboard/datagrids/columns.py
    
    
  2. 
      
David Trowbridge
  1. 
      
  2. reviewboard/admin/forms.py (Diff revision 2)
     
     

    You lost a not in here.

  3. reviewboard/admin/forms.py (Diff revision 2)
     
     

    Change back to use has_service?

  4. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/admin/forms.py
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
        reviewboard/datagrids/columns.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/admin/forms.py
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
        reviewboard/datagrids/columns.py
    
    
  2. 
      
David Trowbridge
  1. Ship It!
  2. 
      
Christian Hammond
  1. 
      
  2. reviewboard/avatars/tests.py (Diff revision 3)
     
     

    You can use assertEqual. It's equivalent to assertSetEqual when passing in sets.

  3. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (ef24b8d)
Loading...