Add the URLAvatarService

Review Request #8481 - Created Oct. 21, 2016 and submitted

Barret Rennie
Djblets
release-0.10.x
8479
8482
djblets

The URLAvatarService is a new avatar service for setting the avatar of
a user to an absolute URL. This service is a hidden service, which is a
new type of service that is not exposed to users through the
configuration form. (Indeed, attempting to fool the form and submitting
the data will result in an error as if it does not exist.) Instead, it
is to be used to provide avatars for users created by extensions, etc.

  • Ran unit tests.
  • Tested with Review Board.
  • Saw that the service did not show up in the avatar services form.
  • 0
  • 0
  • 8
  • 4
  • 12
Description From Last Updated
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
  2. djblets/avatars/services/__init__.py (Diff revision 1)
     
     
     'AvatarService' imported but unused
    
  3. djblets/avatars/services/__init__.py (Diff revision 1)
     
     
     'FileUploadService' imported but unused
    
  4. djblets/avatars/services/__init__.py (Diff revision 1)
     
     
     'GravatarService' imported but unused
    
  5. djblets/avatars/services/__init__.py (Diff revision 1)
     
     
     'URLAvatarService' imported but unused
    
  6. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
  2. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
  2. djblets/avatars/registry.py (Diff revision 3)
     
     
     redefinition of unused 'unregister' from line 137
    
  3. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
  2. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
  2. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
  2. djblets/avatars/tests.py (Diff revision 6)
     
     
     redefinition of unused 'avatar_service_id' from line 27
    
  3. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
  2. 
      
David Trowbridge
  1. 
      
  2. djblets/avatars/services/url.py (Diff revision 7)
     
     

    Typo: avatrs.

  3. djblets/avatars/services/url.py (Diff revision 7)
     
     

    Instead of "Integrations can be configured", how about "Automation users can be configured..."

  4. djblets/avatars/tests.py (Diff revision 7)
     
     
     

    Maybe do one per line for future expansion?

  5. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/avatars/forms.py
        djblets/avatars/services/url.py
        djblets/avatars/services/base.py
        djblets/avatars/services/__init__.py
        djblets/avatars/tests.py
        djblets/avatars/registry.py
    
    
  2. 
      
David Trowbridge
  1. Ship It!
  2. 
      
Christian Hammond
  1. 
      
  2. djblets/avatars/services/base.py (Diff revision 8)
     
     

    Missing : after :py:class.

  3. djblets/avatars/services/url.py (Diff revision 8)
     
     

    Is this supposed to be "URLAvatarService" ?

  4. djblets/avatars/tests.py (Diff revision 8)
     
     
     
     
     
     

    Too many blank lines.

  5. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (8656c59)
Loading...