Add a general comments feature class

Review Request #8471 - Created Oct. 17, 2016 and submitted

Barret Rennie
Review Board
release-3.0.x
8470
reviewboard

The new general comments feature can be enabled or disabled with the
reviews.general_comments feature. Disabling this feature will disable
all UI elements for it, as well as the web API resources for it.

Tested with reviews.general_comments enabled and disabled. When
disabled, general comments cannot be created and the UI elements do not
appear.

  • 0
  • 0
  • 4
  • 12
  • 16
Description From Last Updated
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/reviews/views.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/reviews/views.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
  2. reviewboard/reviews/views.py (Diff revision 1)
     
     
     local variable 'general_comments_enabled' is assigned to but never used
    
  3. reviewboard/settings.py (Diff revision 1)
     
     
     'django_reset' imported but unused
    
  4. reviewboard/settings.py (Diff revision 1)
     
     
     'from settings_local import *' used; unable to detect undefined names
    
  5. 
      
Barret Rennie
Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
  2. reviewboard/settings.py (Diff revision 2)
     
     
     'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 2)
     
     
     'from settings_local import *' used; unable to detect undefined names
    
  4. 
      
Barret Rennie
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
  2. reviewboard/settings.py (Diff revision 3)
     
     
     'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 3)
     
     
     'from settings_local import *' used; unable to detect undefined names
    
  4. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
  2. reviewboard/settings.py (Diff revision 4)
     
     
     'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 4)
     
     
     'from settings_local import *' used; unable to detect undefined names
    
  4. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
  2. reviewboard/settings.py (Diff revision 5)
     
     
     'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 5)
     
     
     'from settings_local import *' used; unable to detect undefined names
    
  4. 
      
David Trowbridge
  1. Ship It!
  2. 
      
Christian Hammond
  1. 
      
  2. reviewboard/reviews/features.py (Diff revision 5)
     
     
     
     
     

    Classes should go before instances.

  3. reviewboard/reviews/features.py (Diff revision 5)
     
     

    More specifically, it allows comments to be made. Issues are optional.

  4. This is invoking this._onAddCommentClicked immediately.

  5. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/features.py
        reviewboard/settings.py
        reviewboard/reviews/default_actions.py
        reviewboard/webapi/resources/base_review_general_comment.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
  2. reviewboard/settings.py (Diff revision 6)
     
     
     'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 6)
     
     
     'from settings_local import *' used; unable to detect undefined names
    
  4. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (1fc7458)
Loading...