Summary

Add a general comments feature class

Review Request #8471 — Created Oct. 17, 2016 and submitted Oct. 24, 2016, 4:28 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~8470~~

Reviewers

Groups

reviewboard

People

Description

The new general comments feature can be enabled or disabled with the
reviews.general_comments feature. Disabling this feature will disable
all UI elements for it, as well as the web API resources for it.

Testing Done

Tested with reviews.general_comments enabled and disabled. When
disabled, general comments cannot be created and the UI elements do not
appear.

Issues

Description	From	Last Updated
local variable 'general_comments_enabled' is assigned to but never used	reviewbot	Oct. 17, 2016, 5:53 p.m.
'django_reset' imported but unused	reviewbot	Oct. 17, 2016, 5:53 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 17, 2016, 5:53 p.m.
'django_reset' imported but unused	reviewbot	Oct. 17, 2016, 5:54 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 17, 2016, 5:54 p.m.
'django_reset' imported but unused	reviewbot	Oct. 17, 2016, 8:15 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 17, 2016, 8:15 p.m.
'django_reset' imported but unused	reviewbot	Oct. 17, 2016, 8:16 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 17, 2016, 8:16 p.m.
Classes should go before instances.	chipx86	Oct. 19, 2016, 3:19 p.m.
More specifically, it allows comments to be made. Issues are optional.	chipx86	Oct. 19, 2016, 3:19 p.m.
'django_reset' imported but unused	reviewbot	Oct. 17, 2016, 8:19 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 17, 2016, 8:19 p.m.
This is invoking this._onAddCommentClicked immediately.	chipx86	Oct. 19, 2016, 3:19 p.m.
'django_reset' imported but unused	reviewbot	Oct. 19, 2016, 11:21 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 19, 2016, 11:21 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js

reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'general_comments_enabled' is assigned to but never used
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Diff:

Revision 2 (+58 -22)

Show changes

	reviewboard/settings.py
	reviewboard/reviews/default_actions.py
	reviewboard/reviews/features.py
	reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
	reviewboard/static/rb/js/views/reviewDialogView.js
	reviewboard/templates/reviews/reviewable_page_data.js
	reviewboard/webapi/resources/base_review_general_comment.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Depends On:

+	~~8472 - Add a LocalSite-enabled feature checker~~

Depends On:

-	~~8472 - Add a LocalSite-enabled feature checker~~

Diff:

Revision 3 (+59 -22)

Show changes

	reviewboard/settings.py
	reviewboard/reviews/default_actions.py
	reviewboard/reviews/features.py
	reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
	reviewboard/static/rb/js/views/reviewDialogView.js
	reviewboard/templates/reviews/reviewable_page_data.js
	reviewboard/webapi/resources/base_review_general_comment.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js

reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Diff:

Revision 4 (+59 -22)

Show changes

	reviewboard/settings.py
	reviewboard/reviews/default_actions.py
	reviewboard/reviews/features.py
	reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
	reviewboard/static/rb/js/views/reviewDialogView.js
	reviewboard/templates/reviews/reviewable_page_data.js
	reviewboard/webapi/resources/base_review_general_comment.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js

reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Diff:

Revision 5 (+59 -22)

Show changes

	reviewboard/settings.py
	reviewboard/reviews/default_actions.py
	reviewboard/reviews/features.py
	reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
	reviewboard/static/rb/js/views/reviewDialogView.js
	reviewboard/templates/reviews/reviewable_page_data.js
	reviewboard/webapi/resources/base_review_general_comment.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js

reviewboard/settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Ship it!

```
Ship It!
```

reviewboard/reviews/features.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Classes should go before instances.
```
reviewboard/reviews/features.py (Diff revision 5)
The issue has been resolved. Show all issues
```
More specifically, it allows comments to be made. Issues are optional.
```
reviewboard/static/rb/js/views/reviewDialogView.js (Diff revision 5)
The issue has been resolved. Show all issues
```
This is invoking this._onAddCommentClicked immediately.
```
1. brennie Oct. 19, 2016, 3:19 p.m.
  Nice catch!

Diff:

Revision 6 (+57 -22)

Show changes

	reviewboard/settings.py
	reviewboard/reviews/default_actions.py
	reviewboard/reviews/features.py
	reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
	reviewboard/static/rb/js/views/reviewDialogView.js
	reviewboard/templates/reviews/reviewable_page_data.js
	reviewboard/webapi/resources/base_review_general_comment.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/features.py
    reviewboard/settings.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/resources/base_review_general_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
    reviewboard/templates/reviews/reviewable_page_data.js

reviewboard/settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (1fc7458)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 2)

reviewboard/settings.py (Diff revision 2)