-
-
reviewboard/reviews/views.py (Diff revision 1) local variable 'general_comments_enabled' is assigned to but never used
-
-
reviewboard/settings.py (Diff revision 1) 'from settings_local import *' used; unable to detect undefined names
Add a general comments feature class
Review Request #8471 — Created Oct. 17, 2016 and submitted
| Information | |
|---|---|
| brennie | |
| Review Board | |
| release-3.0.x | |
|
|
|
| Reviewers | |
| reviewboard | |
The new general comments feature can be enabled or disabled with the
reviews.general_commentsfeature. Disabling this feature will disable
all UI elements for it, as well as the web API resources for it.
Tested with
reviews.general_commentsenabled and disabled. When
disabled, general comments cannot be created and the UI elements do not
appear.
| Description | From | Last Updated |
|---|---|---|
|
local variable 'general_comments_enabled' is assigned to but never used |
 reviewbot
|
|
|
'django_reset' imported but unused |
reviewbot
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
|
|
'django_reset' imported but unused |
reviewbot
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
|
|
'django_reset' imported but unused |
reviewbot
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
|
|
'django_reset' imported but unused |
reviewbot
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
|
|
Classes should go before instances. |
 chipx86
|
|
|
More specifically, it allows comments to be made. Issues are optional. |
chipx86
|
|
|
'django_reset' imported but unused |
reviewbot
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
|
|
This is invoking this._onAddCommentClicked immediately. |
chipx86
|
|
|
'django_reset' imported but unused |
reviewbot
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
-
Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/features.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js Tool: Pyflakes Processed Files: reviewboard/reviews/features.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js -
-
reviewboard/settings.py (Diff revision 2) 'from settings_local import *' used; unable to detect undefined names
Depends On: |
|
||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+59 -22)
|
-
Tool: Pyflakes Processed Files: reviewboard/reviews/features.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/features.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js -
-
reviewboard/settings.py (Diff revision 3) 'from settings_local import *' used; unable to detect undefined names
Diff: |
Revision 4 (+59 -22)
|
|---|
-
Tool: Pyflakes Processed Files: reviewboard/reviews/features.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/features.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js -
-
reviewboard/settings.py (Diff revision 4) 'from settings_local import *' used; unable to detect undefined names
Diff: |
Revision 5 (+59 -22)
|
|---|
-
Tool: Pyflakes Processed Files: reviewboard/reviews/features.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/features.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js -
-
reviewboard/settings.py (Diff revision 5) 'from settings_local import *' used; unable to detect undefined names
-
-
-
reviewboard/reviews/features.py (Diff revision 5) More specifically, it allows comments to be made. Issues are optional.
-
reviewboard/static/rb/js/views/reviewDialogView.js (Diff revision 5) This is invoking
this._onAddCommentClickedimmediately.
Diff: |
Revision 6 (+57 -22)
|
|---|
-
Tool: Pyflakes Processed Files: reviewboard/reviews/features.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/features.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js -
-
reviewboard/settings.py (Diff revision 6) 'from settings_local import *' used; unable to detect undefined names
Tool: Pyflakes Processed Files: reviewboard/reviews/features.py reviewboard/reviews/views.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/features.py reviewboard/reviews/views.py reviewboard/settings.py reviewboard/reviews/default_actions.py reviewboard/webapi/resources/base_review_general_comment.py Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/templates/reviews/reviewable_page_data.js