-
-
-
-
-
-
reviewboard/settings.py (Diff revision 1) 'from settings_local import *' used; unable to detect undefined names
Add a LocalSite-enabled feature checker
Review Request #8472 — Created Oct. 17, 2016 and submitted
Information | |
---|---|
brennie | |
Review Board | |
release-3.0.x | |
8470 | |
499d182... | |
Reviewers | |
reviewboard | |
The
LocalSiteFeatureChecker
allows features to be enabled or disabled
at theLocalSite
level. Features not configured on a LocalSite will
fall back to the global configuration (first site configuration, then
Django settings).Additionally, the status update work has been reworked to provide the
necessary information (aLocalSite
or aHttpRequest
) to use the new
feature checker.This feature checker is now the default for Review Board.
Ran unit tests.
Description | From | Last Updated |
---|---|---|
Col: 1 W391 blank line at end of file |
![]() |
|
Col: 76 W291 trailing whitespace |
![]() |
|
Col: 1 W391 blank line at end of file |
![]() |
|
'django_reset' imported but unused |
![]() |
|
'from settings_local import *' used; unable to detect undefined names |
![]() |
|
"feature" |
|
|
Let's call this RBFeatureChecker. The reason being that this isn't specific to local sites. This should also check features specific … |
|
|
"Feature checker" |
|
|
Too many "setting"s. |
|
|
reviewboard.site.models (not "sites"). |
|
|
**kwargs |
|
|
Can you move this into the try? That way it will do the right thing if self.EXTRA_DATA_KEY doesn't exist in … |
|
|
Although the __init__ method doesn't do anything too offensive, we should still gate it off like it was before. |
|
|
'django_reset' imported but unused |
![]() |
|
'from settings_local import *' used; unable to detect undefined names |
![]() |
|
'django_reset' imported but unused |
![]() |
|
'from settings_local import *' used; unable to detect undefined names |
![]() |
|
'django_reset' imported but unused |
![]() |
|
'from settings_local import *' used; unable to detect undefined names |
![]() |


-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/settings.py reviewboard/features/checkers.py reviewboard/reviews/detail.py reviewboard/site/models.py reviewboard/site/evolutions/__init__.py reviewboard/site/evolutions/localsite_extra_data.py reviewboard/features/tests.py Ignored Files: reviewboard/features/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/settings.py reviewboard/features/checkers.py reviewboard/reviews/detail.py reviewboard/site/models.py reviewboard/site/evolutions/__init__.py reviewboard/site/evolutions/localsite_extra_data.py reviewboard/features/tests.py Ignored Files: reviewboard/features/__init__.py
-
-
reviewboard/settings.py (Diff revision 2) 'from settings_local import *' used; unable to detect undefined names
-
-
reviewboard/features/checkers.py (Diff revision 2) Can you move this into the
try
? That way it will do the right thing ifself.EXTRA_DATA_KEY
doesn't exist inlocal_site.extra_data
. -
reviewboard/reviews/detail.py (Diff revision 2) Although the
__init__
method doesn't do anything too offensive, we should still gate it off like it was before.
-
-
-
reviewboard/features/checkers.py (Diff revision 2) Let's call this
RBFeatureChecker
. The reason being that this isn't specific to local sites.This should also check features specific to the user (probably based on
Profile.settings['enabled_features']
).Docs will need to be updated accordingly.
-
-
-
-

-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/settings.py reviewboard/features/checkers.py reviewboard/reviews/detail.py reviewboard/site/models.py reviewboard/site/evolutions/__init__.py reviewboard/site/evolutions/localsite_extra_data.py reviewboard/features/tests.py Ignored Files: reviewboard/features/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/settings.py reviewboard/features/checkers.py reviewboard/reviews/detail.py reviewboard/site/models.py reviewboard/site/evolutions/__init__.py reviewboard/site/evolutions/localsite_extra_data.py reviewboard/features/tests.py Ignored Files: reviewboard/features/__init__.py
-
-
reviewboard/settings.py (Diff revision 3) 'from settings_local import *' used; unable to detect undefined names

-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/settings.py reviewboard/features/checkers.py reviewboard/reviews/detail.py reviewboard/site/models.py reviewboard/site/evolutions/__init__.py reviewboard/site/evolutions/localsite_extra_data.py reviewboard/features/tests.py Ignored Files: reviewboard/features/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/settings.py reviewboard/features/checkers.py reviewboard/reviews/detail.py reviewboard/site/models.py reviewboard/site/evolutions/__init__.py reviewboard/site/evolutions/localsite_extra_data.py reviewboard/features/tests.py Ignored Files: reviewboard/features/__init__.py
-
-
reviewboard/settings.py (Diff revision 4) 'from settings_local import *' used; unable to detect undefined names