Summary

Add a LocalSite-enabled feature checker

Review Request #8472 — Created Oct. 17, 2016 and submitted Oct. 24, 2016, 4:28 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Blocks

8470

Commit

499d182...

Reviewers

Groups

reviewboard

People

Description

The LocalSiteFeatureChecker allows features to be enabled or disabled
at the LocalSite level. Features not configured on a LocalSite will
fall back to the global configuration (first site configuration, then
Django settings).

Additionally, the status update work has been reworked to provide the
necessary information (a LocalSite or a HttpRequest) to use the new
feature checker.

This feature checker is now the default for Review Board.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Col: 1 W391 blank line at end of file	reviewbot	Oct. 17, 2016, 8:13 p.m.
Col: 76 W291 trailing whitespace	reviewbot	Oct. 17, 2016, 8:13 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Oct. 17, 2016, 8:13 p.m.
'django_reset' imported but unused	reviewbot	Oct. 17, 2016, 8:13 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 17, 2016, 8:13 p.m.
"feature"	chipx86	Oct. 19, 2016, 2:53 p.m.
Let's call this RBFeatureChecker. The reason being that this isn't specific to local sites. This should also check features specific …	chipx86	Oct. 19, 2016, 2:52 p.m.
"Feature checker"	chipx86	Oct. 19, 2016, 2:53 p.m.
Too many "setting"s.	chipx86	Oct. 19, 2016, 2:53 p.m.
reviewboard.site.models (not "sites").	chipx86	Oct. 19, 2016, 2:53 p.m.
**kwargs	chipx86	Oct. 19, 2016, 2:53 p.m.
Can you move this into the try? That way it will do the right thing if self.EXTRA_DATA_KEY doesn't exist in …	david	Oct. 19, 2016, 2:54 p.m.
Although the __init__ method doesn't do anything too offensive, we should still gate it off like it was before.	david	Oct. 19, 2016, 2:55 p.m.
'django_reset' imported but unused	reviewbot	Oct. 17, 2016, 8:15 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 17, 2016, 8:15 p.m.
'django_reset' imported but unused	reviewbot	Oct. 19, 2016, 3:17 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 19, 2016, 3:17 p.m.
'django_reset' imported but unused	reviewbot	Oct. 19, 2016, 3:17 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 19, 2016, 3:17 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/features/checkers.py
    reviewboard/reviews/views.py
    reviewboard/reviews/detail.py
    reviewboard/features/tests.py
    reviewboard/settings.py

Ignored Files:
    reviewboard/features/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/features/checkers.py
    reviewboard/reviews/views.py
    reviewboard/reviews/detail.py
    reviewboard/features/tests.py
    reviewboard/settings.py

Ignored Files:
    reviewboard/features/__init__.py

reviewboard/features/checkers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```
reviewboard/features/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 76
 W291 trailing whitespace
```
reviewboard/features/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Diff:

Revision 2 (+182 -6)

Show changes

	reviewboard/settings.py
	reviewboard/features/__init__.py
	reviewboard/features/checkers.py
	reviewboard/features/tests.py
	reviewboard/reviews/detail.py
	reviewboard/reviews/views.py
	reviewboard/site/models.py
	reviewboard/site/evolutions/__init__.py
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/features/checkers.py
    reviewboard/reviews/detail.py
    reviewboard/site/models.py
    reviewboard/site/evolutions/__init__.py
    reviewboard/site/evolutions/localsite_extra_data.py
    reviewboard/features/tests.py

Ignored Files:
    reviewboard/features/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/features/checkers.py
    reviewboard/reviews/detail.py
    reviewboard/site/models.py
    reviewboard/site/evolutions/__init__.py
    reviewboard/site/evolutions/localsite_extra_data.py
    reviewboard/features/tests.py

Ignored Files:
    reviewboard/features/__init__.py

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

reviewboard/features/checkers.py (Diff revision 2)

The issue has been resolved. Show all issues

Can you move this into the try? That way it will do the right thing if self.EXTRA_DATA_KEY doesn't exist in local_site.extra_data.

reviewboard/reviews/detail.py (Diff revision 2)

The issue has been resolved. Show all issues

Although the __init__ method doesn't do anything too offensive, we should still gate it off like it was before.

reviewboard/features/checkers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"feature"
```

reviewboard/features/checkers.py (Diff revision 2)

The issue has been resolved. Show all issues

Let's call this RBFeatureChecker. The reason being that this isn't specific to local sites.

This should also check features specific to the user (probably based on Profile.settings['enabled_features']).

Docs will need to be updated accordingly.

reviewboard/features/checkers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"Feature checker"
```
reviewboard/features/checkers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Too many "setting"s.
```
reviewboard/features/checkers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
reviewboard.site.models (not "sites").
```
reviewboard/features/checkers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
**kwargs
```

Change Summary:

Addressed David & Christian's issues

Diff:

Revision 3 (+180 -4)

Show changes

	reviewboard/settings.py
	reviewboard/features/__init__.py
	reviewboard/features/checkers.py
	reviewboard/features/tests.py
	reviewboard/reviews/detail.py
	reviewboard/reviews/views.py
	reviewboard/site/models.py
	reviewboard/site/evolutions/__init__.py
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/features/checkers.py
    reviewboard/reviews/detail.py
    reviewboard/site/models.py
    reviewboard/site/evolutions/__init__.py
    reviewboard/site/evolutions/localsite_extra_data.py
    reviewboard/features/tests.py

Ignored Files:
    reviewboard/features/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/features/checkers.py
    reviewboard/reviews/detail.py
    reviewboard/site/models.py
    reviewboard/site/evolutions/__init__.py
    reviewboard/site/evolutions/localsite_extra_data.py
    reviewboard/features/tests.py

Ignored Files:
    reviewboard/features/__init__.py

reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Diff:

Revision 4 (+178 -6)

Show changes

	reviewboard/settings.py
	reviewboard/features/__init__.py
	reviewboard/features/checkers.py
	reviewboard/features/tests.py
	reviewboard/reviews/detail.py
	reviewboard/reviews/views.py
	reviewboard/site/models.py
	reviewboard/site/evolutions/__init__.py
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/features/checkers.py
    reviewboard/reviews/detail.py
    reviewboard/site/models.py
    reviewboard/site/evolutions/__init__.py
    reviewboard/site/evolutions/localsite_extra_data.py
    reviewboard/features/tests.py

Ignored Files:
    reviewboard/features/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/features/checkers.py
    reviewboard/reviews/detail.py
    reviewboard/site/models.py
    reviewboard/site/evolutions/__init__.py
    reviewboard/site/evolutions/localsite_extra_data.py
    reviewboard/features/tests.py

Ignored Files:
    reviewboard/features/__init__.py

reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (7e9928b)