Allow Features to disable web API resources
Review Request #8470 — Created Oct. 17, 2016 and submitted
Review Board web API resources now have a
required_featuresattribute
which indicates which features must be enabled for the feature to be
available. If any of the listed features are disabled, the resource will
return a 403 Forbidden error for any of the resource's methods. When all
features are enabled, the resource will behave as normal.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Col: 1 W391 blank line at end of file |
 reviewbot
|
|
|
'Feature' imported but unused |
reviewbot
|
|
|
Col: 21 E126 continuation line over-indented for hanging indent |
reviewbot
|
|
|
redefinition of unused 'test_disabled_feature_get_list' from line 125 |
reviewbot
|
|
|
redefinition of unused 'test_disabled_feature_get' from line 131 |
reviewbot
|
|
|
Col: 23 E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 25 E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
This should also state that this is optional and what the default behavior is. |
 chipx86
|
|
|
The docs make this seem like the function is all about features. I think the summary and description should start … |
chipx86
|
|
|
Blank line after the docstring. |
 david
|
|
|
Blank line after the docstring. |
david
|
|
|
Blank line here. |
chipx86
|
|
|
Private methods go last. |
chipx86
|
|
|
The suspense is killing me. |
david
|
|
|
No blank line here. |
chipx86
|
|
|
Typo: specied. |
david
|
-
Tool: Pyflakes Processed Files: reviewboard/webapi/base.py reviewboard/webapi/tests/test_base.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/base.py reviewboard/webapi/tests/test_base.py
-
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/base.py reviewboard/webapi/tests/test_base.py Tool: Pyflakes Processed Files: reviewboard/webapi/base.py reviewboard/webapi/tests/test_base.py -
-
reviewboard/webapi/tests/test_base.py (Diff revision 3) Col: 21 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_base.py (Diff revision 3) redefinition of unused 'test_disabled_feature_get_list' from line 125
-
reviewboard/webapi/tests/test_base.py (Diff revision 3) redefinition of unused 'test_disabled_feature_get' from line 131
-
reviewboard/webapi/tests/test_base.py (Diff revision 3) Col: 23 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/webapi/tests/test_base.py (Diff revision 3) Col: 25 E251 unexpected spaces around keyword / parameter equals
-
Tool: Pyflakes Processed Files: reviewboard/webapi/base.py reviewboard/webapi/tests/test_base.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/base.py reviewboard/webapi/tests/test_base.py
-
Mind making a change to use this for the status updates resource?
-
-
-
-
-
reviewboard/webapi/base.py (Diff revision 4) This should also state that this is optional and what the default behavior is.
-
reviewboard/webapi/base.py (Diff revision 4) The docs make this seem like the function is all about features. I think the summary and description should start off by just saying what
call_method_viewdoes, generally. Then it can modify that by talking about features, and about API policies (because this method ultimately takes that into account as well, even though the code in this block of code doesn't itself address it). -
-
-
Tool: Pyflakes Processed Files: reviewboard/webapi/base.py reviewboard/webapi/tests/test_base.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/base.py reviewboard/webapi/tests/test_base.py