Summary

Use registries for hosting services

Review Request #7786 — Created Nov. 30, 2015 and submitted Dec. 15, 2015, 5:42 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.6.x

Bugs

Depends On

~~7785~~

Blocks

7795

Reviewers

Groups

reviewboard

People

Description

Hosting services now use Djblets registries for managing the set of
services. The external API remains unchanged. The handling of URL
patterns has also been refactored into the HostingServiceRegistry.

Testing Done


Ran unit tests.

Issues

Description	From	Last Updated
Col: 29 E131 continuation line unaligned for hanging indent	reviewbot	Nov. 30, 2015, 11:55 p.m.
Docstring?	david	Dec. 11, 2015, 4:34 p.m.
Docstring?	david	Dec. 11, 2015, 4:35 p.m.
Can we call this variable _hosting_service_registry to match the type?	david	Dec. 11, 2015, 4:35 p.m.
"Return" instead of "Get"	david	Dec. 11, 2015, 4:35 p.m.
Can you change this to be "Return" instead of "Retrieves"?	david	Dec. 11, 2015, 4:35 p.m.
"Register"	david	Dec. 11, 2015, 4:35 p.m.
This should use symbolic keys.	david	Dec. 11, 2015, 6:46 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py

reviewboard/hostingsvcs/service.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 29
 E131 continuation line unaligned for hanging indent
```

Change Summary:

PEP8

Diff:

Revision 2 (+79 -64)

Show changes

	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py

Diff:

Revision 3 (+78 -64)

Show changes

	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py

Diff:

Revision 4 (+78 -64)

Show changes

	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py

Change Summary:

Rebase

Diff:

Revision 5 (+92 -63)

Show changes

	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py

Diff:

Revision 6 (+94 -65)

Show changes

	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py

reviewboard/hostingsvcs/service.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Docstring?
```
reviewboard/hostingsvcs/service.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Docstring?
```
reviewboard/hostingsvcs/service.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Can we call this variable _hosting_service_registry to match the type?
```
reviewboard/hostingsvcs/service.py (Diff revision 6)
The issue has been resolved. Show all issues
```
"Return" instead of "Get"
```
reviewboard/hostingsvcs/service.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Can you change this to be "Return" instead of "Retrieves"?
```
reviewboard/hostingsvcs/service.py (Diff revision 6)
The issue has been resolved. Show all issues
```
"Register"
```

Change Summary:

Address David's issues.

Diff:

Revision 7 (+275 -111)

Show changes

	reviewboard/hostingsvcs/service.py
	reviewboard/registries/registry.py
	reviewboard/reviews/fields.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/registry.py
    reviewboard/hostingsvcs/service.py



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/registry.py
    reviewboard/hostingsvcs/service.py

Change Summary:

Upload correct patch

Diff:

Revision 8 (+25 -10)

Show changes

reviewboard/hostingsvcs/service.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/service.py

Change Summary:

Once more

Diff:

Revision 9 (+111 -67)

Show changes

	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py

reviewboard/hostingsvcs/service.py (Diff revision 9)
The issue has been resolved. Show all issues
```
This should use symbolic keys.
```

Change Summary:

Address David's issue

Diff:

Revision 10 (+113 -67)

Show changes

	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py

Change Summary:

Translation support

Diff:

Revision 11 (+117 -67)

Show changes

	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests.py
    reviewboard/hostingsvcs/service.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.6.x (bb9b076)