Use registries for hosting services

Review Request #7786 — Created Nov. 30, 2015 and submitted

Information

Review Board
release-2.6.x

Reviewers

Hosting services now use Djblets registries for managing the set of
services. The external API remains unchanged. The handling of URL
patterns has also been refactored into the HostingServiceRegistry.

  • Ran unit tests.
Description From Last Updated

Col: 29 E131 continuation line unaligned for hanging indent

reviewbotreviewbot

Docstring?

daviddavid

Docstring?

daviddavid

Can we call this variable _hosting_service_registry to match the type?

daviddavid

"Return" instead of "Get"

daviddavid

Can you change this to be "Return" instead of "Retrieves"?

daviddavid

"Register"

daviddavid

This should use symbolic keys.

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
  2. reviewboard/hostingsvcs/service.py (Diff revision 1)
     
     
    Show all issues
    Col: 29
     E131 continuation line unaligned for hanging indent
    
  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/hostingsvcs/service.py (Diff revision 6)
     
     
    Show all issues

    Docstring?

  3. reviewboard/hostingsvcs/service.py (Diff revision 6)
     
     
    Show all issues

    Docstring?

  4. reviewboard/hostingsvcs/service.py (Diff revision 6)
     
     
    Show all issues

    Can we call this variable _hosting_service_registry to match the type?

  5. reviewboard/hostingsvcs/service.py (Diff revision 6)
     
     
    Show all issues

    "Return" instead of "Get"

  6. reviewboard/hostingsvcs/service.py (Diff revision 6)
     
     
    Show all issues

    Can you change this to be "Return" instead of "Retrieves"?

  7. reviewboard/hostingsvcs/service.py (Diff revision 6)
     
     
    Show all issues

    "Register"

  8. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/registry.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/registry.py
        reviewboard/hostingsvcs/service.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/service.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/hostingsvcs/service.py (Diff revision 9)
     
     
     
     
     
     
     
    Show all issues

    This should use symbolic keys.

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests.py
        reviewboard/hostingsvcs/service.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.6.x (bb9b076)