Use registries for review request fields and field sets

Review Request #7795 — Created Dec. 3, 2015 and submitted

brennie
Review Board
release-2.6.x
7786
reviewboard

Review request fields and fieldsets are now registered via registry
objects, however the external API has not changed.

A new Registry has been created that subclasses Djblet's Registry that
will never throw an ItemLookupError -- this is used becuase all Review
Board registries follow this pattern.

Ran unit tests.

Description From Last Updated

'EntryPointRegistry' imported but unused

reviewbotreviewbot

'Registry' imported but unused

reviewbotreviewbot

'EntryPointRegistry' imported but unused

reviewbotreviewbot

'Registry' imported but unused

reviewbotreviewbot

This should use symbolic names.

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    
  2. reviewboard/registries/__init__.py (Diff revision 1)
     
     
     'EntryPointRegistry' imported but unused
    
  3. reviewboard/registries/__init__.py (Diff revision 1)
     
     
     'Registry' imported but unused
    
  4. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    
  2. reviewboard/registries/__init__.py (Diff revision 2)
     
     
     'EntryPointRegistry' imported but unused
    
  3. reviewboard/registries/__init__.py (Diff revision 2)
     
     
     'Registry' imported but unused
    
  4. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/registry.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/registry.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 3)
     
     
     
     
     

    This should use symbolic names.

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/registry.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/registries/registry.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.6.x (38a0060)
Loading...