Summary

Use registries for review request fields and field sets

Review Request #7795 — Created Dec. 3, 2015 and submitted Dec. 15, 2015, 5:42 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.6.x

Bugs

Depends On

~~7786~~

Reviewers

Groups

reviewboard

People

Description

Review request fields and fieldsets are now registered via registry
objects, however the external API has not changed.

A new Registry has been created that subclasses Djblet's Registry that
will never throw an ItemLookupError -- this is used becuase all Review
Board registries follow this pattern.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
'EntryPointRegistry' imported but unused	reviewbot	Dec. 3, 2015, 4:49 p.m.
'Registry' imported but unused	reviewbot	Dec. 3, 2015, 4:49 p.m.
'EntryPointRegistry' imported but unused	reviewbot	Dec. 8, 2015, 12:13 p.m.
'Registry' imported but unused	reviewbot	Dec. 8, 2015, 12:13 p.m.
This should use symbolic names.	david	Dec. 11, 2015, 6:48 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py

reviewboard/registries/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'EntryPointRegistry' imported but unused
```
reviewboard/registries/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'Registry' imported but unused
```

Change Summary:

Rebase

Diff:

Revision 2 (+252 -103)

Show changes

	reviewboard/registries/__init__.py
	reviewboard/registries/registry.py
	reviewboard/reviews/fields.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py

reviewboard/registries/__init__.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'EntryPointRegistry' imported but unused
```
reviewboard/registries/__init__.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'Registry' imported but unused
```

Change Summary:

Rebase

Diff:

Revision 3 (+250 -101)

Show changes

	reviewboard/registries/registry.py
	reviewboard/reviews/fields.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/registry.py



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/registry.py

reviewboard/reviews/fields.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This should use symbolic names.
```

Change Summary:

Address David's issues

Diff:

Revision 4 (+251 -101)

Show changes

	reviewboard/registries/registry.py
	reviewboard/reviews/fields.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/registry.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/registry.py

Change Summary:

Translation support

Diff:

Revision 5 (+257 -101)

Show changes

	reviewboard/registries/registry.py
	reviewboard/reviews/fields.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/registry.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/registries/registry.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.6.x (38a0060)