Use registries for authentication backends

Review Request #7785 — Created Nov. 30, 2015 and submitted

Information

Review Board
release-2.6.x

Reviewers

Authentication backends now use Djblets registries for managing the set
of backends. The external API remains unchanged.

There is now a reviewboard.registries module that contains a
specialized registry that populates from an entry point.

Since registries are in Djblets 0.10.x, this updates Review Board to
depend on that version of Djblets.

  • Ran unit tests.
Description From Last Updated

'EntryPointRegistry' imported but unused

reviewbotreviewbot

'EntryPointRegistry' imported but unused

reviewbotreviewbot

'EntryPointRegistry' imported but unused

reviewbotreviewbot

Docstring?

daviddavid

Docstring?

daviddavid

Docstring?

daviddavid

'EntryPointRegistry' imported but unused

reviewbotreviewbot

This should be __all__, not __ALL__

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
    
    
  2. reviewboard/registries/__init__.py (Diff revision 1)
     
     
     'EntryPointRegistry' imported but unused
    
  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
    
    
  2. reviewboard/registries/__init__.py (Diff revision 2)
     
     
     'EntryPointRegistry' imported but unused
    
  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
    
    
  2. reviewboard/registries/__init__.py (Diff revision 3)
     
     
     'EntryPointRegistry' imported but unused
    
  3. 
      
brennie
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/__init__.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
    
    
  2. reviewboard/registries/__init__.py (Diff revision 4)
     
     
     'EntryPointRegistry' imported but unused
    
  3. 
      
david
  1. 
      
  2. reviewboard/accounts/backends.py (Diff revision 4)
     
     

    Docstring?

  3. reviewboard/accounts/backends.py (Diff revision 4)
     
     

    Docstring?

  4. reviewboard/accounts/backends.py (Diff revision 4)
     
     

    Docstring?

  5. reviewboard/registries/__init__.py (Diff revision 4)
     
     

    This should be __all__, not __ALL__

  6. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
        reviewboard/registries/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
        reviewboard/registries/__init__.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
        reviewboard/registries/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
        reviewboard/registries/__init__.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/backends.py
        setup.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
        reviewboard/registries/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/backends.py
        setup.py
        reviewboard/registries/registry.py
    
    Ignored Files:
        reviewboard/registries/tests.py
        reviewboard/registries/__init__.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.6.x (ebc1240)
Loading...