Summary

Allow diff generation starting at a base commit

Review Request #7322 — Created May 21, 2015 and submitted May 23, 2015, 4:53 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

~~7326~~, ~~7325~~

Blocks

7323

Commit

0bd661f...

Reviewers

Groups

reviewboard

People

Description

The diffviewer can now generate a commit starting at a certain commit.
This allows the diffs of individual commits in a commit history to be
viewed, as well as spans of commits.

This change also updates the WebAPI's DiffContextResource so that the
commit selection UI can request ranges of commits instead of the entire
history.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Should this be run through gettext?	david	May 21, 2015, 6:26 p.m.
local variable 'commit_dag' is assigned to but never used	reviewbot	May 21, 2015, 6:30 p.m.
Leftover debug output?	david	May 21, 2015, 6:26 p.m.
Undo	brennie	May 21, 2015, 6:26 p.m.
a is None and b is None.	brennie	May 21, 2015, 6:28 p.m.
Remove debugging code.	brennie	May 21, 2015, 6:28 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/diff_context.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/renderers.py
    reviewboard/diffviewer/models.py
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/views.py
    reviewboard/diffviewer/commitutils.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/diff_context.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/renderers.py
    reviewboard/diffviewer/models.py
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/views.py
    reviewboard/diffviewer/commitutils.py

reviewboard/diffviewer/commitutils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'commit_dag' is assigned to but never used
```

reviewboard/diffviewer/chunk_generator.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should this be run through gettext?
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Leftover debug output?
```

reviewboard/diffviewer/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Undo
```
reviewboard/webapi/resources/diff_context.py (Diff revision 1)
The issue has been resolved. Show all issues
```
a is None and b is None.
```
reviewboard/webapi/resources/diff_context.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Remove debugging code.
```

Change Summary:

This change has been split up into several changes.

Summary:

[WIP] Backend for commit selection UI

Allow diff generation starting at a base commit

Description:

~		Backend for commit selection UI
	~	The diffviewer can now generate a commit starting at a certain commit.
	+	This allows the diffs of individual commits in a commit history to be
	+	viewed, as well as spans of commits.
	+
	+	This change also updates the WebAPI's `DiffContextResource` so that the
	+	commit selection UI can request ranges of commits instead of the entire
	+	history.

Testing Done:

~		TODO.
	~	Ran unit tests.

Depends On:

~~7325 - Add utility to find commit intervals~~

~~7326 - Allow finding ancestors in commit intervals~~

Diff:

Revision 2 (+129 -70)

Show changes

	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/renderers.py
	reviewboard/diffviewer/views.py
	reviewboard/reviews/views.py
	reviewboard/webapi/resources/diff_context.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/diff_context.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/renderers.py
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/views.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/diff_context.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/renderers.py
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/views.py

Ship it!

In your description, "The diffviewer can now generate a commit starting at a certain commit" doesn't really make sense. I think you mean generate a diff starting at a certain commit?

Status:: Completed
Change Summary:: Pushed to dvcs (814736b)