Allow diff generation starting at a base commit

Review Request #7322 — Created May 20, 2015 and submitted

Information

Review Board
dvcs
0bd661f...

Reviewers

The diffviewer can now generate a commit starting at a certain commit.
This allows the diffs of individual commits in a commit history to be
viewed, as well as spans of commits.

This change also updates the WebAPI's DiffContextResource so that the
commit selection UI can request ranges of commits instead of the entire
history.

Ran unit tests.

Description From Last Updated

Should this be run through gettext?

daviddavid

local variable 'commit_dag' is assigned to but never used

reviewbotreviewbot

Leftover debug output?

daviddavid

Undo

brenniebrennie

a is None and b is None.

brenniebrennie

Remove debugging code.

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/diff_context.py
        reviewboard/diffviewer/chunk_generator.py
        reviewboard/diffviewer/renderers.py
        reviewboard/diffviewer/models.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/diffviewer/views.py
        reviewboard/diffviewer/commitutils.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/diff_context.py
        reviewboard/diffviewer/chunk_generator.py
        reviewboard/diffviewer/renderers.py
        reviewboard/diffviewer/models.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/diffviewer/views.py
        reviewboard/diffviewer/commitutils.py
    
    
  2. reviewboard/diffviewer/commitutils.py (Diff revision 1)
     
     
     local variable 'commit_dag' is assigned to but never used
    
  3. 
      
david
  1. 
      
  2. Should this be run through gettext?

  3. reviewboard/diffviewer/diffutils.py (Diff revision 1)
     
     

    Leftover debug output?

  4. 
      
brennie
  1. 
      
  2. reviewboard/diffviewer/models.py (Diff revision 1)
     
     
  3. a is None and b is None.

  4. reviewboard/webapi/resources/diff_context.py (Diff revision 1)
     
     
     
     

    Remove debugging code.

  5. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/diff_context.py
        reviewboard/diffviewer/chunk_generator.py
        reviewboard/diffviewer/renderers.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/diffviewer/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/diff_context.py
        reviewboard/diffviewer/chunk_generator.py
        reviewboard/diffviewer/renderers.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/diffviewer/views.py
    
    
  2. 
      
david
  1. In your description, "The diffviewer can now generate a commit starting at a certain commit" doesn't really make sense. I think you mean generate a diff starting at a certain commit?

  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (814736b)
Loading...