Summary

Allow finding ancestors in commit intervals

Review Request #7326 — Created May 22, 2015 and submitted May 22, 2015, 9:53 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

~~7328~~

Blocks

7322

Reviewers

Groups

reviewboard

People

Description

The find_oldest_filediff_ancestor utility function can now find

ancestor FileDiffs in commit intervals, as well as the oldest

ancestor commit. As such, it has been renamed to

find_ancestor_filediff. Unit tests have been added for both the new

and old behaviour of this function.
A new utility function, find_ancestor_commit_ids, was added to allow

this behaviour. A unit test has been added for this behaviour.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
local variable 'f2' is assigned to but never used	reviewbot	May 22, 2015, 11:36 a.m.
local variable 'f3' is assigned to but never used	reviewbot	May 22, 2015, 11:36 a.m.
local variable 'f4' is assigned to but never used	reviewbot	May 22, 2015, 11:36 a.m.
local variable 'f1' is assigned to but never used	reviewbot	May 22, 2015, 11:36 a.m.
Col: 40 E127 continuation line over-indented for visual indent	reviewbot	May 22, 2015, 11:37 a.m.
Col: 40 E127 continuation line over-indented for visual indent	reviewbot	May 22, 2015, 11:37 a.m.
Col: 9 E303 too many blank lines (2)	reviewbot	May 22, 2015, 11:37 a.m.
local variable 'f2' is assigned to but never used	reviewbot	May 22, 2015, 11:37 a.m.
Col: 9 E303 too many blank lines (2)	reviewbot	May 22, 2015, 11:37 a.m.
Remove this	brennie	May 22, 2015, 6:03 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/commitutils.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/commitutils.py

reviewboard/diffviewer/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'f2' is assigned to but never used
```
reviewboard/diffviewer/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'f3' is assigned to but never used
```
reviewboard/diffviewer/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'f4' is assigned to but never used
```
reviewboard/diffviewer/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'f1' is assigned to but never used
```
reviewboard/diffviewer/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 40
 E127 continuation line over-indented for visual indent
```
reviewboard/diffviewer/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 40
 E127 continuation line over-indented for visual indent
```
reviewboard/diffviewer/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 9
 E303 too many blank lines (2)
```
reviewboard/diffviewer/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'f2' is assigned to but never used
```
reviewboard/diffviewer/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 9
 E303 too many blank lines (2)
```

Change Summary:

PEP8

Diff:

Revision 2 (+327 -15)

Show changes

	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/commitutils.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/commitutils.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/commitutils.py

Ship it!

```
Ship It!
```

reviewboard/diffviewer/commitutils.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Remove this
```

Diff:

Revision 3 (+326 -15)

Show changes

	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/commitutils.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/commitutils.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/commitutils.py

Status:: Completed
Change Summary:: Pushed to dvcs (60d4d4c)