Add diff commit selection UI to diffviewer
Review Request #7323 — Created May 20, 2015 and submitted
The diffviewer can now select two commits in a commit history to
generate a diff between. This currently does not support inter-commit
diffs and the UI is disabled in that case.
Manually tested commit generation between individual commits and for
spans of commits.Manually verified the commit selection UI is not shown for interdiffs.
| Description | From | Last Updated |
|---|---|---|
|
Remove this debugging code. |
 brennie
|
|
|
We need to pass these in as variables to the template, because the gettext scanner won't recognize this when it … |
 david
|
|
|
Undo |
brennie
|
|
|
Undo |
brennie
|
|
|
=== |
brennie
|
|
|
This should be moved into the base === 0 case. |
brennie
|
|
|
Refactor. |
brennie
|
|
|
This can use shouldUpdate |
david
|
- Change Summary:
-
Move out of WIP. Address issues.
- Summary:
-
[WIP] Frontend for the commit selection UIAdd diff commit selection UI to diffviewer
- Description:
-
~ Frontend for the commit selection UI
~ The diffviewer can now select two commits in a commit history to
+ generate a diff between. This currently does not support inter-commit + diffs and the UI is disabled in that case. - Testing Done:
-
~ TODO.
~ Manually tested commit generation between individual commits and for
+ spans of commits. + + Manually verified the commit selection UI is not shown for interdiffs.
- Change Summary:
-
Forgot the diff :)
- Diff:
-
Revision 2 (+410 -122)
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/diff_context.py reviewboard/diffviewer/chunk_generator.py reviewboard/diffviewer/renderers.py reviewboard/diffviewer/diffutils.py reviewboard/diffviewer/views.py Ignored Files: reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js reviewboard/static/rb/js/pages/models/diffViewerPageModel.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/diff_context.py reviewboard/diffviewer/chunk_generator.py reviewboard/diffviewer/renderers.py reviewboard/diffviewer/diffutils.py reviewboard/diffviewer/views.py Ignored Files: reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js reviewboard/static/rb/js/pages/models/diffViewerPageModel.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js reviewboard/static/rb/js/pages/models/diffViewerPageModel.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js reviewboard/static/rb/js/pages/models/diffViewerPageModel.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js
-
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js reviewboard/static/rb/js/pages/models/diffViewerPageModel.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js reviewboard/static/rb/js/pages/models/diffViewerPageModel.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js
Tool: Pyflakes Processed Files: reviewboard/diffviewer/views.py Ignored Files: reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js reviewboard/static/rb/js/pages/models/diffViewerPageModel.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/views.py Ignored Files: reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js reviewboard/static/rb/js/pages/models/diffViewerPageModel.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js