Add diff commit selection UI to diffviewer

Review Request #7323 — Created May 20, 2015 and submitted

Information

Review Board
dvcs

Reviewers

The diffviewer can now select two commits in a commit history to
generate a diff between. This currently does not support inter-commit
diffs and the UI is disabled in that case.

Manually tested commit generation between individual commits and for
spans of commits.

Manually verified the commit selection UI is not shown for interdiffs.

Description From Last Updated

Remove this debugging code.

brenniebrennie

We need to pass these in as variables to the template, because the gettext scanner won't recognize this when it …

daviddavid

Undo

brenniebrennie

Undo

brenniebrennie

===

brenniebrennie

This should be moved into the base === 0 case.

brenniebrennie

Refactor.

brenniebrennie

This can use shouldUpdate

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/views.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/views.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
brennie
  1. 
      
  2. reviewboard/diffviewer/views.py (Diff revision 1)
     
     
     
     
    Show all issues

    Remove this debugging code.

  3. 
      
david
  1. 
      
  2. Show all issues

    We need to pass these in as variables to the template, because the gettext scanner won't recognize this when it extracts the strings.

  3. 
      
brennie
  1. 
      
  2. Show all issues

    Undo

  3. Show all issues

    Undo

  4. Show all issues

    ===

  5. reviewboard/static/rb/js/pages/views/diffViewerPageView.js (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    This should be moved into the base === 0 case.

  6. reviewboard/static/rb/js/pages/views/diffViewerPageView.js (Diff revision 1)
     
     
     
     
     
     
     
    Show all issues

    Refactor.

  7. 
      
brennie
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/diff_context.py
        reviewboard/diffviewer/chunk_generator.py
        reviewboard/diffviewer/renderers.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/diffviewer/views.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/diff_context.py
        reviewboard/diffviewer/chunk_generator.py
        reviewboard/diffviewer/renderers.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/diffviewer/views.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
david
  1. 
      
  2. Show all issues

    This can use shouldUpdate

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (4ca8774)
Loading...