Summary

Provide automatic unarchiving when a user publishes review requests, reviews or review replies

Review Request #7088 — Created March 19, 2015 and submitted May 1, 2015, 7:42 p.m.

Information

Owner

cristocrat

Repository

Review Board

Branch

master

Bugs

Depends On

~~7086~~

Commit

9d47c54...

Reviewers

Groups

reviewboard, students

People

Description

Added automatic unarchiving.

A review request becomes unarchived when a user publishes a new review request, a review or a review reply.

Testing Done

Manual testing:

archived review requests become unarchived when there is new activity
visible and muted review requests remain muted when there is new activity
"new activity" = when a user (not necessarily the "archiver") publishes a draft, review or reply for the review request in question

Issues

Description	From	Last Updated
Col: 21 E126 continuation line over-indented for hanging indent	reviewbot	April 1, 2015, 1:57 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 1, 2015, 1:57 a.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	March 24, 2015, 12:23 p.m.
Col: 7 E111 indentation is not a multiple of four	reviewbot	March 24, 2015, 12:23 p.m.
djblets imports go in the same import group as django imports (as they are both considered 3rd party to this …	brennie	April 1, 2015, 1:57 a.m.
(from David) Can you add docstrings for the class and method?	CR cristocrat	March 24, 2015, 12:38 p.m.
(from David) Please add visibility=self.model.ARCHIVED to the filter call (we don't want to update muted review requests).	CR cristocrat	March 24, 2015, 12:33 p.m.
Col: 21 E126 continuation line over-indented for hanging indent	reviewbot	April 1, 2015, 1:57 a.m.
(from David) Please add a blank line after the docstring.	CR cristocrat	April 1, 2015, 1:57 a.m.
"inherits from"	brennie	April 1, 2015, 1:57 a.m.
(from David) review_published and reply_published pass a Review instance as their argument rather than a ReviewRequest. You'll need a separate …	CR cristocrat	April 1, 2015, 1:57 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 1, 2015, 1:57 a.m.
(from David) I think djblets.util.http.get_url_params_except will do what you want.	CR cristocrat	April 1, 2015, 1:57 a.m.
Col: 7 E111 indentation is not a multiple of four	reviewbot	March 24, 2015, 12:33 p.m.
(from David) Please don't change the signatures of these, and instead have a separate handler.	CR cristocrat	April 1, 2015, 1:57 a.m.
Col: 21 E126 continuation line over-indented for hanging indent	reviewbot	April 1, 2015, 1:57 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 1, 2015, 1:57 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 1, 2015, 1:57 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 1, 2015, 1:57 a.m.
This must be in the following form: """One-line summary. Multi-line description. """	chipx86	April 2, 2015, 2:06 p.m.
This is hard to read. Best to split it off into two statements: queryset = self.filter(...) queryset.update(...)	chipx86	April 2, 2015, 2:07 p.m.
Update these to pass review.review_request_id and reply.review_request_id to avoid a possible unnecessary fetch of the review request from the database. …	chipx86	April 2, 2015, 2:10 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/datagrids/views.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/evolutions/reviewrequestvisit_visibility.py
    reviewboard/accounts/managers.py
    reviewboard/accounts/models.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/datagrids/hideable_review_request_listview.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/css/common.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/datagrids/views.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/evolutions/reviewrequestvisit_visibility.py
    reviewboard/accounts/managers.py
    reviewboard/accounts/models.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/datagrids/hideable_review_request_listview.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/css/common.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js

reviewboard/accounts/managers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 21
 E126 continuation line over-indented for hanging indent
```
reviewboard/accounts/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/datagrids/grids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/datagrids/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 7
 E111 indentation is not a multiple of four
```

Summary:

-	Provides automatic unarchiving when a user publishes review requests, reviews or review replies.
+	Provide automatic unarchiving when a user publishes review requests, reviews or review replies.

Summary:

-	Provide automatic unarchiving when a user publishes review requests, reviews or review replies.
+	[WIP] Provide automatic unarchiving when a user publishes review requests, reviews or review replies.

Depends On:

+	~~7087 - Add webAPI resources for archived and muted review requests~~

Diff:

Revision 2 (+36 -9)

Show changes

	reviewboard/accounts/managers.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/signals.py
	reviewboard/reviews/models/review.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/managers.py
    reviewboard/datagrids/views.py
    reviewboard/reviews/signals.py
    reviewboard/accounts/models.py
    reviewboard/reviews/models/review.py



Tool: Pyflakes
Processed Files:
    reviewboard/accounts/managers.py
    reviewboard/datagrids/views.py
    reviewboard/reviews/signals.py
    reviewboard/accounts/models.py
    reviewboard/reviews/models/review.py

reviewboard/accounts/managers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 21
 E126 continuation line over-indented for hanging indent
```
reviewboard/accounts/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/datagrids/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 7
 E111 indentation is not a multiple of four
```

reviewboard/accounts/managers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
(from David) Can you add docstrings for the class and method?
```

reviewboard/accounts/managers.py (Diff revision 2)

The issue has been resolved. Show all issues

(from David) Please add visibility=self.model.ARCHIVED to the filter call (we don't want to update muted review requests).

reviewboard/accounts/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
(from David) Please add a blank line after the docstring.
```

reviewboard/accounts/models.py (Diff revision 2)

The issue has been resolved. Show all issues

(from David) review_published and reply_published pass a Review instance as their argument rather than a ReviewRequest. You'll need a separate handler for those signals which accesses review.review_request

reviewboard/datagrids/views.py (Diff revision 2)

The issue has been resolved. Show all issues

(from David) I think djblets.util.http.get_url_params_except will do what you want.

reviewboard/reviews/signals.py (Diff revision 2)

The issue has been resolved. Show all issues

(from David) Please don't change the signatures of these, and instead have a separate handler.

reviewboard/accounts/managers.py (Diff revision 2)

The issue has been resolved. Show all issues

djblets imports go in the same import group as django imports (as they are both considered 3rd party to this project).

reviewboard/accounts/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"inherits from"
```

Diff:

Revision 3 (+43 -13)

Show changes

	reviewboard/accounts/managers.py
	reviewboard/accounts/models.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/managers.py
    reviewboard/accounts/models.py



Tool: Pyflakes
Processed Files:
    reviewboard/accounts/managers.py
    reviewboard/accounts/models.py

reviewboard/accounts/managers.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 21
 E126 continuation line over-indented for hanging indent
```
reviewboard/accounts/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/accounts/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/accounts/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Summary:

-	[WIP] Provide automatic unarchiving when a user publishes review requests, reviews or review replies.
+	Provide automatic unarchiving when a user publishes review requests, reviews or review replies

Testing Done:

	+	Manual testing:
	+
	+	archived review requests become unarchived when there is new activity
	+	visible and muted review requests remain muted when there is new activity
	+	"new activity" = when a user (not necessarily the "archiver") publishes a draft, review or reply for the review request in question

Depends On:

-	~~7087 - Add webAPI resources for archived and muted review requests~~
+	~~7086 - Add UI to archive and mute review requests with dashboard filters~~

Groups:

+	students

Diff:

Revision 4 (+40 -5)

Show changes

	reviewboard/accounts/managers.py
	reviewboard/accounts/models.py

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/managers.py
    reviewboard/accounts/models.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/managers.py
    reviewboard/accounts/models.py

reviewboard/accounts/managers.py (Diff revision 4)

The issue has been resolved. Show all issues

This must be in the following form:

"""One-line summary.

Multi-line description.
"""

reviewboard/accounts/managers.py (Diff revision 4)

The issue has been resolved. Show all issues

This is hard to read. Best to split it off into two statements:

queryset = self.filter(...)
queryset.update(...)

reviewboard/accounts/models.py (Diff revision 4)

The issue has been resolved. Show all issues

Update these to pass review.review_request_id and reply.review_request_id to avoid a possible unnecessary fetch of the review request from the database. It will Just Work with the unarchive_all(), since the query being performed accepts either an object or an ID.

Diff:

Revision 5 (+43 -5)

Show changes

	reviewboard/accounts/managers.py
	reviewboard/accounts/models.py

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/managers.py
    reviewboard/accounts/models.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/managers.py
    reviewboard/accounts/models.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (9046dcc)