Summary

Add UI to archive and mute review requests with dashboard filters

Review Request #7086 — Created March 19, 2015 and submitted May 1, 2015, 5:27 p.m.

Information

Owner

cristocrat

Repository

Review Board

Branch

master

Bugs

Depends On

~~7087~~

Blocks

7088

Commit

50295d6...

Reviewers

Groups

reviewboard, students

People

Description

This adds the following UI:

archive and mute buttons in a Hide dropdown menu in a review request view
banner that indicates that review request is archived with an unarchive button
banner that indicates that review request is muted with an unmute button

Review request visibility is now passed as context data to templates. If visibility is VISIBLE, the Hide dropdown menu becomes visibile. If visibility is ARCHIVED or MUTED, the Hide dropdown menu is hidden and the appropriate archive or mute banner appears. When visibility is changed, a page refresh is triggered.

This also augments the UserSession WatchedItem (renamed StoredItem) to also include archivedReviewRequests and mutedReviewRequests. The only difference these objects are their URL and their error messages (addError and removeError methods were added in order to set different errors).

Testing Done

Archived and mute banner tests were added to reviewRequestEditorViewTests.js, all tests passed.

Files

Issues

Description	From	Last Updated
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	March 28, 2015, 12:34 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	March 24, 2015, 12:37 p.m.
Can you change this to be a single quoted string?	brennie	March 25, 2015, 4:48 p.m.
This doesn't make sense grammatically.	brennie	March 25, 2015, 8:53 p.m.
Undo this change.	brennie	March 25, 2015, 4:48 p.m.
"a Hidden Items resource"	brennie	March 25, 2015, 4:49 p.m.
(from David) I don't understand what the visibility attribute is used for. Can you explain?	CR cristocrat	March 25, 2015, 8:52 p.m.
Remove this line.	brennie	March 25, 2015, 4:49 p.m.
Single quotes for all these strings.	brennie	March 25, 2015, 4:54 p.m.
(from David) Please use "review request" instead of "change"	CR cristocrat	March 25, 2015, 4:47 p.m.
(from David) Please use "review request" instead of "change"	CR cristocrat	March 25, 2015, 4:47 p.m.
Since we ignore the previous block for deciding the banner class, we should join these two blocks, with this new …	brennie	March 25, 2015, 4:51 p.m.
'A' and 'M' should be named constants.	brennie	March 25, 2015, 4:51 p.m.
Single quotes. This should be indented relative to the variable name. You can also do something like var reviewRequest = …	brennie	March 24, 2015, 12:18 a.m.
We use a single var statement at the top of each function.	brennie	March 24, 2015, 12:14 a.m.
See previous comment.	brennie	March 24, 2015, 12:19 a.m.
See previous comment re: multiline strings.	brennie	March 24, 2015, 12:19 a.m.
We use a single var statement at the top of each function.	brennie	March 24, 2015, 12:14 a.m.
We don't wrap HTML at 80.	brennie	March 25, 2015, 4:54 p.m.
We don't wrap HTML at 80.	brennie	March 25, 2015, 4:54 p.m.
Based on your usage, having this be an empty dictionary isn't right. Probably it should be None	david	March 31, 2015, 11:33 p.m.
I really don't like having this variable that third parties are expected to set. It's taken me several readings of …	david	March 31, 2015, 11:33 p.m.
Blank line between these.	chipx86	April 2, 2015, 12:24 p.m.
Probably should be None.	chipx86	April 2, 2015, 12:24 p.m.
Can you move this value before the AJAX_SERIAL one?	chipx86	April 2, 2015, 12:24 p.m.
All var statements should go at the top of the file, like: `var Item, StoredItems; ... Item = ... StoredItems …	chipx86	April 2, 2015, 12:27 p.m.
Blank line between these.	chipx86	April 2, 2015, 12:31 p.m.
What's true? This should probably pass on all the arguments instead. It also needs to pass the correct context and …	chipx86	April 2, 2015, 12:34 p.m.
Same comments as above.	chipx86	April 2, 2015, 12:34 p.m.
I don't think these belong here.	chipx86	April 2, 2015, 12:37 p.m.
function() { should be aligned with the other arguments. Same below.	chipx86	April 2, 2015, 12:37 p.m.
I'll be mentioning this in the related review request, but the API shouldn't return the internal codes for these. Instead, …	chipx86	April 2, 2015, 1 a.m.
This doesn't seem right?	chipx86	April 2, 2015, 12:39 p.m.
Same.	chipx86	April 2, 2015, 12:39 p.m.
These are only used once in the function, so rather than assigning a local variable, I'd just use them directly …	chipx86	April 2, 2015, 12:40 p.m.
One variable per line. Also, initialized variables go before uninitialized variables. Same below.	chipx86	April 2, 2015, 12:41 p.m.
The localization parser won't handle the addition of strings properly. This needs to actually be one long string (even if …	chipx86	April 2, 2015, 12:57 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/datagrids/grids.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/evolutions/reviewrequestvisit_visibility.py
    reviewboard/accounts/models.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/datagrids/hideable_review_request_listview.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/css/common.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/datagrids/grids.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/evolutions/reviewrequestvisit_visibility.py
    reviewboard/accounts/models.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/datagrids/hideable_review_request_listview.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/css/common.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js

reviewboard/datagrids/grids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```

Summary:: Adds UI to archive and mute review requests with dashboard filters.
Add UI to archive and mute review requests with dashboard filters.

Summary:: Add UI to archive and mute review requests with dashboard filters.
[WIP] Add UI to archive and mute review requests with dashboard filters.
Depends On:: ~~7085 - Add visibility field to a ReviewRequestVisit~~

Diff:

Revision 2 (+278 -50)

Show changes

	reviewboard/datagrids/grids.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/models/userSessionModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/base.html
	reviewboard/templates/datagrids/hideable_review_request_listview.html
	3 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/datagrids/grids.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/datagrids/hideable_review_request_listview.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/css/common.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/datagrids/grids.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/datagrids/hideable_review_request_listview.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/css/common.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js

reviewboard/datagrids/grids.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```

reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 2)
The issue has been dropped. Show all issues
```
(from David) I don't understand what the visibility attribute is used for. Can you explain?
```
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
(from David) Please use "review request" instead of "change"
```
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
(from David) Please use "review request" instead of "change"
```

reviewboard/reviews/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you change this to be a single quoted string?
```
reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 2)
The issue has been resolved. Show all issues
```
This doesn't make sense grammatically.
```
reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 2)
The issue has been resolved. Show all issues
```
"a Hidden Items resource"
```
reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Remove this line.
```

reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 2)

The issue has been resolved. Show all issues

Single quotes for all these strings.

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2)

The issue has been resolved. Show all issues

Since we ignore the previous block for deciding the banner class, we should join these two blocks, with this new block coming first and the prior block being else-if-ified.

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
'A' and 'M' should be named constants.
```

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2)

The issue has been resolved. Show all issues

Single quotes. This should be indented relative to the variable name.
You can also do something like

        var reviewRequest = this.model.get('reviewRequest'),
            confirmText = getText('Are you sure you want to archive this ' +
                                  'review request?');


You can also use a list of strings a .join them together, but + should be okay for just two strings.

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
We use a single var statement at the top of each function.
```
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
See previous comment.
```
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
See previous comment re: multiline strings.
```
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
We use a single var statement at the top of each function.
```
reviewboard/templates/reviews/review_header.html (Diff revision 2)
The issue has been resolved. Show all issues
```
We don't wrap HTML at 80.
```
1. CR
  
  cristocrat
  
  March 24, 2015, 12:29 a.m.
  Sorry, could you explain more? Not sure I understand
reviewboard/templates/reviews/review_header.html (Diff revision 2)
The issue has been resolved. Show all issues
```
We don't wrap HTML at 80.
```

Depends On:

~~7085 - Add visibility field to a ReviewRequestVisit~~

~~7109 - Add a Dashboard toggle to show or hide archived review requests~~

Diff:

Revision 3 (+244 -46)

Show changes

	reviewboard/reviews/views.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/models/userSessionModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/reviews/review_header.html
	reviewboard/templates/reviews/review_request_actions_secondary.html
	reviewboard/templates/reviews/reviewable_page_data.js

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

Ignored Files:
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py

Ignored Files:
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js

Summary:

[WIP] Add UI to archive and mute review requests with dashboard filters.

Add UI to archive and mute review requests with dashboard filters

Diff:

Revision 4 (+350 -46)

Show changes

	reviewboard/reviews/views.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/models/userSessionModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
	reviewboard/templates/base.html
	reviewboard/templates/reviews/review_header.html
	reviewboard/templates/reviews/review_request_actions_secondary.html
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js

Can you attach screenshots of the new UI?

reviewboard/reviews/views.py (Diff revision 4)

The issue has been resolved. Show all issues

Based on your usage, having this be an empty dictionary isn't right. Probably it should be None

reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 4)

The issue has been resolved. Show all issues

I really don't like having this variable that third parties are expected to set. It's taken me several readings of the code to figure out what it meant. How about we just make a new argument (maybe called trigger) to addImmediately / removeImmediately that causes it to trigger a changed event (based on the listener, I don't see a reason to have two different events)?

cristocrat

March 31, 2015, 9:14 a.m.

Could you go into more detail about this? I'm having trouble wrapping my head around triggers and listeners through several layers of objects and callbacks. I'm also trying to keep in mind what Christian said about how the add/remove functions should emit more general signals about items being added/removed, and pass the item in the callback.

david

March 31, 2015, 1:11 p.m.

OK, after reading this more closely, I think we should remove the visibility variable entirely. Instead of:

if (this.visibility) {
    this.trigger('hidden');
}


We should do:

this.trigger('itemAdded', item);


(and correspondingly have an itemRemoved event).
This would give us generic events that can be used for anything, and then the handler for those would interpret 'added' as "I should refresh"

Description:

~		Added Archive and Mute buttons in a Hide dropdown menu in a review request view
	~	This adds the following UI:
	+	* archive and mute buttons in a Hide dropdown menu in a review request view
	+	* banner that indicates that review request is archived with an unarchive button
	+	* banner that indicates that review request is muted with an unmute button

~		Added button handlers that communicate with the webAPI.
	~	Review request visibility is now passed as context data to templates. If visibility is VISIBLE, the Hide dropdown menu becomes visibile. If visibility is ARCHIVED or MUTED, the Hide dropdown menu is hidden and the appropriate archive or mute banner appears. When visibility is changed, a page refresh is triggered.

~		Augmented the UserSession WatchedItem (renamed StoredItem) to also include archivedReviewRequests and mutedReviewRequests. The only difference these objects are their URL and their error messages (addError and removeError methods were added in order to set different errors). Review request visibility is now passed as context data to templates.
	~	This also augments the UserSession WatchedItem (renamed StoredItem) to also include archivedReviewRequests and mutedReviewRequests. The only difference these objects are their URL and their error messages (addError and removeError methods were added in order to set different errors).
-
-		Added dashboard button that toggles between showing and hiding hiden review requests.
-
-		Added banners for archiving and muting review requests.
-
-		Archived and Muted banners appear when a review request has been archived or muted. Each banner contains a button that can unarchive or unmute the review request. All of these events trigger a page refresh.

Testing Done:

Archived and mute banner tests were added to reviewRequestEditorViewTests.js, all tests passed.

Depends On:

~~7109 - Add a Dashboard toggle to show or hide archived review requests~~

~~7087 - Add webAPI resources for archived and muted review requests~~

Groups:

students

Diff:

Revision 5 (+362 -46)

Show changes

	reviewboard/reviews/views.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/models/userSessionModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
	reviewboard/templates/base.html
	reviewboard/templates/reviews/review_header.html
	reviewboard/templates/reviews/review_request_actions_secondary.html
	1 more

Added Files:

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js

Description:: ~
This adds the following UI:
~ * archive and mute buttons in a Hide dropdown menu in a review request view
~ * banner that indicates that review request is archived with an unarchive button
~ * banner that indicates that review request is muted with an unmute button
~
This adds the following UI:
~
~
archive and mute buttons in a Hide dropdown menu in a review request view
~
banner that indicates that review request is archived with an unarchive button
+
banner that indicates that review request is muted with an unmute button

Review request visibility is now passed as context data to templates. If visibility is VISIBLE, the Hide dropdown menu becomes visibile. If visibility is ARCHIVED or MUTED, the Hide dropdown menu is hidden and the appropriate archive or mute banner appears. When visibility is changed, a page refresh is triggered.

This also augments the UserSession WatchedItem (renamed StoredItem) to also include archivedReviewRequests and mutedReviewRequests. The only difference these objects are their URL and their error messages (addError and removeError methods were added in order to set different errors).

Fix it!

reviewboard/reviews/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/reviews/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Probably should be None.
```
reviewboard/reviews/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Can you move this value before the AJAX_SERIAL one?
```

reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 5)

The issue has been resolved. Show all issues

All var statements should go at the top of the file, like:
`var Item,

     StoredItems;
...
Item = ...
StoredItems = ...

```

reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 5)
The issue has been resolved. Show all issues
```
Blank line between these.
```

reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 5)

The issue has been resolved. Show all issues

What's true? This should probably pass on all the arguments instead. It also needs to pass the correct context and check that options.success is set:

if (options && _.isFunction(options.success)) {
    options.success.apply(context, arguments);
}

reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 5)

The issue has been resolved. Show all issues

Same comments as above.

reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 5)
The issue has been resolved. Show all issues
```
I don't think these belong here.
```
reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 5)
The issue has been resolved. Show all issues
```
function() { should be aligned with the other arguments.
Same below.
```

reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 5)

An issue was opened. Show all issues

I'll be mentioning this in the related review request, but the API shouldn't return the internal codes for these. Instead, it should return boolean fields for archived vs. muted, probably. See my other review :)

chipx86

April 2, 2015, 1:03 a.m.

Oh, I thought this was coming from the API, and just realized it's passed to the template.

Well, I'd still use more human-readable names: 'archived' and 'muted'.

cristocrat

April 2, 2015, 12:57 p.m.

Sorry, shouldn't I keep using the characters I used in the ReviewRequestVisit model ('A', 'M')?

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 5)
The issue has been resolved. Show all issues
```
This doesn't seem right?
```
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 5)
The issue has been resolved. Show all issues
```
Same.
```

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 5)

The issue has been resolved. Show all issues

These are only used once in the function, so rather than assigning a local variable, I'd just use them directly below.

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 5)
The issue has been resolved. Show all issues
```
One variable per line.
Also, initialized variables go before uninitialized variables.
Same below.
```

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 5)

The issue has been resolved. Show all issues

The localization parser won't handle the addition of strings properly. This needs to actually be one long string (even if that means going over the 79 character limit).

Same below.

Diff:

Revision 6 (+366 -46)

Show changes

	reviewboard/reviews/views.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/models/userSessionModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
	reviewboard/templates/base.html
	reviewboard/templates/reviews/review_header.html
	reviewboard/templates/reviews/review_request_actions_secondary.html
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js

Status:: Completed
Change Summary:: Pushed to ucosp/cristocrat/archive-and-mute (029d534)