Summary

Add webAPI resources for archived and muted review requests

Review Request #7087 — Created March 19, 2015 and submitted May 1, 2015, 5:27 p.m.

Information

Owner

cristocrat

Repository

Review Board

Branch

master

Bugs

Depends On

~~7109~~

Blocks

7086

Commit

e23d735...

Reviewers

Groups

reviewboard, students

People

Description

This adds webAPI resources for the creation and deletion of archived and muted review requests.

Each resource is a child of the User resource and inherits from a base archived resource. Resources accept POST and DELETE requests, both of which modify ReviewRequestVisit database entries accordingly.

Testing Done

Added standard POST and DELETE tests to reviewboard.webapi.tests. All tests passed.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	March 24, 2015, 11:11 a.m.
Needs an added_in field. This should be 2.5.x (until we know when it is going to land).	brennie	March 24, 2015, 10:46 a.m.
Docstring needs more information. Blank line between these.	brennie	March 24, 2015, 11:11 a.m.
This doesn't appear to be used.	brennie	March 24, 2015, 10:46 a.m.
Fields should use hyphens instead of underscores.	brennie	March 25, 2015, 9:44 a.m.
Archive instead of watch?	brennie	March 24, 2015, 10:45 a.m.
Needs a docstring.	brennie	March 24, 2015, 11:12 a.m.
This should be (ReviewRequest.DoesNotExist, User.DoesNotExist). ObjectDoesNotExist is much too generic here. The same goes for other places you use ObjectDoesNotExist.	brennie	March 24, 2015, 10:45 a.m.
We should check if the user has view permissions for the review request, otherwise we leak information that a review …	brennie	March 25, 2015, 11:04 p.m.
Needs a docstring.	brennie	March 24, 2015, 11:12 a.m.
Needs an added_in = '2.5.x' field.	brennie	March 24, 2015, 10:47 a.m.
I don't believe this is used.	brennie	March 24, 2015, 10:47 a.m.
Needs a docstring.	brennie	March 24, 2015, 11:12 a.m.
Needs a docstring.	brennie	March 24, 2015, 11:12 a.m.
'ObjectDoesNotExist' imported but unused	reviewbot	March 25, 2015, 11:05 p.m.
Is there any model that these WebAPI resources should be based on? Also, you can add model_parent_key to point to …	VT VTL-Developer	March 25, 2015, 11:09 p.m.
undefined name 'ReviewRequest'	reviewbot	March 25, 2015, 11:07 p.m.
undefined name 'User'	reviewbot	March 25, 2015, 11:07 p.m.
undefined name 'ReviewRequest'	reviewbot	March 25, 2015, 11:07 p.m.
undefined name 'User'	reviewbot	March 25, 2015, 11:07 p.m.
Col: 23 W292 no newline at end of file	reviewbot	March 27, 2015, 10:07 p.m.
Col: 67 W292 no newline at end of file	reviewbot	March 27, 2015, 10:03 p.m.
Col: 61 W292 no newline at end of file	reviewbot	March 27, 2015, 10:03 p.m.
Should be in alphabetical order.	chipx86	April 2, 2015, 11:56 a.m.
'archived_list_mimetype' imported but unused	reviewbot	March 27, 2015, 10:03 p.m.
'get_archived_review_request_item_url' imported but unused	reviewbot	March 27, 2015, 10:06 p.m.
local variable 'archived_rsp' is assigned to but never used	reviewbot	March 27, 2015, 10:06 p.m.
Col: 53 E128 continuation line under-indented for visual indent	reviewbot	March 27, 2015, 10:06 p.m.
Col: 49 E128 continuation line under-indented for visual indent	reviewbot	March 27, 2015, 10:06 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 27, 2015, 10:06 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	March 27, 2015, 10:06 p.m.
Col: 67 W292 no newline at end of file	reviewbot	March 27, 2015, 10:06 p.m.
Col: 61 W292 no newline at end of file	reviewbot	March 27, 2015, 10:06 p.m.
'archived_list_mimetype' imported but unused	reviewbot	March 27, 2015, 10:06 p.m.
Col: 53 E128 continuation line under-indented for visual indent	reviewbot	March 27, 2015, 10:06 p.m.
Col: 49 E128 continuation line under-indented for visual indent	reviewbot	March 27, 2015, 10:06 p.m.
Col: 67 W292 no newline at end of file	reviewbot	March 27, 2015, 10:09 p.m.
Col: 61 W292 no newline at end of file	reviewbot	March 27, 2015, 10:09 p.m.
'archived_list_mimetype' imported but unused	reviewbot	March 27, 2015, 10:09 p.m.
Col: 53 E128 continuation line under-indented for visual indent	reviewbot	March 27, 2015, 10:09 p.m.
Col: 49 E128 continuation line under-indented for visual indent	reviewbot	March 27, 2015, 10:09 p.m.
local variable 'visit' is assigned to but never used	reviewbot	March 29, 2015, 7:08 p.m.
Creates -> Create	JY jyuen	April 2, 2015, 11:54 a.m.
This should probably check if user is an instance of basestring instead, to better communicate intentions.	chipx86	April 2, 2015, noon
This can be one statement.	chipx86	April 2, 2015, 12:01 p.m.
List -> Lists manipulates -> manipulate	JY jyuen	April 2, 2015, 11:54 a.m.
Marks -> Mark	JY jyuen	April 2, 2015, 11:54 a.m.
Deletes -> Delete	JY jyuen	April 2, 2015, 11:54 a.m.
You can save a query in the common case by doing: visit, is_new = ReviewRequestVisit.objects.get_or_create( user=user, review_request=review_request, defaults={ 'visibility': self.visibility, …	chipx86	April 2, 2015, 12:06 p.m.
Same note as above.	chipx86	April 2, 2015, 12:13 p.m.
Lists -> List manipulates -> manipulate	JY jyuen	April 2, 2015, 11:54 a.m.
That's not really true, though. This is returning review requests.	chipx86	April 2, 2015, 12:15 p.m.
Marks -> Mark	JY jyuen	April 2, 2015, 11:54 a.m.
Deletes -> Delete	JY jyuen	April 2, 2015, 11:54 a.m.
Col: 9 E303 too many blank lines (2)	reviewbot	April 2, 2015, 12:21 p.m.

Status: Discarded

Status: Re-opened

Summary:

-	Added visibility field to ReviewRequestVisit
+	Adds webAPI resources for archived and muted review requests.

Description:

~		The visibility field has three states: visible (V), archived (A), and muted (M). A database evolution, reviewrequestvisit_visibility, was also written for this change.
	~	Added webAPI resources for archived and muted review requests.
-
-		Added filtering archived and muted requests in the dashboard
-
-		Based on the state of the dashboard's show_archived attribute, review requests that are either archived or muted will be filtered from the queryset.
-
-		Added Archive and Mute buttons in a Hide dropdown menu in a review request view
-
-
-
-		dded button handlers that communicate with the webAPI.
-
-		Augmented the UserSession WatchedItem (renamed StoredItem) to also include archivedReviewRequests and mutedReviewRequests. The only difference these objects are their URL and their error messages (addError and removeError methods were added in order to set different errors). Review request visibility is now passed as context data to templates.
-
-		Added dashboard button that toggles between showing and hiding hiden review requests.
-
-
-
-		Added banners for archiving and muting review requests.
-
-		Archived and Muted banners appear when a review request has been archived or muted. Each banner contains a button that can unarchive or unmute the review request. All of these events trigger a page refresh.
-
-		Added webAPI resources for archived and muted revuew requests.

		Each resource is a child of the User resource. Resources accept POST and DELETE requests, both of which modify ReviewRequestVisit database entries accordingly.

Commit:

+	e23d735023f66b21435440e294c28d424b80c4c2

Diff:

Revision 1 (+482 -52)

	reviewboard/accounts/models.py
	reviewboard/accounts/evolutions/__init__.py
	reviewboard/accounts/evolutions/reviewrequestvisit_visibility.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/models/userSessionModel.js
	9 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/evolutions/reviewrequestvisit_visibility.py
    reviewboard/datagrids/grids.py
    reviewboard/accounts/models.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/datagrids/hideable_review_request_listview.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/css/common.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/evolutions/reviewrequestvisit_visibility.py
    reviewboard/datagrids/grids.py
    reviewboard/accounts/models.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py

Ignored Files:
    reviewboard/templates/base.html
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/datagrids/hideable_review_request_listview.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/css/common.less
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/static/rb/js/models/userSessionModel.js

reviewboard/datagrids/grids.py (Diff revision 1)
Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```

Summary:

-	Adds webAPI resources for archived and muted review requests.
+	Add webAPI resources for archived and muted review requests.

Summary:

-	Add webAPI resources for archived and muted review requests.
+	[WIP] Add webAPI resources for archived and muted review requests.

Depends On:

+	~~7086 - Add UI to archive and mute review requests with dashboard filters~~

Diff:

Revision 2 (+150)

Show changes

	reviewboard/webapi/resources/archived_review_request.py
	reviewboard/webapi/resources/muted_review_request.py
	reviewboard/webapi/resources/user.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/resources/archived_review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/resources/archived_review_request.py

The MutedReviewRequestResource and ArchivedReviewRequestResource are very similar and they should maybe be refactored to inherit from a base class that does most of the machinery. Then the subclasses can implement the methods via the @augment_method_from decorator.

reviewboard/webapi/resources/archived_review_request.py (Diff revision 2)

Show all issues

Needs an added_in field. This should be 2.5.x (until we know when it is going to land).

brennie March 19, 2015, 9:42 p.m.

Actually, this should be 3.0 because we are currently doing the feature freeze for 2.5.x.

reviewboard/webapi/resources/archived_review_request.py (Diff revision 2)
Show all issues
```
Docstring needs more information.
Blank line between these.
```
reviewboard/webapi/resources/archived_review_request.py (Diff revision 2)
Show all issues
```
This doesn't appear to be used.
```

reviewboard/webapi/resources/archived_review_request.py (Diff revision 2)

Show all issues

Fields should use hyphens instead of underscores.

cristocrat March 24, 2015, 10:53 a.m.

Is reviewboard gradually switching over to hyphens as well? Just that I see most other fields use underscores in other resources

brennie March 25, 2015, 9:46 a.m.

Oops! Sorry, you can ignore this one. Fields are supposed to use underscores.

reviewboard/webapi/resources/archived_review_request.py (Diff revision 2)
Show all issues
```
Archive instead of watch?
```
reviewboard/webapi/resources/archived_review_request.py (Diff revision 2)
Show all issues
```
Needs a docstring.
```

reviewboard/webapi/resources/archived_review_request.py (Diff revision 2)

This is becuase you can't put a keyword argument after *args right?

reviewboard/webapi/resources/archived_review_request.py (Diff revision 2)

Show all issues

This should be (ReviewRequest.DoesNotExist, User.DoesNotExist). ObjectDoesNotExist is much too generic here.

The same goes for other places you use ObjectDoesNotExist.

reviewboard/webapi/resources/archived_review_request.py (Diff revision 2)

Show all issues

We should check if the user has view permissions for the review request, otherwise we leak information that a review request that they do not have permissions to view exists.

Same elsewhere.

cristocrat March 24, 2015, 10:53 a.m.

does @webapi_check_local_site does this?

brennie March 25, 2015, 9:46 a.m.

I'm not sure. You should ask someone who knows more about local sites than I.

reviewboard/webapi/resources/archived_review_request.py (Diff revision 2)
Show all issues
```
Needs a docstring.
```

reviewboard/webapi/resources/muted_review_request.py (Diff revision 2)

Show all issues

Needs an added_in = '2.5.x' field.

brennie March 19, 2015, 9:42 p.m.

Actually, this should be 3.0 because we are currently doing the feature freeze for 2.5.x.

reviewboard/webapi/resources/muted_review_request.py (Diff revision 2)
Show all issues
```
I don't believe this is used.
```
reviewboard/webapi/resources/muted_review_request.py (Diff revision 2)
Show all issues
```
Needs a docstring.
```
reviewboard/webapi/resources/muted_review_request.py (Diff revision 2)
Show all issues
```
Needs a docstring.
```

Description:

		Added webAPI resources for archived and muted review requests.

~		Each resource is a child of the User resource. Resources accept POST and DELETE requests, both of which modify ReviewRequestVisit database entries accordingly.
	~	Each resource is a child of the User resource and inherits from a base hidden resource. Resources accept POST and DELETE requests, both of which modify ReviewRequestVisit database entries accordingly.

Diff:

Revision 3 (+171 -1)

Show changes

	reviewboard/templates/base.html
	reviewboard/webapi/resources/archived_review_request.py
	reviewboard/webapi/resources/base_hidden_object.py
	reviewboard/webapi/resources/muted_review_request.py
	reviewboard/webapi/resources/user.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/resources/base_hidden_object.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py

Ignored Files:
    reviewboard/templates/base.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/resources/base_hidden_object.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py

Ignored Files:
    reviewboard/templates/base.html

reviewboard/webapi/resources/base_hidden_object.py (Diff revision 3)
Show all issues
```
 'ObjectDoesNotExist' imported but unused
```
reviewboard/webapi/resources/base_hidden_object.py (Diff revision 3)
Show all issues
```
 undefined name 'ReviewRequest'
```
reviewboard/webapi/resources/base_hidden_object.py (Diff revision 3)
Show all issues
```
 undefined name 'User'
```
reviewboard/webapi/resources/base_hidden_object.py (Diff revision 3)
Show all issues
```
 undefined name 'ReviewRequest'
```
reviewboard/webapi/resources/base_hidden_object.py (Diff revision 3)
Show all issues
```
 undefined name 'User'
```
reviewboard/webapi/resources/base_hidden_object.py (Diff revision 3)
Show all issues
```
Col: 23
 W292 no newline at end of file
```

reviewboard/webapi/resources/base_hidden_object.py (Diff revision 3)

Show all issues

Is there any model that these WebAPI resources should be based on?

Also, you can add model_parent_key to point to the parent.

You can check out https://github.com/djblets/djblets/blob/master/djblets/webapi/resources.py#L383 for a list of fields that may also be relevant.

Summary:

-	[WIP] Add webAPI resources for archived and muted review requests.
+	[WIP] Add webAPI resources for archived and muted review requests

Depends On:

-	~~7086 - Add UI to archive and mute review requests with dashboard filters~~
+	~~7091 - Fix rbt patch for some SCMs.~~

Diff:

Revision 4 (+300)

Show changes

	reviewboard/webapi/resources/archived_review_request.py
	reviewboard/webapi/resources/base_archived_object.py
	reviewboard/webapi/resources/muted_review_request.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/test_archived_review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/resources/base_archived_object.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/resources/base_archived_object.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py

reviewboard/webapi/resources/archived_review_request.py (Diff revision 4)
Show all issues
```
Col: 67
 W292 no newline at end of file
```
reviewboard/webapi/resources/muted_review_request.py (Diff revision 4)
Show all issues
```
Col: 61
 W292 no newline at end of file
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 4)
Show all issues
```
 'archived_list_mimetype' imported but unused
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 4)
Show all issues
```
 'get_archived_review_request_item_url' imported but unused
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 4)
Show all issues
```
 local variable 'archived_rsp' is assigned to but never used
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 4)
Show all issues
```
Col: 53
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 4)
Show all issues
```
Col: 49
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 4)
Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 4)
Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

Diff:

Revision 5 (+337)

Show changes

	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/archived_review_request.py
	reviewboard/webapi/resources/base_archived_object.py
	reviewboard/webapi/resources/muted_review_request.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_archived_review_request.py
	reviewboard/webapi/tests/urls.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py

reviewboard/webapi/resources/archived_review_request.py (Diff revision 5)
Show all issues
```
Col: 67
 W292 no newline at end of file
```
reviewboard/webapi/resources/muted_review_request.py (Diff revision 5)
Show all issues
```
Col: 61
 W292 no newline at end of file
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 5)
Show all issues
```
 'archived_list_mimetype' imported but unused
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 5)
Show all issues
```
Col: 53
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 5)
Show all issues
```
Col: 49
 E128 continuation line under-indented for visual indent
```

Depends On:

-	~~7091 - Fix rbt patch for some SCMs.~~
+	~~7109 - Add a Dashboard toggle to show or hide archived review requests~~

Diff:

Revision 6 (+337)

Show changes

	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/archived_review_request.py
	reviewboard/webapi/resources/base_archived_object.py
	reviewboard/webapi/resources/muted_review_request.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_archived_review_request.py
	reviewboard/webapi/tests/urls.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py

reviewboard/webapi/resources/archived_review_request.py (Diff revision 6)
Show all issues
```
Col: 67
 W292 no newline at end of file
```
reviewboard/webapi/resources/muted_review_request.py (Diff revision 6)
Show all issues
```
Col: 61
 W292 no newline at end of file
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 6)
Show all issues
```
 'archived_list_mimetype' imported but unused
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 6)
Show all issues
```
Col: 53
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 6)
Show all issues
```
Col: 49
 E128 continuation line under-indented for visual indent
```

Description:

		Added webAPI resources for archived and muted review requests.

~		Each resource is a child of the User resource and inherits from a base hidden resource. Resources accept POST and DELETE requests, both of which modify ReviewRequestVisit database entries accordingly.
	~	Each resource is a child of the User resource and inherits from a base archived resource. Resources accept POST and DELETE requests, both of which modify ReviewRequestVisit database entries accordingly.

Diff:

Revision 7 (+334)

Show changes

	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/archived_review_request.py
	reviewboard/webapi/resources/base_archived_object.py
	reviewboard/webapi/resources/muted_review_request.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_archived_review_request.py
	reviewboard/webapi/tests/urls.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py

Summary:

-	[WIP] Add webAPI resources for archived and muted review requests
+	Add webAPI resources for archived and muted review requests

Description:

~		Added webAPI resources for archived and muted review requests.
	~	This adds webAPI resources for the creation and deletion of archived and muted review requests.

		Each resource is a child of the User resource and inherits from a base archived resource. Resources accept POST and DELETE requests, both of which modify ReviewRequestVisit database entries accordingly.

Testing Done:

Added standard POST and DELETE tests to reviewboard.webapi.tests. All tests passed.

Diff:

Revision 8 (+337)

Show changes

	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/archived_review_request.py
	reviewboard/webapi/resources/base_archived_object.py
	reviewboard/webapi/resources/muted_review_request.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_archived_review_request.py
	reviewboard/webapi/tests/urls.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py

reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 8)
Show all issues
```
 local variable 'visit' is assigned to but never used
```

Groups:

+	students

Diff:

Revision 9 (+336)

Show changes

	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/archived_review_request.py
	reviewboard/webapi/resources/base_archived_object.py
	reviewboard/webapi/resources/muted_review_request.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_archived_review_request.py
	reviewboard/webapi/tests/urls.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py



Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py

Some nitpicky stuff for PEP-257 compliancy

reviewboard/testing/testcase.py (Diff revision 9)
Show all issues
```
Creates -> Create
```
reviewboard/webapi/resources/archived_review_request.py (Diff revision 9)
Show all issues
```
List -> Lists

manipulates -> manipulate
```
reviewboard/webapi/resources/archived_review_request.py (Diff revision 9)
Show all issues
```
Marks -> Mark
```
reviewboard/webapi/resources/archived_review_request.py (Diff revision 9)
Show all issues
```
Deletes -> Delete
```
reviewboard/webapi/resources/muted_review_request.py (Diff revision 9)
Show all issues
```
Lists -> List

manipulates -> manipulate
```
reviewboard/webapi/resources/muted_review_request.py (Diff revision 9)
Show all issues
```
Marks -> Mark
```
reviewboard/webapi/resources/muted_review_request.py (Diff revision 9)
Show all issues
```
Deletes -> Delete
```

reviewboard/webapi/resources/user.py (Diff revision 4)
Show all issues
```
Should be in alphabetical order.
```

reviewboard/testing/testcase.py (Diff revision 9)

Show all issues

This should probably check if user is an instance of basestring instead, to better communicate intentions.

reviewboard/testing/testcase.py (Diff revision 9)
Show all issues
```
This can be one statement.
```

reviewboard/webapi/resources/base_archived_object.py (Diff revision 9)

Show all issues

You can save a query in the common case by doing:

visit, is_new = ReviewRequestVisit.objects.get_or_create(
    user=user,
    review_request=review_request,
    defaults={
        'visibility': self.visibility,
    })

if not is_new and visit.visibility != self.visibility:
    visit.visibility = self.visibility
    visit.save(update_fields=['visibility'])

reviewboard/webapi/resources/base_archived_object.py (Diff revision 9)
Show all issues
```
Same note as above.
```

reviewboard/webapi/resources/muted_review_request.py (Diff revision 9)

Show all issues

That's not really true, though. This is returning review requests.

Diff:

Revision 10 (+342 -1)

Show changes

	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/archived_review_request.py
	reviewboard/webapi/resources/base_archived_object.py
	reviewboard/webapi/resources/muted_review_request.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_archived_review_request.py
	reviewboard/webapi/tests/urls.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py

reviewboard/webapi/resources/base_archived_object.py (Diff revision 10)
Show all issues
```
Col: 9
 E303 too many blank lines (2)
```

Diff:

Revision 11 (+341 -1)

Show changes

	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/archived_review_request.py
	reviewboard/webapi/resources/base_archived_object.py
	reviewboard/webapi/resources/muted_review_request.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_archived_review_request.py
	reviewboard/webapi/tests/urls.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py



Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_archived_review_request.py
    reviewboard/webapi/resources/muted_review_request.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/archived_review_request.py
    reviewboard/webapi/resources/base_archived_object.py

Status: Closed (submitted)

Change Summary:

Pushed to ucosp/cristocrat/archive-and-mute (08266e0)