Summary

Fix rbt patch for some SCMs.

Review Request #7091 — Created March 19, 2015 and submitted March 20, 2015, 3:31 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Blocks

7095

Commit

e26dc3a...

Reviewers

Groups

rbtools

People

Description

Previously, rbt patch really only worked with Git, Perforce, and
Mercurial. When running rbt patch with another SCM (say, CVS) it
would crash. This is because not all SCMs knew how to check for empty
files support. Now, all SCMs default to no empty file support and
runnign rbt patch with these SCMs no longer causes rbt to crash.

Testing Done

Ran unit tests.

Before applying this patch, using rbt patch in a CVS repository
would cause it to crash. After applying this patch, it no longer
crashes and the patch is applied successfully.

Issues

Description	From	Last Updated
Should be "Check" instead of "Checks"	david	March 19, 2015, 6:32 p.m.
This comment is a little bit confusing. For a moment I thought we were overriding the one that the user …	david	March 20, 2015, 3:27 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/clients/perforce.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/clients/perforce.py

rbtools/clients/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should be "Check" instead of "Checks"
```

Commit:

-	da0f5014309e505b080ba81b7ba1dbbfe83876d7
+	cabde14c8f7463034147fd7c19314f2efa9d1b63

Diff:

Revision 2 (+38 -14)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/svn.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/clients/perforce.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/clients/perforce.py

Change Summary:

General cleanups.

Commit:

-	cabde14c8f7463034147fd7c19314f2efa9d1b63
+	e26dc3a42338e9d0306676d11f933e531df26508

Diff:

Revision 3 (+55 -30)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/svn.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/clients/perforce.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/clients/perforce.py

Ship it!

rbtools/clients/__init__.py (Diff revision 3)

The issue has been resolved. Show all issues

This comment is a little bit confusing. For a moment I thought we were overriding the one that the user specified.

Diff:

Revision 4 (+55 -30)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/svn.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/clients/perforce.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/clients/perforce.py

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (d4b80fd)