post-review: Handle modifications inside moved/copied directory

Review Request #3103 — Created May 11, 2012 and submitted

Information

RBTools
master

Reviewers

This change fixes an issue with post-review when a file inside a copied path is modified (or copied/moved). In that case, 'svn info' on the leaf path does not show 'Copied From URL' line - it is necessary to go up to the parent path(s) to figure out the copy-from information. Once a path with copy-from information is found, it is not necessary to go up further.
In a repository, move a directory then make changes inside that directory:

$ svn mv dir1 dir2
$ svn mv dir2/file1 dir2/x1
$ svn mv fir2/file2 dir2/x2
$ vi dir2/x2
$ vi dir2/file3
$ post-review
Description From Last Updated

Ideally, this should be moved outside the function, and documented with a docstring.

chipx86chipx86

Should fit in 80 lines. You'll need to wrap this.

chipx86chipx86
ST
ST
chipx86
  1. 
      
  2. rbtools/clients/svn.py (Diff revision 2)
     
     
     
     
     
    Ideally, this should be moved outside the function, and documented with a docstring.
  3. rbtools/clients/svn.py (Diff revision 2)
     
     
    Should fit in 80 lines. You'll need to wrap this.
  4. 
      
ST
ST
  1. Any updates on this review?
    1. Working through a backlog. Looks good. Made a couple tiny tweaks (mostly syntax preferences) and pushing. Thanks!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
ST
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (ee87c92)
Loading...