Branch: |
|
||
|---|---|---|---|
Diff: |
Revision 2 (+22 -6) |
post-review: Handle modifications inside moved/copied directory
Review Request #3103 — Created May 11, 2012 and submitted
| Information | |
|---|---|
| stilor | |
| RBTools | |
| master | |
| Reviewers | |
| rbtools | |
This change fixes an issue with post-review when a file inside a copied path is modified (or copied/moved). In that case, 'svn info' on the leaf path does not show 'Copied From URL' line - it is necessary to go up to the parent path(s) to figure out the copy-from information. Once a path with copy-from information is found, it is not necessary to go up further.
In a repository, move a directory then make changes inside that directory: $ svn mv dir1 dir2 $ svn mv dir2/file1 dir2/x1 $ svn mv fir2/file2 dir2/x2 $ vi dir2/x2 $ vi dir2/file3 $ post-review
ST
Change Summary:
I misread issue 1685: that bug deals with post-review refusing to submit a diff because 'svn diff' does not show unmodified copied files. This change does not deal with it, it deals with post-review failure to submit a diff because post-review cannot determine correct copy-from information.
Description: |
|
||||||
|---|---|---|---|---|---|---|---|
Bugs: |
|
-
-
rbtools/clients/svn.py (Diff revision 2) Ideally, this should be moved outside the function, and documented with a docstring.
-