Summary

post-review: Handle modifications inside moved/copied directory

Review Request #3103 — Created May 11, 2012 and submitted Aug. 27, 2012, 3:17 p.m.

Information

Owner

stilor

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change fixes an issue with post-review when a file inside a copied path is modified (or copied/moved). In that case, 'svn info' on the leaf path does not show 'Copied From URL' line - it is necessary to go up to the parent path(s) to figure out the copy-from information. Once a path with copy-from information is found, it is not necessary to go up further.

Testing Done

In a repository, move a directory then make changes inside that directory:

$ svn mv dir1 dir2
$ svn mv dir2/file1 dir2/x1
$ svn mv fir2/file2 dir2/x2
$ vi dir2/x2
$ vi dir2/file3
$ post-review

Issues

Description	From	Last Updated
Ideally, this should be moved outside the function, and documented with a docstring.	chipx86	June 18, 2012, 7:41 p.m.
Should fit in 80 lines. You'll need to wrap this.	chipx86	June 18, 2012, 7:41 p.m.

Branch:

master

Diff:

Revision 2 (+22 -6)

Show changes

rbtools/clients/svn.py

Change Summary:: I misread issue 1685: that bug deals with post-review refusing to submit a diff because 'svn diff' does not show unmodified copied files. This change does not deal with it, it deals with post-review failure to submit a diff because post-review cannot determine correct copy-from information.
Description:: ~
This partially fixes issue 1685 (additional changes needed on the server side, to be submitted separately). This change fixes an issue with post-review when a file inside a copied path is modified (or copied/moved). In that case, 'svn info' on the leaf path does not show 'Copied From URL' line - it is necessary to go up to the parent path(s) to figure out the copy-from information. Once a path with copy-from information is found, it is not necessary to go up further.
~
This change fixes an issue with post-review when a file inside a copied path is modified (or copied/moved). In that case, 'svn info' on the leaf path does not show 'Copied From URL' line - it is necessary to go up to the parent path(s) to figure out the copy-from information. Once a path with copy-from information is found, it is not necessary to go up further.
Bugs:: 1685

rbtools/clients/svn.py (Diff revision 2)

The issue has been resolved. Show all issues

Ideally, this should be moved outside the function, and documented with a docstring.

rbtools/clients/svn.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Should fit in 80 lines. You'll need to wrap this.
```

Change Summary:

Addressed review feedback from Christian Hammond.

Diff:

Revision 3 (+33 -6)

Show changes

rbtools/clients/svn.py

Any updates on this review?

chipx86

Aug. 27, 2012, 3:16 p.m.

Working through a backlog. Looks good. Made a couple tiny tweaks (mostly syntax preferences) and pushing. Thanks!

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (ee87c92)

~		This partially fixes issue 1685 (additional changes needed on the server side, to be submitted separately). This change fixes an issue with post-review when a file inside a copied path is modified (or copied/moved). In that case, 'svn info' on the leaf path does not show 'Copied From URL' line - it is necessary to go up to the parent path(s) to figure out the copy-from information. Once a path with copy-from information is found, it is not necessary to go up further.
	~	This change fixes an issue with post-review when a file inside a copied path is modified (or copied/moved). In that case, 'svn info' on the leaf path does not show 'Copied From URL' line - it is necessary to go up to the parent path(s) to figure out the copy-from information. Once a path with copy-from information is found, it is not necessary to go up further.